Re: + affs-convert-affs_symlink_read_folio-to-use-the-folio.patch added to mm-unstable branch

[David Sterba <dsterba@suse.cz>]

On Thu, Jul 13, 2023 at 10:26:46AM -0700, Andrew Morton wrote:
> 
> The patch titled
>      Subject: affs: convert affs_symlink_read_folio() to use the folio
> has been added to the -mm mm-unstable branch.  Its filename is
>      affs-convert-affs_symlink_read_folio-to-use-the-folio.patch
> 
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/affs-convert-affs_symlink_read_folio-to-use-the-folio.patch
> 
> This patch will later appear in the mm-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
> 
> ------------------------------------------------------
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> Subject: affs: convert affs_symlink_read_folio() to use the folio
> Date: Thu, 13 Jul 2023 04:55:07 +0100
> 
> Remove use of the old page APIs.  That includes use of setting PageError
> on error; simply not setting the uptodate flag is sufficient.
> 
> Link: https://lkml.kernel.org/r/20230713035512.4139457-3-willy@infradead.org
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Cc: David Sterba <dsterba@suse.com>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Jan Kara <jack@suse.com>
> Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: Pankaj Raghav <p.raghav@samsung.com>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Tom Rix <trix@redhat.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Acked-by: David Sterba <dsterba@suse.com>

> ---
> 
>  fs/affs/symlink.c |   12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> --- a/fs/affs/symlink.c~affs-convert-affs_symlink_read_folio-to-use-the-folio
> +++ a/fs/affs/symlink.c
> @@ -13,10 +13,9 @@
>  
>  static int affs_symlink_read_folio(struct file *file, struct folio *folio)
>  {
> -	struct page *page = &folio->page;
>  	struct buffer_head *bh;
> -	struct inode *inode = page->mapping->host;
> -	char *link = page_address(page);
> +	struct inode *inode = folio->mapping->host;
> +	char *link = folio_address(folio);
>  	struct slink_front *lf;
>  	int			 i, j;
>  	char			 c;
> @@ -58,12 +57,11 @@ static int affs_symlink_read_folio(struc
>  	}
>  	link[i] = '\0';
>  	affs_brelse(bh);
> -	SetPageUptodate(page);
> -	unlock_page(page);
> +	folio_mark_uptodate(folio);
> +	folio_unlock(folio);
>  	return 0;
>  fail:
> -	SetPageError(page);
> -	unlock_page(page);
> +	folio_unlock(folio);
>  	return -EIO;
>  }
>  
> _
> 
> Patches currently in -mm which might be from willy@infradead.org are
> 
> rmap-pass-the-folio-to-__page_check_anon_rmap.patch
> highmem-add-memcpy_to_folio-and-memcpy_from_folio.patch
> affs-convert-affs_symlink_read_folio-to-use-the-folio.patch
> affs-convert-data-read-and-write-to-use-folios.patch
> migrate-use-folio_set_bh-instead-of-set_bh_page.patch
> ntfs3-convert-ntfs_get_block_vbo-to-use-a-folio.patch
> jbd2-use-a-folio-in-jbd2_journal_write_metadata_buffer.patch
> buffer-remove-set_bh_page.patch
>