From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/6] btrfs: preparation patches for the incoming metadata folio conversion
Date: Fri, 14 Jul 2023 12:41:17 +0200 [thread overview]
Message-ID: <20230714104117.GG20457@suse.cz> (raw)
In-Reply-To: <3414dd0b-7b69-28d4-28c4-3405e9b8139f@gmx.com>
On Fri, Jul 14, 2023 at 06:32:27PM +0800, Qu Wenruo wrote:
> >> Already running the auto group with that branch, and no explosion so far
> >> (btrfs/004 failed to mount with -o atime though).
> >>
> >> Any extra setup needed to trigger the failure?
> >
> > I'm not aware of anything different than usual. Patches applied to git,
> > built, updated VM and started. I had another branch built and tested and
> > it finished the fstests. I can at least bisect which patch does it.
>
> A bisection would be very appreciated.
>
> Although I guess it should be the memcpy_extent_buffer() patch, I didn't
> see something obvious right now...
5ebf7593abb81ec1993f31e90a7573b75aff4db4 is the first bad commit
btrfs: refactor main loop in memcpy_extent_buffer()
$ git bisect log
# bad: [5c6c140622dd7107acb13da404f0c682f1f954a6] btrfs: copy all pages at once at the end of btrfs_clone_extent_buffer()
# good: [72c15cf7e64769ca9273a825fff8495d99975c9c] btrfs: deprecate integrity checker feature
git bisect start 'ext/qu-eb-page-clanups-updated-broken' '72c15cf7e64769ca9273a825fff8495d99975c9c'
# good: [85ab525a6a63c477b92099835d6b05eaebd4ad4b] btrfs: use write_extent_buffer() to implement write_extent_buffer_*id()
git bisect good 85ab525a6a63c477b92099835d6b05eaebd4ad4b
# bad: [cd6668ef43a224b3f8130b78f4e3b922a7175a05] btrfs: refactor main loop in copy_extent_buffer_full()
git bisect bad cd6668ef43a224b3f8130b78f4e3b922a7175a05
# bad: [5ebf7593abb81ec1993f31e90a7573b75aff4db4] btrfs: refactor main loop in memcpy_extent_buffer()
git bisect bad 5ebf7593abb81ec1993f31e90a7573b75aff4db4
# first bad commit: [5ebf7593abb81ec1993f31e90a7573b75aff4db4] btrfs: refactor main loop in memcpy_extent_buffer()
next prev parent reply other threads:[~2023-07-14 10:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 6:37 [PATCH v2 0/6] btrfs: preparation patches for the incoming metadata folio conversion Qu Wenruo
2023-07-12 6:37 ` [PATCH v2 1/6] btrfs: tests: enhance extent buffer bitmap tests Qu Wenruo
2023-07-12 6:37 ` [PATCH v2 2/6] btrfs: refactor extent buffer bitmaps operations Qu Wenruo
2023-07-13 11:53 ` David Sterba
2023-07-12 6:37 ` [PATCH v2 3/6] btrfs: use write_extent_buffer() to implement write_extent_buffer_*id() Qu Wenruo
2023-07-12 6:37 ` [PATCH v2 4/6] btrfs: refactor memcpy_extent_buffer() Qu Wenruo
2023-07-13 11:51 ` David Sterba
2023-07-12 6:37 ` [PATCH v2 5/6] btrfs: refactor copy_extent_buffer_full() Qu Wenruo
2023-07-12 6:37 ` [PATCH v2 6/6] btrfs: call copy_extent_buffer_full() inside btrfs_clone_extent_buffer() Qu Wenruo
2023-07-13 11:55 ` David Sterba
2023-07-12 6:44 ` [PATCH v2 0/6] btrfs: preparation patches for the incoming metadata folio conversion Sweet Tea Dorminy
2023-07-12 16:41 ` Christoph Hellwig
2023-07-12 23:58 ` Qu Wenruo
2023-07-13 11:16 ` Christoph Hellwig
2023-07-13 11:26 ` David Sterba
2023-07-13 11:41 ` Qu Wenruo
2023-07-13 11:49 ` David Sterba
2023-07-13 12:09 ` David Sterba
2023-07-13 16:39 ` David Sterba
2023-07-13 21:30 ` Qu Wenruo
2023-07-13 22:03 ` David Sterba
2023-07-14 0:09 ` Qu Wenruo
2023-07-14 0:26 ` David Sterba
2023-07-14 1:58 ` Qu Wenruo
2023-07-14 10:03 ` David Sterba
2023-07-14 10:32 ` Qu Wenruo
2023-07-14 10:41 ` David Sterba [this message]
2023-07-15 0:39 ` Qu Wenruo
2023-07-15 1:02 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230714104117.GG20457@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.