From: Frederic Weisbecker <frederic@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <frederic@kernel.org>
Subject: [PATCH 1/3] tick/nohz: Rename the tick handlers to more self-explanatory names
Date: Fri, 14 Jul 2023 14:08:50 +0200 [thread overview]
Message-ID: <20230714120852.23573-2-frederic@kernel.org> (raw)
In-Reply-To: <20230714120852.23573-1-frederic@kernel.org>
The current name of the tick handlers don't tell much about what differ
between them. Use names that better reflect their role and resolution.
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
kernel/time/tick-sched.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 89055050d1ac..a7b5960258f2 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -1355,7 +1355,7 @@ void tick_nohz_idle_exit(void)
/*
* The nohz low res interrupt handler
*/
-static void tick_nohz_handler(struct clock_event_device *dev)
+static void tick_lowres_handler(struct clock_event_device *dev)
{
struct tick_sched *ts = this_cpu_ptr(&tick_cpu_sched);
struct pt_regs *regs = get_irq_regs();
@@ -1401,7 +1401,7 @@ static void tick_nohz_switch_to_nohz(void)
if (!tick_nohz_enabled)
return;
- if (tick_switch_to_oneshot(tick_nohz_handler))
+ if (tick_switch_to_oneshot(tick_lowres_handler))
return;
/*
@@ -1464,7 +1464,7 @@ void tick_irq_enter(void)
* We rearm the timer until we get disabled by the idle code.
* Called with interrupts disabled.
*/
-static enum hrtimer_restart tick_sched_timer(struct hrtimer *timer)
+static enum hrtimer_restart tick_highres_handler(struct hrtimer *timer)
{
struct tick_sched *ts =
container_of(timer, struct tick_sched, sched_timer);
@@ -1513,7 +1513,7 @@ void tick_setup_sched_timer(void)
* Emulate tick processing via per-CPU hrtimers:
*/
hrtimer_init(&ts->sched_timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_HARD);
- ts->sched_timer.function = tick_sched_timer;
+ ts->sched_timer.function = tick_highres_handler;
/* Get the next period (per-CPU) */
hrtimer_set_expires(&ts->sched_timer, tick_init_jiffy_update());
--
2.34.1
next prev parent reply other threads:[~2023-07-14 12:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 12:08 [PATCH 0/3] tick/nohz cleanups Frederic Weisbecker
2023-07-14 12:08 ` Frederic Weisbecker [this message]
2023-07-14 18:28 ` [PATCH 1/3] tick/nohz: Rename the tick handlers to more self-explanatory names Joel Fernandes
2023-07-14 12:08 ` [PATCH 2/3] tick/nohz: Update obsolete comments Frederic Weisbecker
2023-07-14 12:08 ` [PATCH 3/3] tick/nohz: Don't shutdown the lowres tick from itself Frederic Weisbecker
2023-07-14 18:44 ` Joel Fernandes
2023-07-15 0:01 ` Frederic Weisbecker
2023-07-15 1:02 ` Joel Fernandes
2023-07-15 18:18 ` Frederic Weisbecker
2023-07-15 22:31 ` Joel Fernandes
2023-07-17 17:30 ` Joel Fernandes
2023-07-25 10:01 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230714120852.23573-2-frederic@kernel.org \
--to=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.