All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	cem@kernel.org, linux-xfs@vger.kernel.org, keescook@chromium.org,
	david@fromorbit.com
Subject: Re: [PATCH 1/3] xfs: convert flex-array declarations in struct xfs_attrlist*
Date: Fri, 14 Jul 2023 16:56:11 +0200	[thread overview]
Message-ID: <20230714145611.GA4012@lst.de> (raw)
In-Reply-To: <20230714145439.GY108251@frogsfrogsfrogs>

On Fri, Jul 14, 2023 at 07:54:39AM -0700, Darrick J. Wong wrote:
> FWIW I tried removing the attrlist ioctl structs, but I couldn't find
> anywhere else in the kernel uapi headers that defines them so that the
> ioctl code can actually format the buffer.

We need to keep them somewhere.  But I'd rather not do that in xfs_fs.h
which through xfsprogs goes into /usr/include/.

I'd probably do it locally in xfs_ioctl.c with an extended version of
the comment about matching the libattr structures.

  reply	other threads:[~2023-07-14 14:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14 14:45 [PATCHSET 0/3] xfsprogs: ubsan fixes for 6.5-rc2 Darrick J. Wong
2023-07-14 14:45 ` [PATCH 1/3] xfs: convert flex-array declarations in struct xfs_attrlist* Darrick J. Wong
2023-07-14 14:46   ` Christoph Hellwig
2023-07-14 14:54     ` Darrick J. Wong
2023-07-14 14:56       ` Christoph Hellwig [this message]
2023-07-14 14:45 ` [PATCH 2/3] xfs: convert flex-array declarations in xfs attr leaf blocks Darrick J. Wong
2023-07-14 14:54   ` Christoph Hellwig
2023-07-14 14:45 ` [PATCH 3/3] xfs: convert flex-array declarations in xfs attr shortform objects Darrick J. Wong
2023-07-14 14:50   ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2023-07-14 14:42 [PATCHSET 0/3] xfs: ubsan fixes for 6.5-rc2 Darrick J. Wong
2023-07-14 14:42 ` [PATCH 1/3] xfs: convert flex-array declarations in struct xfs_attrlist* Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230714145611.GA4012@lst.de \
    --to=hch@lst.de \
    --cc=cem@kernel.org \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.