From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A84FEB64DC for ; Fri, 14 Jul 2023 17:52:41 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4R2fFg4Dx0z3cdM for ; Sat, 15 Jul 2023 03:52:39 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.166.49; helo=mail-io1-f49.google.com; envelope-from=robherring2@gmail.com; receiver=lists.ozlabs.org) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4R2fF75Kqtz3c5P for ; Sat, 15 Jul 2023 03:52:11 +1000 (AEST) Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-78372625badso83219539f.3 for ; Fri, 14 Jul 2023 10:52:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689357129; x=1691949129; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v+dvAcOgxDmgmtJaKkp391KUSnHq6CxLLiwJgC4XldE=; b=VcCYeIaRJjyrAiDXaXN8ilhwXGbBow2Kn0z5k3JS4wT/dtILRoJSfdaj4LGeCZCmlx W//wXbbuYm61R4HOelh24f1kbFL5Mo9yj5pQufvFeAc6C1NMCeVMAAocWcvd0KKcaWWl 7vvFNU9dhRmVoRtp+t5kkrWvllNtVCSw6pSxwr88FZW8Wh7n2yFHNVQwqisXsBIFlmco c1nVDF97lPqkV1DCIvbvCbs0uFm69IncQOjLJjMR8GlPKpFusSSSwypkJfEt+OLEg34L lsiqeuQFc44HC9g/jNN8/rvA2YqTGKW5XAFAz198UlDrImETkaReK9sxqIiYzbqxB7f8 j3hw== X-Gm-Message-State: ABy/qLaXMuPQQAGueoLECA0B3WGELAZCFT3/LAU1cvrZga6RdVD/s2Jz b4CAZg91/uP3l2vj6IS6EHKbkeOCdY/8 X-Google-Smtp-Source: APBJJlHohBxe7Qp0+ZNeCvGssF6Gz6tQJIdtFT2lCWyZlAxy09JjZeeEjqhLOZQKLkUtF1Hiy/Gi/A== X-Received: by 2002:a5d:9810:0:b0:783:72d4:8c38 with SMTP id a16-20020a5d9810000000b0078372d48c38mr5516566iol.13.1689357128804; Fri, 14 Jul 2023 10:52:08 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id cg5-20020a056602254500b0078335414ddesm2866650iob.26.2023.07.14.10.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jul 2023 10:52:08 -0700 (PDT) Received: (nullmailer pid 4067402 invoked by uid 1000); Fri, 14 Jul 2023 17:51:33 -0000 From: Rob Herring To: Li Yang , Qiang Zhao Subject: [PATCH] soc: fsl: Explicitly include correct DT includes Date: Fri, 14 Jul 2023 11:51:31 -0600 Message-Id: <20230714175131.4067339-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring --- drivers/soc/fsl/dpaa2-console.c | 3 ++- drivers/soc/fsl/qe/qe_common.c | 1 - drivers/soc/fsl/qe/qe_tdm.c | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/soc/fsl/dpaa2-console.c b/drivers/soc/fsl/dpaa2-console.c index 53917410f2bd..1dca693b6b38 100644 --- a/drivers/soc/fsl/dpaa2-console.c +++ b/drivers/soc/fsl/dpaa2-console.c @@ -9,9 +9,10 @@ #define pr_fmt(fmt) "dpaa2-console: " fmt #include -#include +#include #include #include +#include #include #include #include diff --git a/drivers/soc/fsl/qe/qe_common.c b/drivers/soc/fsl/qe/qe_common.c index a0cb8e746879..9729ce86db59 100644 --- a/drivers/soc/fsl/qe/qe_common.c +++ b/drivers/soc/fsl/qe/qe_common.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/soc/fsl/qe/qe_tdm.c b/drivers/soc/fsl/qe/qe_tdm.c index 7d7d78d3ee50..a3b691875c8e 100644 --- a/drivers/soc/fsl/qe/qe_tdm.c +++ b/drivers/soc/fsl/qe/qe_tdm.c @@ -9,9 +9,7 @@ */ #include #include -#include -#include -#include +#include #include static int set_tdm_framer(const char *tdm_framer_type) -- 2.40.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C296C001DC for ; Fri, 14 Jul 2023 17:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Laf+dqZspAz2V7ZTUzFBZSa3NQk9PmFxarQaVCpMWtM=; b=0ZUJqHZ2EuLcwq IX2mIREuRYAARxezPemQdEa5H0czw9bQnwhSo2i+3VudnpYKI5106E5EiBVrYdk4JGOucVg5ZBmH9 BRzKrqaNDAW9s12e7lnn1A8Ze7+vlq+wNLIS8rqZemXLyzodZFK5zyrN8CVWGgHhJ8QTMU3PP76vp WoHClEijG9olBrYy3VjfHnwyy1dVyEefFqMmK0QSAaL/7XVYZ70g3NDA+YJDz3gzdS/bpSq8CdY+T /2K0m6WEUkGYgAF+wVGpgY0U8EDHyvtklYoCFmWf7UkqKhVGlLBiCDaHbKfkFR7QOwCGRp/Sp1cUM VkPUQ3TOPGiRgT2XGlFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qKMxl-006sPn-0r; Fri, 14 Jul 2023 17:52:17 +0000 Received: from mail-io1-f41.google.com ([209.85.166.41]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qKMxe-006sDz-2K for linux-arm-kernel@lists.infradead.org; Fri, 14 Jul 2023 17:52:12 +0000 Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-783549ef058so83652839f.2 for ; Fri, 14 Jul 2023 10:52:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689357129; x=1691949129; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v+dvAcOgxDmgmtJaKkp391KUSnHq6CxLLiwJgC4XldE=; b=E/8uMMylyjHhlszwVxBSCLSquuoFj4oARjdLvQAQcawonmAty3AniK4dBx2023cAWk ADv1Xaflm/SSew0ao3E61Zej2qu5yZb3dI6Yd2vmvLh3SNxdlf/mB389ITapNjqsgLz3 ePcX377J7S++UOzrnEx9RJlBrUvHaJb37iaknmHZV8luSgNXu6EqzsefSoWlxcANHhWW FF9gHdOtD0A4qDxv0McHoxuDDaPrG54jadxkTJ3bUehf+QNpykiGe2TSaM2+KKpNPZya PvWHe2GOr2Awsa3FE7zOEYdh+5GtZpU5+qOmjcP6pxPJDjz2csb912eZfW2Po4Nfny1t 9X/g== X-Gm-Message-State: ABy/qLbDQz6fncc8XeMD3WNcpFRjUiNlYWrTf11jNEeegPNlJ+mfdDj5 lMvQQOw9CXIsdqE1B8J1pA== X-Google-Smtp-Source: APBJJlHohBxe7Qp0+ZNeCvGssF6Gz6tQJIdtFT2lCWyZlAxy09JjZeeEjqhLOZQKLkUtF1Hiy/Gi/A== X-Received: by 2002:a5d:9810:0:b0:783:72d4:8c38 with SMTP id a16-20020a5d9810000000b0078372d48c38mr5516566iol.13.1689357128804; Fri, 14 Jul 2023 10:52:08 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id cg5-20020a056602254500b0078335414ddesm2866650iob.26.2023.07.14.10.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jul 2023 10:52:08 -0700 (PDT) Received: (nullmailer pid 4067402 invoked by uid 1000); Fri, 14 Jul 2023 17:51:33 -0000 From: Rob Herring To: Li Yang , Qiang Zhao Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: fsl: Explicitly include correct DT includes Date: Fri, 14 Jul 2023 11:51:31 -0600 Message-Id: <20230714175131.4067339-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230714_105210_788446_54B7D336 X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring --- drivers/soc/fsl/dpaa2-console.c | 3 ++- drivers/soc/fsl/qe/qe_common.c | 1 - drivers/soc/fsl/qe/qe_tdm.c | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/soc/fsl/dpaa2-console.c b/drivers/soc/fsl/dpaa2-console.c index 53917410f2bd..1dca693b6b38 100644 --- a/drivers/soc/fsl/dpaa2-console.c +++ b/drivers/soc/fsl/dpaa2-console.c @@ -9,9 +9,10 @@ #define pr_fmt(fmt) "dpaa2-console: " fmt #include -#include +#include #include #include +#include #include #include #include diff --git a/drivers/soc/fsl/qe/qe_common.c b/drivers/soc/fsl/qe/qe_common.c index a0cb8e746879..9729ce86db59 100644 --- a/drivers/soc/fsl/qe/qe_common.c +++ b/drivers/soc/fsl/qe/qe_common.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/soc/fsl/qe/qe_tdm.c b/drivers/soc/fsl/qe/qe_tdm.c index 7d7d78d3ee50..a3b691875c8e 100644 --- a/drivers/soc/fsl/qe/qe_tdm.c +++ b/drivers/soc/fsl/qe/qe_tdm.c @@ -9,9 +9,7 @@ */ #include #include -#include -#include -#include +#include #include static int set_tdm_framer(const char *tdm_framer_type) -- 2.40.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D40BFEB64DC for ; Fri, 14 Jul 2023 18:04:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236064AbjGNSE1 (ORCPT ); Fri, 14 Jul 2023 14:04:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236406AbjGNSEZ (ORCPT ); Fri, 14 Jul 2023 14:04:25 -0400 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 052EB3ABA; Fri, 14 Jul 2023 11:04:00 -0700 (PDT) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-668730696a4so1507297b3a.1; Fri, 14 Jul 2023 11:03:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689357740; x=1691949740; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v+dvAcOgxDmgmtJaKkp391KUSnHq6CxLLiwJgC4XldE=; b=EMwEHR6dEuaA6Ip0IBg4ktqvU6EaqzxOaqAnIAoAyTvO2LCLlLwYeFhJ65j860BVim RlYG905ec7R8145pHfc/hAcRSnq7R6RiVayYLAsI+PGWqqXREw72XNe7zCh2ZXbr1p2n pa3TGnox3rQahSRciTKy8WNi6j+kYQmbTNEv+tcxZW1QXbqiVbCxrceB4o4srd70xpA2 OAD2m49ysFKHrZub+rdxE2xQxM6c16krcQHFA1VBN+1yPEu/FaF0c+I8Gza8h+T0LBeu +ERFb0K5EVQ7Oy1YAQVExajGFEF8KJbEjzls2ecD+BqqPNBsrsXXVvTWPmd0yYKl1/y9 RSCg== X-Gm-Message-State: ABy/qLYjRKeeoNHs+WUpexkgTGQ+z2tGWUdq4vF4Zs4oht6wOUZM5nnT TQhiVu2c7vCVJI1j/SE8OQu+E2yk4s4P X-Google-Smtp-Source: APBJJlHohBxe7Qp0+ZNeCvGssF6Gz6tQJIdtFT2lCWyZlAxy09JjZeeEjqhLOZQKLkUtF1Hiy/Gi/A== X-Received: by 2002:a5d:9810:0:b0:783:72d4:8c38 with SMTP id a16-20020a5d9810000000b0078372d48c38mr5516566iol.13.1689357128804; Fri, 14 Jul 2023 10:52:08 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id cg5-20020a056602254500b0078335414ddesm2866650iob.26.2023.07.14.10.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jul 2023 10:52:08 -0700 (PDT) Received: (nullmailer pid 4067402 invoked by uid 1000); Fri, 14 Jul 2023 17:51:33 -0000 From: Rob Herring To: Li Yang , Qiang Zhao Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: fsl: Explicitly include correct DT includes Date: Fri, 14 Jul 2023 11:51:31 -0600 Message-Id: <20230714175131.4067339-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring --- drivers/soc/fsl/dpaa2-console.c | 3 ++- drivers/soc/fsl/qe/qe_common.c | 1 - drivers/soc/fsl/qe/qe_tdm.c | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/soc/fsl/dpaa2-console.c b/drivers/soc/fsl/dpaa2-console.c index 53917410f2bd..1dca693b6b38 100644 --- a/drivers/soc/fsl/dpaa2-console.c +++ b/drivers/soc/fsl/dpaa2-console.c @@ -9,9 +9,10 @@ #define pr_fmt(fmt) "dpaa2-console: " fmt #include -#include +#include #include #include +#include #include #include #include diff --git a/drivers/soc/fsl/qe/qe_common.c b/drivers/soc/fsl/qe/qe_common.c index a0cb8e746879..9729ce86db59 100644 --- a/drivers/soc/fsl/qe/qe_common.c +++ b/drivers/soc/fsl/qe/qe_common.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/soc/fsl/qe/qe_tdm.c b/drivers/soc/fsl/qe/qe_tdm.c index 7d7d78d3ee50..a3b691875c8e 100644 --- a/drivers/soc/fsl/qe/qe_tdm.c +++ b/drivers/soc/fsl/qe/qe_tdm.c @@ -9,9 +9,7 @@ */ #include #include -#include -#include -#include +#include #include static int set_tdm_framer(const char *tdm_framer_type) -- 2.40.1