From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org, Daniel Kiper <dkiper@net-space.pl>
Cc: Glenn Washburn <development@efficientek.com>
Subject: [PATCH] acpi: Use options enum to index command options
Date: Fri, 14 Jul 2023 15:32:04 -0500 [thread overview]
Message-ID: <20230714203204.1778539-1-development@efficientek.com> (raw)
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
grub-core/commands/acpi.c | 46 +++++++++++++++++++++++++--------------
1 file changed, 30 insertions(+), 16 deletions(-)
diff --git a/grub-core/commands/acpi.c b/grub-core/commands/acpi.c
index 1c034463cf0f..31fc60e2cb26 100644
--- a/grub-core/commands/acpi.c
+++ b/grub-core/commands/acpi.c
@@ -38,6 +38,20 @@
GRUB_MOD_LICENSE ("GPLv3+");
+enum
+ {
+ OPTION_EXCLUDE,
+ OPTION_LOAD_ONLY,
+ OPTION_V1,
+ OPTION_V2,
+ OPTION_OEMID,
+ OPTION_OEMTABLE,
+ OPTION_OEMTABLEREV,
+ OPTION_OEMTABLECREATOR,
+ OPTION_OEMTABLECREATORREV,
+ OPTION_NO_EBDA
+ };
+
static const struct grub_arg_option options[] = {
{"exclude", 'x', 0,
N_("Don't load host tables specified by comma-separated list."),
@@ -497,14 +511,14 @@ grub_cmd_acpi (struct grub_extcmd_context *ctxt, int argc, char **args)
/* RSDT consists of header and an array of 32-bit pointers. */
struct grub_acpi_table_header *rsdt;
- exclude = state[0].set ? grub_strdup (state[0].arg) : 0;
+ exclude = state[OPTION_EXCLUDE].set ? grub_strdup (state[OPTION_EXCLUDE].arg) : 0;
if (exclude)
{
for (ptr = exclude; *ptr; ptr++)
*ptr = grub_tolower (*ptr);
}
- load_only = state[1].set ? grub_strdup (state[1].arg) : 0;
+ load_only = state[OPTION_EXCLUDE].set ? grub_strdup (state[OPTION_EXCLUDE].arg) : 0;
if (load_only)
{
for (ptr = load_only; *ptr; ptr++)
@@ -612,26 +626,26 @@ grub_cmd_acpi (struct grub_extcmd_context *ctxt, int argc, char **args)
}
/* Does user specify versions to generate? */
- if (state[2].set || state[3].set)
+ if (state[OPTION_V1].set || state[OPTION_V2].set)
{
- rev1 = state[2].set;
- if (state[3].set)
+ rev1 = state[OPTION_V1].set;
+ if (state[OPTION_V2].set)
rev2 = rev2 ? : 2;
else
rev2 = 0;
}
/* Does user override root header information? */
- if (state[4].set)
- grub_strncpy (root_oemid, state[4].arg, sizeof (root_oemid));
- if (state[5].set)
- grub_strncpy (root_oemtable, state[5].arg, sizeof (root_oemtable));
- if (state[6].set)
- root_oemrev = grub_strtoul (state[6].arg, 0, 0);
- if (state[7].set)
- grub_strncpy (root_creator_id, state[7].arg, sizeof (root_creator_id));
- if (state[8].set)
- root_creator_rev = grub_strtoul (state[8].arg, 0, 0);
+ if (state[OPTION_OEMID].set)
+ grub_strncpy (root_oemid, state[OPTION_OEMID].arg, sizeof (root_oemid));
+ if (state[OPTION_OEMTABLE].set)
+ grub_strncpy (root_oemtable, state[OPTION_OEMTABLE].arg, sizeof (root_oemtable));
+ if (state[OPTION_OEMTABLEREV].set)
+ root_oemrev = grub_strtoul (state[OPTION_OEMTABLEREV].arg, 0, 0);
+ if (state[OPTION_OEMTABLECREATOR].set)
+ grub_strncpy (root_creator_id, state[OPTION_OEMTABLECREATOR].arg, sizeof (root_creator_id));
+ if (state[OPTION_OEMTABLECREATORREV].set)
+ root_creator_rev = grub_strtoul (state[OPTION_OEMTABLECREATORREV].arg, 0, 0);
/* Load user tables */
for (i = 0; i < argc; i++)
@@ -747,7 +761,7 @@ grub_cmd_acpi (struct grub_extcmd_context *ctxt, int argc, char **args)
acpi_tables = 0;
#if defined (__i386__) || defined (__x86_64__)
- if (! state[9].set)
+ if (! state[OPTION_NO_EBDA].set)
{
grub_err_t err;
err = grub_acpi_create_ebda ();
--
2.34.1
reply other threads:[~2023-07-14 20:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230714203204.1778539-1-development@efficientek.com \
--to=development@efficientek.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.