From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2E08C00528 for ; Sat, 15 Jul 2023 20:19:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230172AbjGOUTT (ORCPT ); Sat, 15 Jul 2023 16:19:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229767AbjGOUTS (ORCPT ); Sat, 15 Jul 2023 16:19:18 -0400 Received: from mailrelay1-1.pub.mailoutpod2-cph3.one.com (mailrelay1-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:400::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5516F271F for ; Sat, 15 Jul 2023 13:19:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=JxBhhYK0Y5VT2HXGIOu9TJojogxR36dmFxRFhj6IWCk=; b=EVElt5TCflzYgiRrmN27f0ZK5MwnAlXBDddOCHg6/OVohDn42qAtgNTo5OfcLdzxWG2SRBFfTehox xNOBoSfNDJzs3G7hNViFJKi/eWgcZSc8XjfH227Fu8qgxnV8T/L9k2kbIA0TZQokuWJ+ry5L7uGt3S eDRotSkr5oRNdgzxdg7YaiwxS1dKxGLKWYbj3gEJyCEtA+CikK6SwC793O4AA7oPFy3WliBjXaujiN jIW5IRtD7dVIQTKWn5fuE38KmwgPMYpkppyDRBcw0Lj664vpEaR8bSW8fFgvBrj4JprqbJ9guXY0Cs zK0jiHS5+p6sj2f0nA1gLqEzVUOMj3w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=JxBhhYK0Y5VT2HXGIOu9TJojogxR36dmFxRFhj6IWCk=; b=Z/37LrNNgkFmoRmOnuPWeSyBJ3zkNDMuzDj4yl37D//Yx8vlrZ1t4ZtvhEx9F98EMcvKO2OmDB7Cz mpB1B+iCw== X-HalOne-ID: da40b60a-234c-11ee-b5d0-99461c6a3fe8 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay1 (Halon) with ESMTPSA id da40b60a-234c-11ee-b5d0-99461c6a3fe8; Sat, 15 Jul 2023 20:19:11 +0000 (UTC) Date: Sat, 15 Jul 2023 22:19:08 +0200 From: Sam Ravnborg To: Rob Herring Cc: Liviu Dudau , David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jagan Teki , Liu Ying , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Inki Dae , Marek Szyprowski , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lucas Stach , Russell King , Christian Gmeiner , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Laurentiu Palcu , Paul Cercueil , Qiang Yu , Paul Kocialkowski , Linus Walleij , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , Marek Vasut , Stefan Agner , Jerry Han , Icenowy Zheng , Ondrej Jirman , Javier Martinez Canillas , Guido =?iso-8859-1?Q?G=FCnther?= , Purism Kernel Team , Jianhua Lu , Florian Fainelli , Broadcom internal kernel review list , Artur Weber , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , Emma Anholt , Kieran Bingham , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jyri Sarha , Tomi Valkeinen , Oleksandr Andrushchenko , Ondrej Jirman , devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-samsung-soc@vger.kernel.org, lima@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm: Explicitly include correct DT includes Message-ID: <20230715201908.GA321950@ravnborg.org> References: <20230714174545.4056287-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714174545.4056287-1-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Rob, On Fri, Jul 14, 2023 at 11:45:34AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring Acked-by: Sam Ravnborg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A5FEC001DE for ; Mon, 17 Jul 2023 07:17:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 709D010E1EB; Mon, 17 Jul 2023 07:17:39 +0000 (UTC) Received: from mailrelay1-1.pub.mailoutpod2-cph3.one.com (mailrelay1-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:400::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1270B10E154 for ; Sat, 15 Jul 2023 20:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=JxBhhYK0Y5VT2HXGIOu9TJojogxR36dmFxRFhj6IWCk=; b=EVElt5TCflzYgiRrmN27f0ZK5MwnAlXBDddOCHg6/OVohDn42qAtgNTo5OfcLdzxWG2SRBFfTehox xNOBoSfNDJzs3G7hNViFJKi/eWgcZSc8XjfH227Fu8qgxnV8T/L9k2kbIA0TZQokuWJ+ry5L7uGt3S eDRotSkr5oRNdgzxdg7YaiwxS1dKxGLKWYbj3gEJyCEtA+CikK6SwC793O4AA7oPFy3WliBjXaujiN jIW5IRtD7dVIQTKWn5fuE38KmwgPMYpkppyDRBcw0Lj664vpEaR8bSW8fFgvBrj4JprqbJ9guXY0Cs zK0jiHS5+p6sj2f0nA1gLqEzVUOMj3w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=JxBhhYK0Y5VT2HXGIOu9TJojogxR36dmFxRFhj6IWCk=; b=Z/37LrNNgkFmoRmOnuPWeSyBJ3zkNDMuzDj4yl37D//Yx8vlrZ1t4ZtvhEx9F98EMcvKO2OmDB7Cz mpB1B+iCw== X-HalOne-ID: da40b60a-234c-11ee-b5d0-99461c6a3fe8 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay1 (Halon) with ESMTPSA id da40b60a-234c-11ee-b5d0-99461c6a3fe8; Sat, 15 Jul 2023 20:19:11 +0000 (UTC) Date: Sat, 15 Jul 2023 22:19:08 +0200 From: Sam Ravnborg To: Rob Herring Subject: Re: [PATCH] drm: Explicitly include correct DT includes Message-ID: <20230715201908.GA321950@ravnborg.org> References: <20230714174545.4056287-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714174545.4056287-1-robh@kernel.org> X-Mailman-Approved-At: Mon, 17 Jul 2023 07:17:38 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xinliang Liu , dri-devel@lists.freedesktop.org, Alim Akhtar , Marijn Suijten , Steven Price , Sumit Semwal , Marek Szyprowski , linux-samsung-soc@vger.kernel.org, Robert Foss , Samuel Holland , Kevin Hilman , Javier Martinez Canillas , NXP Linux Team , linux-rockchip@lists.infradead.org, Guido =?iso-8859-1?Q?G=FCnther?= , Raphael Gallais-Pou , Sascha Hauer , etnaviv@lists.freedesktop.org, Sean Paul , Seung-Woo Kim , linux-kernel@vger.kernel.org, Ondrej Jirman , Pengutronix Kernel Team , Icenowy Zheng , freedreno@lists.freedesktop.org, Thierry Reding , Yongqin Liu , lima@lists.freedesktop.org, Chunyan Zhang , Jonathan Hunter , Liu Ying , Jagan Teki , Russell King , Alain Volmat , Jerome Brunet , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Maxime Ripard , Jianhua Lu , linux-rpi-kernel@lists.infradead.org, Tian Tao , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Neil Armstrong , Tomeu Vizoso , Sandy Huang , Paul Kocialkowski , Kyungmin Park , Maxime Coquelin , linux-tegra@vger.kernel.org, Laurent Pinchart , Andrzej Hajda , Xinwei Kong , Jernej Skrabec , Chen-Yu Tsai , Broadcom internal kernel review list , Alyssa Rosenzweig , Orson Zhai , Chun-Kuang Hu , Jonas Karlman , Abhinav Kumar , Baolin Wang , xen-devel@lists.xenproject.org, Tomi Valkeinen , linux-sunxi@lists.linux.dev, Kieran Bingham , John Stultz , Shawn Guo , Ondrej Jirman , linux-stm32@st-md-mailman.stormreply.com, Emma Anholt , Liviu Dudau , Alexandre Torgue , Mikko Perttunen , Paul Cercueil , Marek Vasut , linux-renesas-soc@vger.kernel.org, Artur Weber , Florian Fainelli , Oleksandr Andrushchenko , Jerry Han , Krzysztof Kozlowski , Qiang Yu , devicetree@vger.kernel.org, Thomas Zimmermann , linux-mediatek@lists.infradead.org, Laurentiu Palcu , Matthias Brugger , AngeloGioacchino Del Regno , Purism Kernel Team , Yannick Fertre , linux-mips@vger.kernel.org, Philippe Cornu , Dmitry Baryshkov , Jyri Sarha Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Rob, On Fri, Jul 14, 2023 at 11:45:34AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring Acked-by: Sam Ravnborg