From: Pavel Machek <pavel@ucw.cz>
To: Marek Beh??n <kabel@kernel.org>
Cc: linux-leds@vger.kernel.org, Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v2 2/3] leds: turris-omnia: initialize multi-intensity to full
Date: Sun, 16 Jul 2023 11:19:40 +0200 [thread overview]
Message-ID: <20230716091940.GB1182@bug> (raw)
In-Reply-To: <20230714085253.13544-3-kabel@kernel.org>
On Fri 2023-07-14 10:52:52, Marek Beh??n wrote:
> The default color of each LED before driver probe is (255, 255, 255).
> Initialize multi_intensity to this value, so that it corresponds to the
> reality.
>
> Signed-off-by: Marek Beh??n <kabel@kernel.org>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
> +++ b/drivers/leds/leds-turris-omnia.c
> @@ -98,10 +98,13 @@ static int omnia_led_register(struct i2c_client *client, struct omnia_led *led,
> }
>
> led->subled_info[0].color_index = LED_COLOR_ID_RED;
> + led->subled_info[0].intensity = 255;
> led->subled_info[0].channel = 0;
> led->subled_info[1].color_index = LED_COLOR_ID_GREEN;
> + led->subled_info[1].intensity = 255;
> led->subled_info[1].channel = 1;
> led->subled_info[2].color_index = LED_COLOR_ID_BLUE;
> + led->subled_info[2].intensity = 255;
> led->subled_info[2].channel = 2;
>
> led->mc_cdev.subled_info = led->subled_info;
> --
> 2.41.0
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2023-07-16 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 8:52 [PATCH v2 0/3] leds: turris-omnia: updates Marek Behún
2023-07-14 8:52 ` [PATCH v2 1/3] leds: turris-omnia: change max brightness from 255 to 1 Marek Behún
2023-07-16 9:19 ` Pavel Machek
2023-07-16 15:01 ` Marek Behún
2023-07-28 9:56 ` Lee Jones
2023-07-28 10:10 ` Pavel Machek
2023-08-01 9:07 ` Marek Behún
2023-07-14 8:52 ` [PATCH v2 2/3] leds: turris-omnia: initialize multi-intensity to full Marek Behún
2023-07-16 9:19 ` Pavel Machek [this message]
2023-07-14 8:52 ` [PATCH v2 3/3] leds: turris-omnia: support HW controlled mode via private trigger Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230716091940.GB1182@bug \
--to=pavel@ucw.cz \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.