From: Stephen Hemminger <stephen@networkplumber.org>
To: Markus Theil <markus.theil@tu-ilmenau.de>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH] doc: add deprecation notice for inconsistent socket_id types
Date: Sun, 16 Jul 2023 10:34:44 -0700 [thread overview]
Message-ID: <20230716103444.73b1d796@hermes.local> (raw)
In-Reply-To: <20221014080944.10992-1-markus.theil@tu-ilmenau.de>
On Fri, 14 Oct 2022 10:09:44 +0200
Markus Theil <markus.theil@tu-ilmenau.de> wrote:
> DPDK uses many different types for socket_id's in its whole code
> base. This leads to many warnings and casts in DPDK-based applications
> compiled with -Wconversion.
>
> Announce a treewide consolidation to the return type of rte_socket_id
> in DPDK 23.11.
>
> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
Yes, this is a problem. But it is a bug not something that needs a deprecation
notice. The DPDK has avoided using typedefs for port, queue, lcore, and socket.
With socket_id there is the need to represent SOCKET_ID_ANY which is -1.
Please file a bugzilla entry instead.
Looking at code, there a few places doing using uint8_t which will work since
no cpu at present supports that many numa nodes. Should probably be a compile
assert for that though.
prev parent reply other threads:[~2023-07-16 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 8:09 [PATCH] doc: add deprecation notice for inconsistent socket_id types Markus Theil
2022-10-14 10:43 ` Jerin Jacob
2023-07-16 17:34 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230716103444.73b1d796@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=markus.theil@tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.