From: Stephen Hemminger <stephen@networkplumber.org>
To: Lichao Liu <liulichao.09679@bytedance.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] bus/pci: 'RTE_PMD_REGISTER_PCI' support expand 'nm'
Date: Sun, 16 Jul 2023 11:17:25 -0700 [thread overview]
Message-ID: <20230716111725.540b2ed0@hermes.local> (raw)
In-Reply-To: <20220802084839.30118-1-liulichao.09679@bytedance.com>
On Tue, 2 Aug 2022 16:48:39 +0800
Lichao Liu <liulichao.09679@bytedance.com> wrote:
> Before, 'RTE_PMD_REGISTER_PCI' can not expand nm. So, it can not
> work in this situation:
> #define TEST(a, b) a##_##b
> RTE_PMD_REGISTER_PCI(TEST(a, b), test_pmd_driver)
>
> Signed-off-by: Lichao Liu <liulichao.09679@bytedance.com>
It is not clear what the problem is.
All the existing drivers work fine.
Did you follow the coding conventions and patterns of existing drivers
or try and do something different.
Recommend not accepting this patch.
If you have a more verbose example of why this won't work for you
please resubmit the patch.
prev parent reply other threads:[~2023-07-16 18:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 8:48 [PATCH] bus/pci: 'RTE_PMD_REGISTER_PCI' support expand 'nm' Lichao Liu
2023-07-16 18:17 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230716111725.540b2ed0@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=liulichao.09679@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.