From: Greg KH <gregkh@linuxfoundation.org>
To: wuyonggang001@208suo.com
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: hiddev: Modify Format
Date: Sun, 16 Jul 2023 07:39:08 +0200 [thread overview]
Message-ID: <2023071623-shrouded-slacker-97a8@gregkh> (raw)
In-Reply-To: <755134062a3e4f74ef781cb8593b0f1e@208suo.com>
On Sun, Jul 16, 2023 at 12:11:11PM +0800, wuyonggang001@208suo.com wrote:
> Fix the following checkpatch error(s):
>
> ERROR: "inode * inode" should be "inode *inode"
> ERROR: "file * file" should be "file *file"
>
> Signed-off-by: Libing Zhang <zhanglibing@cdjrlc.com>
> ---
> drivers/hid/usbhid/hiddev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
> index 59cf3ddfdf78..581dc33197d0 100644
> --- a/drivers/hid/usbhid/hiddev.c
> +++ b/drivers/hid/usbhid/hiddev.c
> @@ -213,7 +213,7 @@ static int hiddev_fasync(int fd, struct file *file, int
> on)
> /*
> * release file op
> */
> -static int hiddev_release(struct inode * inode, struct file * file)
> +static int hiddev_release(struct inode *inode, struct file *file)
> {
> struct hiddev_list *list = file->private_data;
> unsigned long flags;
This patch is corrupted and can not be applied.
Please try working on drivers/staging/* files instead first, to give you
a chance to figure out how to do kernel development, before attempting
checkpatch changes on subsystems that might not want them.
good luck!
greg k-h
prev parent reply other threads:[~2023-07-16 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230716040716.25980-1-zhanglibing@cdjrlc.com>
2023-07-16 4:11 ` [PATCH] HID: hiddev: Modify Format wuyonggang001
2023-07-16 5:39 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023071623-shrouded-slacker-97a8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wuyonggang001@208suo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.