From: Leon Romanovsky <leon@kernel.org>
To: Ganesh G R <ganeshgr@linux.ibm.com>, Moshe Shemesh <moshe@nvidia.com>
Cc: saeedm@nvidia.com, netdev@vger.kernel.org, oohall@gmail.com,
Mahesh Salgaonkar <mahesh@linux.ibm.com>
Subject: Re: EEH recovery failing on mlx5 card
Date: Mon, 17 Jul 2023 16:10:06 +0300 [thread overview]
Message-ID: <20230717131006.GA346905@unreal> (raw)
In-Reply-To: <c13fa245-64ed-f87c-fd1e-e618fe017359@linux.ibm.com>
+ Moshe
On Mon, Jul 17, 2023 at 12:48:37PM +0530, Ganesh G R wrote:
> Hi,
>
> mlx5 cards are failing to recover from PCI errors, Upon investigation we found that the
> driver is trying to do MMIO in the middle of EEH error handling.
> The following fix in mlx5_pci_err_detected() is fixing the issue, Do you think its the right fix?
>
> @@ -1847,6 +1847,7 @@ static pci_ers_result_t mlx5_pci_err_detected(struct pci_dev *pdev,
> mlx5_unload_one(dev, true);
> mlx5_drain_health_wq(dev);
> mlx5_pci_disable_device(dev);
> + cancel_delayed_work_sync(&clock->timer.overflow_work);
> res = state == pci_channel_io_perm_failure ?
> PCI_ERS_RESULT_DISCONNECT : PCI_ERS_RESULT_NEED_RESET;
>
> Regards
> Ganesh
next parent reply other threads:[~2023-07-17 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c13fa245-64ed-f87c-fd1e-e618fe017359@linux.ibm.com>
2023-07-17 13:10 ` Leon Romanovsky [this message]
2023-07-17 16:18 ` EEH recovery failing on mlx5 card Moshe Shemesh
[not found] ` <b7ad516f-da16-2ba0-98e3-4f16f47e0fc8@linux.ibm.com>
2023-07-19 7:46 ` Moshe Shemesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717131006.GA346905@unreal \
--to=leon@kernel.org \
--cc=ganeshgr@linux.ibm.com \
--cc=mahesh@linux.ibm.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=oohall@gmail.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.