All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove duplicate free_async_extent_pages() on reservation error
Date: Mon, 17 Jul 2023 10:08:03 -0400	[thread overview]
Message-ID: <20230717140803.GA691303@perftesting> (raw)
In-Reply-To: <p6swvbl7oht2xiz7nrw3iexpa5ytuqdhbwneqm3phcm5igejd3@ao2eyoslwbdj>

On Fri, Jul 14, 2023 at 10:18:19AM -0500, Goldwyn Rodrigues wrote:
> While performing compressed writes, if the extent reservation fails, the
> async extent pages are first free'd in the error check for return value
> ret, and then again at "goto out_free".
> 
> Remove the first call to free_async_extent_pages().
> 
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
> 

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

      reply	other threads:[~2023-07-17 14:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14 15:18 [PATCH] btrfs: remove duplicate free_async_extent_pages() on reservation error Goldwyn Rodrigues
2023-07-17 14:08 ` Josef Bacik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230717140803.GA691303@perftesting \
    --to=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=rgoldwyn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.