From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-can@vger.kernel.org, kernel@pengutronix.de,
Jimmy Assarsson <extja@kvaser.com>,
Martin Jocic <majoc@kvaser.com>
Subject: Re: [PATCH net-next 7/8] can: kvaser_pciefd: Move hardware specific constants and functions into a driver_data struct
Date: Tue, 18 Jul 2023 18:33:15 -0700 [thread overview]
Message-ID: <20230718183315.27c0cd27@kernel.org> (raw)
In-Reply-To: <20230717182229.250565-8-mkl@pengutronix.de>
On Mon, 17 Jul 2023 20:22:28 +0200 Marc Kleine-Budde wrote:
> +const struct kvaser_pciefd_address_offset kvaser_pciefd_altera_address_offset = {
> +const struct kvaser_pciefd_irq_mask kvaser_pciefd_altera_irq_mask = {
> +const struct kvaser_pciefd_dev_ops kvaser_pciefd_altera_dev_ops = {
> +const struct kvaser_pciefd_driver_data kvaser_pciefd_altera_driver_data = {
sparse points out the structs in this and subsequent patch should
be static. Would you be able to queue a quick fix on top and resend,
or should we pull as is?
next prev parent reply other threads:[~2023-07-19 1:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 18:22 [PATCH net-next 0/8] pull-request: can-next 2023-07-17 Marc Kleine-Budde
2023-07-17 18:22 ` [PATCH net-next 1/8] dt-bindings: net: can: Remove interrupt properties for MCAN Marc Kleine-Budde
2023-07-19 2:10 ` patchwork-bot+netdevbpf
2023-07-17 18:22 ` [PATCH net-next 2/8] can: m_can: Add hrtimer to generate software interrupt Marc Kleine-Budde
2023-07-17 18:22 ` [PATCH net-next 3/8] can: ems_pci: Remove unnecessary (void *) conversions Marc Kleine-Budde
2023-07-17 18:22 ` [PATCH net-next 4/8] can: Explicitly include correct DT includes Marc Kleine-Budde
2023-07-17 18:22 ` [PATCH net-next 5/8] dt-bindings: can: xilinx_can: Add reset description Marc Kleine-Budde
2023-07-17 18:22 ` [PATCH net-next 6/8] can: xilinx_can: Add support for controller reset Marc Kleine-Budde
2023-07-17 18:22 ` [PATCH net-next 7/8] can: kvaser_pciefd: Move hardware specific constants and functions into a driver_data struct Marc Kleine-Budde
2023-07-19 1:33 ` Jakub Kicinski [this message]
2023-07-19 6:53 ` Marc Kleine-Budde
2023-07-19 7:25 ` Marc Kleine-Budde
2023-07-17 18:22 ` [PATCH net-next 8/8] can: kvaser_pciefd: Add support for new Kvaser pciefd devices Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718183315.27c0cd27@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=extja@kvaser.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=majoc@kvaser.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.