From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BBC9EB64DC for ; Tue, 18 Jul 2023 19:24:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id F390B6100C; Tue, 18 Jul 2023 19:24:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org F390B6100C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1689708298; bh=GS7azS2Q9TFF/xxPfBLedwDz6dtOEKfB6xtp6/3aIgY=; h=Date:From:To:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:Cc:From; b=HzOAq927klouV+X3ttc3oA+IA1zkqogQcz7EfihSWsNUuAMU4i6yig0qpl3AdiiCK MHbln3y+oJSZhDiJjK0cvahJTfvbrvaYt3Y81GKFUbJMbUPupT/ItdBuLLs3spIS3T 87nX9QPhH3Lb5Q5US2GxYCtICbiCmllkOohSs9vwwKOrh48641n6h8UBe939+0o0jY hi10M5UihkD/8cJo2e55Zz7eFNkoa9VdtycWScHXILnX8s0If3ljxZ0z33RzGBSo3f G9KILv7RnQJ00fo6lxoWdTuZ2IKwMkb1Yb6FDxBb5ztTo9geIFk5pKL8OY29Gp3/yt VZc0VVoeQxKbA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9mfttHmlQNoM; Tue, 18 Jul 2023 19:24:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id E406A61006; Tue, 18 Jul 2023 19:24:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E406A61006 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id DA9C91BF349 for ; Tue, 18 Jul 2023 19:24:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B2C8E4054B for ; Tue, 18 Jul 2023 19:24:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B2C8E4054B X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q0cyK0_gHuwM for ; Tue, 18 Jul 2023 19:24:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 693F64032A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id 693F64032A for ; Tue, 18 Jul 2023 19:24:54 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 93BC6616BA; Tue, 18 Jul 2023 19:24:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9E60C433C7; Tue, 18 Jul 2023 19:24:52 +0000 (UTC) Date: Tue, 18 Jul 2023 14:24:50 -0500 From: Bjorn Helgaas To: "Limonciello, Mario" Message-ID: <20230718192450.GA489825@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689708293; bh=qdAhpK1XWeLAN71lc0Y9kyyM+NLhNWrfXG4CFOZK0OA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=n6TT8nZLi9Pu6qYPkbR79iGdZf/xTelKI4ID1ZvYs+ryvcky461erRgFpveupe0bW vQlmqTc2yT6Wv5QvPjbNK6zf6FKtcfgdb1cnVzLFFqhaakQe/2YIlYuhSlmDktNMU5 D9jLWi+YFgLffoeWTZiOlduz+2+zJIz9TR6A8GLxl6CIqv1GdV9Wf0pwGhYDNMpckK 6ffhu3AN24Jo1+5iUtdo2a81G01f6QOx/E8hdQhHwIeBWoTOXNZFPheEvoeDedkEgT i8eLcdxr2B//lGlpmdc9D++BTG1+NbR7HM0530JhdzFOabGgVfNfZTIRiphDD1VOOR V/79lOQ+fkd2g== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=n6TT8nZL Subject: Re: [Intel-wired-lan] [PATCH] PCI/ASPM: Enable ASPM on external PCIe devices X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Bottini , Kuppuswamy Sathyanarayanan , linux-pci@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Vidya Sagar , Kai-Heng Feng , intel-wired-lan@osuosl.org, bhelgaas@google.com, Mika Westerberg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" T24gTW9uLCBKdWwgMTcsIDIwMjMgYXQgMTE6NTE6MzJBTSAtMDUwMCwgTGltb25jaWVsbG8sIE1h cmlvIHdyb3RlOgo+IE9uIDcvMTYvMjAyMyAxMDozNCBQTSwgS2FpLUhlbmcgRmVuZyB3cm90ZToK PiA+IE9uIFNhdCwgSnVsIDE1LCAyMDIzIGF0IDEyOjM34oCvQU0gTWFyaW8gTGltb25jaWVsbG8g PG1hcmlvLmxpbW9uY2llbGxvQGFtZC5jb20+IHdyb3RlOgo+ID4gPiBPbiA3LzE0LzIzIDAzOjE3 LCBLYWktSGVuZyBGZW5nIHdyb3RlOgoKPiA+ID4gPiBUaGUgbWFpbiBwb2ludCBpcyBPUyBzaG91 bGQgc3RpY2sgdG8gdGhlIEJJT1MgZGVmYXVsdCwgd2hpY2ggaXMgdGhlCj4gPiA+ID4gb25seSBB U1BNIHNldHRpbmcgdGVzdGVkIGJlZm9yZSBwdXR0aW5nIGhhcmR3YXJlIHRvIHRoZSBtYXJrZXQu Cj4gPiA+IAo+ID4gPiBVbmZvcnR1bmF0ZWx5OyBJIGRvbid0IHRoaW5rIHlvdSBjYW4ganVtcCB0 byB0aGlzIGNvbmNsdXNpb24uCgpJIHRoaW5rIHVzaW5nIHRoZSBCSU9TIGRlZmF1bHQgYXMgYSBs aW1pdCBpcyBwcm9ibGVtYXRpYy4gIEkgdGhpbmsgaXQKd291bGQgYmUgcGVyZmVjdGx5IHJlYXNv bmFibGUgZm9yIGEgQklPUyB0byAoYSkgY29uZmlndXJlIG9ubHkgZGV2aWNlcwppdCBuZWVkcyBm b3IgY29uc29sZSBhbmQgYm9vdCwgbGVhdmluZyBvdGhlcnMgYXQgcG93ZXItb24gZGVmYXVsdHMs CmFuZCAoYikgY29uZmlndXJlIGRldmljZXMgaW4gdGhlIHNhZmVzdCBjb25maWd1cmF0aW9uIHBv c3NpYmxlIG9uIHRoZQphc3N1bXB0aW9uIHRoYXQgYW4gT1MgY2FuIGRlY2lkZSB0aGUgcnVudGlt ZSBwb2xpY3kgaXRzZWxmLgoKT2J2aW91c2x5IEknbSBub3QgYSBCSU9TIHdyaXRlciAodGhvdWdo IEkgc3VyZSB3aXNoIEkgY291bGQgdGFsayB0bwpzb21lISksIHNvIG1heWJlIHRoZXNlIGFyZSBi YWQgYXNzdW1wdGlvbnMuCgo+ID4gPiBBIGJpZyBkaWZmZXJlbmNlIGluIHRoZSBXaW5kb3dzIHdv cmxkIHRvIExpbnV4IHdvcmxkIGlzIHRoYXQgT0VNcyBzaGlwCj4gPiA+IHdpdGggYSBmYWN0b3J5 IFdpbmRvd3MgaW1hZ2UgdGhhdCBtYXkgc2V0IHBvbGljaWVzIGxpa2UgdGhpcy4gIE9FTQo+ID4g PiAicGxhdGZvcm0iIGRyaXZlcnMgY2FuIHNldCByZWdpc3RyeSBrZXlzIHRvby4KCkkgc3VwcG9z ZSB0aGlzIG1lYW5zIHRoYXQgdGhlIE9FTSBpbWFnZSBjb250YWlucyBkcml2ZXJzIHRoYXQgYXJl bid0CmluIHRoZSBNaWNyb3NvZnQgbWVkaWEsIGFuZCB0aG9zZSBkcml2ZXJzIG1heSBzZXQgY29u c3RyYWludHMgb24gQVNQTQp1c2FnZT8KCklmIHlvdSBib290IHRoZSBNaWNyb3NvZnQgbWVkaWEg dGhhdCBsYWNrcyB0aG9zZSBkcml2ZXJzLCBtYXliZSBpdApkb2Vzbid0IGJvdGhlciB0byBjb25m aWd1cmUgQVNQTSBmb3IgdGhvc2UgZGV2aWNlcz8gIExpbnV4IGN1cnJlbnRseQpjb25maWd1cmVz IEFTUE0gZm9yIGV2ZXJ5dGhpbmcgYXQgZW51bWVyYXRpb24tdGltZSwgc28gd2UgZG8gaXQgZXZl bgppZiB0aGVyZSdzIG5vIGRyaXZlci4KCj4gPiBJIHdvbmRlciBpZiB0aGVyZSdzIGFueSBwYXJ0 aWN1bGFyIG1vZGlmaWNhdGlvbiBzaG91bGQgYmUgaW1wcm92ZWQgZm9yCj4gPiB0aGlzIHBhdGNo Pwo+IAo+IEtub3dpbmcgdGhpcyBpbmZvcm1hdGlvbiBJIHBlcnNvbmFsbHkgdGhpbmsgdGhlIG9y aWdpbmFsIHBhdGNoIHRoYXQgc3RhcnRlZAo+IHRoaXMgdGhyZWFkIG1ha2VzIGEgbG90IG9mIHNl bnNlLgoKSSdtIHN0aWxsIG9wcG9zZWQgdG8gdXNpbmcgZGV2X2lzX3JlbW92YWJsZSgpIGFzIGEg cHJlZGljYXRlIGJlY2F1c2UgSQpkb24ndCB0aGluayBpdCBoYXMgYW55IHRlY2huaWNhbCBjb25u ZWN0aW9uIHRvIEFTUE0gY29uZmlndXJhdGlvbi4KCkJqb3JuCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLXdpcmVkLWxhbiBtYWlsaW5nIGxpc3QK SW50ZWwtd2lyZWQtbGFuQG9zdW9zbC5vcmcKaHR0cHM6Ly9saXN0cy5vc3Vvc2wub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtd2lyZWQtbGFuCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D53C1C0015E for ; Tue, 18 Jul 2023 19:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229449AbjGRTY7 (ORCPT ); Tue, 18 Jul 2023 15:24:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjGRTY5 (ORCPT ); Tue, 18 Jul 2023 15:24:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ADAF198D; Tue, 18 Jul 2023 12:24:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9FDB0616B9; Tue, 18 Jul 2023 19:24:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9E60C433C7; Tue, 18 Jul 2023 19:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689708293; bh=qdAhpK1XWeLAN71lc0Y9kyyM+NLhNWrfXG4CFOZK0OA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=n6TT8nZLi9Pu6qYPkbR79iGdZf/xTelKI4ID1ZvYs+ryvcky461erRgFpveupe0bW vQlmqTc2yT6Wv5QvPjbNK6zf6FKtcfgdb1cnVzLFFqhaakQe/2YIlYuhSlmDktNMU5 D9jLWi+YFgLffoeWTZiOlduz+2+zJIz9TR6A8GLxl6CIqv1GdV9Wf0pwGhYDNMpckK 6ffhu3AN24Jo1+5iUtdo2a81G01f6QOx/E8hdQhHwIeBWoTOXNZFPheEvoeDedkEgT i8eLcdxr2B//lGlpmdc9D++BTG1+NbR7HM0530JhdzFOabGgVfNfZTIRiphDD1VOOR V/79lOQ+fkd2g== Date: Tue, 18 Jul 2023 14:24:50 -0500 From: Bjorn Helgaas To: "Limonciello, Mario" Cc: Kai-Heng Feng , Kuppuswamy Sathyanarayanan , linux-pci@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Vidya Sagar , Michael Bottini , intel-wired-lan@osuosl.org, bhelgaas@google.com, Mika Westerberg Subject: Re: [Intel-wired-lan] [PATCH] PCI/ASPM: Enable ASPM on external PCIe devices Message-ID: <20230718192450.GA489825@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Jul 17, 2023 at 11:51:32AM -0500, Limonciello, Mario wrote: > On 7/16/2023 10:34 PM, Kai-Heng Feng wrote: > > On Sat, Jul 15, 2023 at 12:37 AM Mario Limonciello wrote: > > > On 7/14/23 03:17, Kai-Heng Feng wrote: > > > > The main point is OS should stick to the BIOS default, which is the > > > > only ASPM setting tested before putting hardware to the market. > > > > > > Unfortunately; I don't think you can jump to this conclusion. I think using the BIOS default as a limit is problematic. I think it would be perfectly reasonable for a BIOS to (a) configure only devices it needs for console and boot, leaving others at power-on defaults, and (b) configure devices in the safest configuration possible on the assumption that an OS can decide the runtime policy itself. Obviously I'm not a BIOS writer (though I sure wish I could talk to some!), so maybe these are bad assumptions. > > > A big difference in the Windows world to Linux world is that OEMs ship > > > with a factory Windows image that may set policies like this. OEM > > > "platform" drivers can set registry keys too. I suppose this means that the OEM image contains drivers that aren't in the Microsoft media, and those drivers may set constraints on ASPM usage? If you boot the Microsoft media that lacks those drivers, maybe it doesn't bother to configure ASPM for those devices? Linux currently configures ASPM for everything at enumeration-time, so we do it even if there's no driver. > > I wonder if there's any particular modification should be improved for > > this patch? > > Knowing this information I personally think the original patch that started > this thread makes a lot of sense. I'm still opposed to using dev_is_removable() as a predicate because I don't think it has any technical connection to ASPM configuration. Bjorn