From: Jakub Kicinski <kuba@kernel.org>
To: Carlos Bilbao <carlos.bilbao@amd.com>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
davem@davemloft.net, edumazet@google.com,
linux-kernel@vger.kernel.org, mchan@broadcom.com,
netdev@vger.kernel.org, pabeni@redhat.com, prashant@broadcom.com,
siva.kallam@broadcom.com
Subject: Re: [PATCH] tg3: fix array subscript out of bounds compilation error
Date: Tue, 18 Jul 2023 19:54:14 -0700 [thread overview]
Message-ID: <20230718195414.4c6f359f@kernel.org> (raw)
In-Reply-To: <c196f8f9-3d2c-27c6-6807-75a6e6e4d5a5@amd.com>
On Tue, 18 Jul 2023 10:52:39 -0500 Carlos Bilbao wrote:
> >> Fix encountered compilation error in tg3.c where an array subscript was
> >
> > What is the error ?
>
> drivers/net/ethernet/broadcom/tg3.c: In function ‘tg3_init_one’:
What compiler are you using? Any extra flags?
I remember seeing this warning too, but I can't repro it now (gcc 13.1;
clang 16).
> >> above the array bounds of 'struct tg3_napi[5]'. Add an additional check in
> >> the for loop to ensure that it does not exceed the bounds of
> >> 'struct tg3_napi' (defined by TG3_IRQ_MAX_VECS).
> >>
> >> Reviewed-By: Carlos Bilbao <carlos.bilbao@amd.com>
We need a sign-off tag
--
pw-bot: cr
next prev parent reply other threads:[~2023-07-19 2:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 14:34 [PATCH] tg3: fix array subscript out of bounds compilation error Carlos Bilbao
2023-07-17 19:24 ` Kuniyuki Iwashima
2023-07-18 15:52 ` Carlos Bilbao
2023-07-19 2:54 ` Jakub Kicinski [this message]
2023-07-19 4:30 ` Eric Dumazet
2023-07-21 22:29 ` Carlos Bilbao
2023-07-22 1:17 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718195414.4c6f359f@kernel.org \
--to=kuba@kernel.org \
--cc=carlos.bilbao@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prashant@broadcom.com \
--cc=siva.kallam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.