From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/kodi: add optional dependency to clang
Date: Tue, 18 Jul 2023 22:55:46 +0200 [thread overview]
Message-ID: <20230718225546.08847fea@windsurf> (raw)
In-Reply-To: <20230716075438.3026838-1-bernd@kuhls.net>
Hello Bernd,
On Sun, 16 Jul 2023 09:54:38 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> +ifeq ($(BR2_PACKAGE_CLANG),y)
> +KODI_CONF_OPTS += -DCLANG_FORMAT_EXECUTABLE=$(HOST_DIR)/bin/clang-format
> +KODI_DEPENDENCIES += clang
I am not a fan of this, because you are testing whether target clang is
enabled (BR2_PACKAGE_CLANG) and having a dependency on target clang,
while what you need is host-clang.
What does clang-format brings to Kodi feature-wise?
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-07-18 20:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-16 7:54 [Buildroot] [PATCH 1/1] package/kodi: add optional dependency to clang Bernd Kuhls
2023-07-18 20:55 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718225546.08847fea@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.