From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8846EB64DA for ; Tue, 18 Jul 2023 14:42:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233325AbjGROmf (ORCPT ); Tue, 18 Jul 2023 10:42:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230221AbjGROme (ORCPT ); Tue, 18 Jul 2023 10:42:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C328196 for ; Tue, 18 Jul 2023 07:42:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 20532615EB for ; Tue, 18 Jul 2023 14:42:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29BDAC433C8; Tue, 18 Jul 2023 14:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689691352; bh=Z+PNS2WiIunBi2FMQTKiXuD8V7GcP9wQJnKxd+rRtyo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fKWunR36JM///WD6ba7xCv7+Iq/EjjYeqk5eKsKwlFKspi4xf/nn3OGS85CJ9oHGn KvLdsYZUNmo6GCVbIq9YumrSHWAiVkGjeqIiNyDo1RIndj4ndELdYFSKQyryPno7lp tNnAfWy/DuWEv83EnYnyy9zjyX56fzPQ2ZiBlz00= Date: Tue, 18 Jul 2023 16:42:29 +0200 From: Greg Kroah-Hartman To: Daniel Golle Cc: Miquel Raynal , Srinivas Kandagatla , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] nvmem: core: clear sysfs attributes for each NVMEM device Message-ID: <2023071842-nervy-drilling-8d26@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2023 at 02:55:31PM +0100, Daniel Golle wrote: > Set nvmem_cells_group.bin_attrs to NULL in case of an NVMEM device not > having any cells in order to make sure sysfs attributes of a previously > registered NVMEM device are not accidentally reused for a follow-up > device which doesn't have any cells. > > Fixes: 757f8b3835c9 ("nvmem: core: Expose cells through sysfs") Where is this git commit id? I don't see it in Linus's tree. > Signed-off-by: Daniel Golle > --- > drivers/nvmem/core.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Your patches were not threaded/attached to each other either, so our tools can't take them together. Can you fix that up and use 'git send-email' or other such tools to have this show up properly when you send a v2? thanks, greg k-h