From: Jakub Kicinski <kuba@kernel.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
davem@davemloft.net, edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: delete "<< 1U" cargo-culting
Date: Wed, 19 Jul 2023 13:57:06 -0700 [thread overview]
Message-ID: <20230719135706.5a46a178@kernel.org> (raw)
In-Reply-To: <2ff150de-8997-47bc-a3dd-114c60a7c912@p183>
On Wed, 19 Jul 2023 14:29:05 +0300 Alexey Dobriyan wrote:
> > Indeed. Still this patch is quite invasive and the net benefit looks
> > quite marginal - if any at all.
>
> I have all tree converted, this is just net/ part.
>
> Net(!) benefit is more readable code.
Please don't argue with the maintainer about subjective stuff.
The noise in the history is not worth this noop patch.
Do compilers warn about this unnecessary type annotation?
If they did, and you were planning to enable such warning kernel-wide -
that'd be the only reason which could make the change worth considering.
prev parent reply other threads:[~2023-07-19 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 10:19 [PATCH] net: delete "<< 1U" cargo-culting Alexey Dobriyan
2023-07-18 10:47 ` Paolo Abeni
2023-07-19 11:29 ` Alexey Dobriyan
2023-07-19 20:57 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230719135706.5a46a178@kernel.org \
--to=kuba@kernel.org \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.