From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 448CBC0015E for ; Wed, 19 Jul 2023 15:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230074AbjGSPhw (ORCPT ); Wed, 19 Jul 2023 11:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230466AbjGSPht (ORCPT ); Wed, 19 Jul 2023 11:37:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B984BE; Wed, 19 Jul 2023 08:37:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1251761740; Wed, 19 Jul 2023 15:37:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E060C433C8; Wed, 19 Jul 2023 15:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689781065; bh=8vE1ot6XzFQ4H6sBrVB9YMCDiYUQPwwfTpKgGcHZcng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vQ6SfMBZY0QHME2fvrVuvDrOXOy58YBPTNc7A5lnuITNetabLNPEaeOM2paMu+SpH 5fMLvaTesCUu8r4E9urcNhjlR7E4aivQOfNQzRn1o1jn817gmOMeIa1MvStD1DfCzt fBFry24AMlETBkSftX5RdTBdnz8W/t8XEOKOYCPXLw0CeV8oZa6Ui1Tt9nV996Qvya kzyPIyx4lWfbOSz2EEqnGaTgNKe3K74mHGHwnrZubbMdJulY533/o/Zbzbz3kWDje2 cGmv3z9PZMUxUmLBOk+COJeg3K9jHOolKstg/tJLUNv/I7e0ofES8Q8fbd2oUDIzwL zYMgGTrtzPBBw== Date: Wed, 19 Jul 2023 21:07:27 +0530 From: Manivannan Sadhasivam To: Parikshit Pareek Cc: Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Marijn Suijten , Adam Skladowski , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, "linux-kernel @ vger . kernel . org Prasanna Kumar" , Shazad Hussain Subject: Re: [PATCH 0/3] arm64: dts: qcom: sa8775p: Add interconnect to SMMU Message-ID: <20230719153727.GD9312@thinkpad> References: <20230609054141.18938-1-quic_ppareek@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230609054141.18938-1-quic_ppareek@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jun 09, 2023 at 11:11:39AM +0530, Parikshit Pareek wrote: > Some qcom SoCs have SMMUs, which need the interconnect bandwidth to be > This series introduce the due support for associated interconnect, and > setting of the due interconnect-bandwidth. Setting due interconnect > bandwidth is needed to avoid the issues like [1], caused by not having > due clock votes(indirectly dependent upon interconnect bandwidth). > As discussed offline, once you enable the PCIe RC driver which votes for this interconnect path (pcie-mem) like other platforms [1], then you do not need this series. This interconnect path belongs to the PCIe RC controller. So it is the responsibility of the PCIe RC driver to vote for this path and that's what the driver is already doing. - Mani [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sc8280xp.dtsi#n1767 > Parikshit Pareek (3): > dt-bindings: arm-smmu: Add interconnect for qcom SMMUs > arm64: dts: qcom: sa8775p: Add interconnect to PCIe SMMU > iommu/arm-smmu-qcom: Add support for the interconnect > > .../devicetree/bindings/iommu/arm,smmu.yaml | 22 +++++++++++++++++++ > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 4 ++++ > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 16 ++++++++++++++ > 3 files changed, 42 insertions(+) > > -- > 2.17.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 093B1EB64DA for ; Wed, 19 Jul 2023 15:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fijZYJ7JjuIJ7kkr5D1+G9ZYmZ/fo5dKqc+ws/DtnrI=; b=fvCNWZK78E3gLU twMX4vZyYslEFF4iVY/y/DzgNxWrpKZb6+EiPV97Qssd0lD6Yt3N/wE32QjHjko2TID6jMrwPpVhI DqDpTXlj5mfE1vz/1MctHzkSmjIfC9xo36JxMS2avjE5ybMiDsQX3kPxyYK9HmvmdboeV2TO4o8m3 /o7xo1XPacDDTt/6xToJrCUMeOGfmoLReCC467eqFdcWLSzQY5dzCXFSigLaKZojEvDoxTJR5BFlT yPyx3QxsmIPrNyQyC7IlfiiTa1fBey+AAkEHcnWqtsiPy40feiYiBCd+uVNArzEmFulzhZ2V6alSs DUZyc08R/zWB3fUyaMZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM9FN-007xgR-0B; Wed, 19 Jul 2023 15:37:49 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qM9FK-007xfa-2G for linux-arm-kernel@lists.infradead.org; Wed, 19 Jul 2023 15:37:48 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 28D2361752; Wed, 19 Jul 2023 15:37:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E060C433C8; Wed, 19 Jul 2023 15:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689781065; bh=8vE1ot6XzFQ4H6sBrVB9YMCDiYUQPwwfTpKgGcHZcng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vQ6SfMBZY0QHME2fvrVuvDrOXOy58YBPTNc7A5lnuITNetabLNPEaeOM2paMu+SpH 5fMLvaTesCUu8r4E9urcNhjlR7E4aivQOfNQzRn1o1jn817gmOMeIa1MvStD1DfCzt fBFry24AMlETBkSftX5RdTBdnz8W/t8XEOKOYCPXLw0CeV8oZa6Ui1Tt9nV996Qvya kzyPIyx4lWfbOSz2EEqnGaTgNKe3K74mHGHwnrZubbMdJulY533/o/Zbzbz3kWDje2 cGmv3z9PZMUxUmLBOk+COJeg3K9jHOolKstg/tJLUNv/I7e0ofES8Q8fbd2oUDIzwL zYMgGTrtzPBBw== Date: Wed, 19 Jul 2023 21:07:27 +0530 From: Manivannan Sadhasivam To: Parikshit Pareek Cc: Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Marijn Suijten , Adam Skladowski , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, "linux-kernel @ vger . kernel . org Prasanna Kumar" , Shazad Hussain Subject: Re: [PATCH 0/3] arm64: dts: qcom: sa8775p: Add interconnect to SMMU Message-ID: <20230719153727.GD9312@thinkpad> References: <20230609054141.18938-1-quic_ppareek@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230609054141.18938-1-quic_ppareek@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230719_083746_800032_97C4825A X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdW4gMDksIDIwMjMgYXQgMTE6MTE6MzlBTSArMDUzMCwgUGFyaWtzaGl0IFBhcmVl ayB3cm90ZToKPiBTb21lIHFjb20gU29DcyBoYXZlIFNNTVVzLCB3aGljaCBuZWVkIHRoZSBpbnRl cmNvbm5lY3QgYmFuZHdpZHRoIHRvIGJlCj4gVGhpcyBzZXJpZXMgaW50cm9kdWNlIHRoZSBkdWUg c3VwcG9ydCBmb3IgYXNzb2NpYXRlZCBpbnRlcmNvbm5lY3QsIGFuZAo+IHNldHRpbmcgb2YgdGhl IGR1ZSBpbnRlcmNvbm5lY3QtYmFuZHdpZHRoLiBTZXR0aW5nIGR1ZSBpbnRlcmNvbm5lY3QKPiBi YW5kd2lkdGggaXMgbmVlZGVkIHRvIGF2b2lkIHRoZSBpc3N1ZXMgbGlrZSBbMV0sIGNhdXNlZCBi eSBub3QgaGF2aW5nCj4gZHVlIGNsb2NrIHZvdGVzKGluZGlyZWN0bHkgZGVwZW5kZW50IHVwb24g aW50ZXJjb25uZWN0IGJhbmR3aWR0aCkuCj4gCgpBcyBkaXNjdXNzZWQgb2ZmbGluZSwgb25jZSB5 b3UgZW5hYmxlIHRoZSBQQ0llIFJDIGRyaXZlciB3aGljaCB2b3RlcyBmb3IgdGhpcwppbnRlcmNv bm5lY3QgcGF0aCAocGNpZS1tZW0pIGxpa2Ugb3RoZXIgcGxhdGZvcm1zIFsxXSwgdGhlbiB5b3Ug ZG8gbm90IG5lZWQgdGhpcwpzZXJpZXMuIFRoaXMgaW50ZXJjb25uZWN0IHBhdGggYmVsb25ncyB0 byB0aGUgUENJZSBSQyBjb250cm9sbGVyLiBTbyBpdCBpcyB0aGUKcmVzcG9uc2liaWxpdHkgb2Yg dGhlIFBDSWUgUkMgZHJpdmVyIHRvIHZvdGUgZm9yIHRoaXMgcGF0aCBhbmQgdGhhdCdzIHdoYXQg dGhlCmRyaXZlciBpcyBhbHJlYWR5IGRvaW5nLgoKLSBNYW5pCgpbMV0gaHR0cHM6Ly9naXQua2Vy bmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0L3RyZWUv YXJjaC9hcm02NC9ib290L2R0cy9xY29tL3NjODI4MHhwLmR0c2kjbjE3NjcKCj4gUGFyaWtzaGl0 IFBhcmVlayAoMyk6Cj4gICBkdC1iaW5kaW5nczogYXJtLXNtbXU6IEFkZCBpbnRlcmNvbm5lY3Qg Zm9yIHFjb20gU01NVXMKPiAgIGFybTY0OiBkdHM6IHFjb206IHNhODc3NXA6IEFkZCBpbnRlcmNv bm5lY3QgdG8gUENJZSBTTU1VCj4gICBpb21tdS9hcm0tc21tdS1xY29tOiBBZGQgc3VwcG9ydCBm b3IgdGhlIGludGVyY29ubmVjdAo+IAo+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9pb21tdS9h cm0sc21tdS55YW1sICAgfCAyMiArKysrKysrKysrKysrKysrKysrCj4gIGFyY2gvYXJtNjQvYm9v dC9kdHMvcWNvbS9zYTg3NzVwLmR0c2kgICAgICAgICB8ICA0ICsrKysKPiAgZHJpdmVycy9pb21t dS9hcm0vYXJtLXNtbXUvYXJtLXNtbXUtcWNvbS5jICAgIHwgMTYgKysrKysrKysrKysrKysKPiAg MyBmaWxlcyBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspCj4gCj4gLS0gCj4gMi4xNy4xCj4gCgot LSAK4K6u4K6j4K6/4K614K6j4K+N4K6j4K6p4K+NIOCumuCupOCuvuCumuCuv+CuteCuruCvjQoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=