From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E951C001DC for ; Wed, 19 Jul 2023 19:46:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230027AbjGSTqG (ORCPT ); Wed, 19 Jul 2023 15:46:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229707AbjGSTqE (ORCPT ); Wed, 19 Jul 2023 15:46:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9538B1FCE for ; Wed, 19 Jul 2023 12:46:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 34159617F2 for ; Wed, 19 Jul 2023 19:46:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87972C433C7; Wed, 19 Jul 2023 19:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1689795962; bh=0Cg+Et1GwVIDnpc+Oftpzg585LlDU1gvBiabKRPkhQk=; h=Date:To:From:Subject:From; b=z+daw2wNQuV5lvOWjkc1O6K/MnMyoVENpXFvPMT+qQU3Zq141PyQ+eVUQtopitko3 vhPfeU5LUJbGyFkUkh122pfBWHtpkgrEUvZhMJp7WVML3f9FrziuEtvp8hTVTzNsb9 HRv4KvWmWE+twwnJlzrlcDlnC8IJwRiWKW039kts= Date: Wed, 19 Jul 2023 12:46:01 -0700 To: mm-commits@vger.kernel.org, zhi.wang.linux@gmail.com, will@kernel.org, seanjc@google.com, robin.murphy@arm.com, npiggin@gmail.com, nicolinc@nvidia.com, mpe@ellerman.id.au, kevin.tian@intel.com, jhubbard@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com, fbarrat@linux.ibm.com, catalin.marinas@arm.com, ajd@linux.ibm.com, apopple@nvidia.com, akpm@linux-foundation.org From: Andrew Morton Subject: + mmu_notifiers-fixup-comment-in-mmu_interval_read_begin.patch added to mm-unstable branch Message-Id: <20230719194602.87972C433C7@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: mmu_notifiers: fixup comment in mmu_interval_read_begin() has been added to the -mm mm-unstable branch. Its filename is mmu_notifiers-fixup-comment-in-mmu_interval_read_begin.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mmu_notifiers-fixup-comment-in-mmu_interval_read_begin.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Alistair Popple Subject: mmu_notifiers: fixup comment in mmu_interval_read_begin() Date: Wed, 19 Jul 2023 22:18:43 +1000 The comment in mmu_interval_read_begin() refers to a function that doesn't exist and uses the wrong call-back name. The op for mmu interval notifiers is mmu_interval_notifier_ops->invalidate() so fix the comment up to reflect that. Link: https://lkml.kernel.org/r/06fa82756e4d6458895962a7743cc7f162658a54.1689768831.git-series.apopple@nvidia.com Signed-off-by: Alistair Popple Cc: Andrew Donnellan Cc: Catalin Marinas Cc: Frederic Barrat Cc: Jason Gunthorpe Cc: Jason Gunthorpe Cc: John Hubbard Cc: Kevin Tian Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Nicolin Chen Cc: Robin Murphy Cc: Sean Christopherson Cc: Will Deacon Cc: Zhi Wang Signed-off-by: Andrew Morton --- mm/mmu_notifier.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/mm/mmu_notifier.c~mmu_notifiers-fixup-comment-in-mmu_interval_read_begin +++ a/mm/mmu_notifier.c @@ -199,7 +199,7 @@ mmu_interval_read_begin(struct mmu_inter * invalidate_start/end and is colliding. * * The locking looks broadly like this: - * mn_tree_invalidate_start(): mmu_interval_read_begin(): + * mn_itree_inv_start(): mmu_interval_read_begin(): * spin_lock * seq = READ_ONCE(interval_sub->invalidate_seq); * seq == subs->invalidate_seq @@ -207,7 +207,7 @@ mmu_interval_read_begin(struct mmu_inter * spin_lock * seq = ++subscriptions->invalidate_seq * spin_unlock - * op->invalidate_range(): + * op->invalidate(): * user_lock * mmu_interval_set_seq() * interval_sub->invalidate_seq = seq _ Patches currently in -mm which might be from apopple@nvidia.com are arm64-smmu-use-tlbi-asid-when-invalidating-entire-range.patch mmu_notifiers-fixup-comment-in-mmu_interval_read_begin.patch mmu_notifiers-call-invalidate_range-when-invalidating-tlbs.patch mmu_notifiers-dont-invalidate-secondary-tlbs-as-part-of-mmu_notifier_invalidate_range_end.patch mmu_notifiers-rename-invalidate_range-notifier.patch