From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 404B1C001B0 for ; Wed, 19 Jul 2023 19:54:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0A68C86791; Wed, 19 Jul 2023 21:54:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="YB+HDOZg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9D2F48675B; Wed, 19 Jul 2023 21:54:05 +0200 (CEST) Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E52CA86784 for ; Wed, 19 Jul 2023 21:54:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb2b.google.com with SMTP id 3f1490d57ef6-cae693192d1so22083276.1 for ; Wed, 19 Jul 2023 12:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1689796439; x=1692388439; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IIfxZNhT1kUU78LUKayftL7qiUiz2k0nduhglhcpMjQ=; b=YB+HDOZgzRwfgSwN19oHe/tC4Jk3N/Tre+0DpRb+Wg7KtDA4oIlSIucRwfmhIl6Ozf cVKN/s3Z+QQdzUqOeCtRPw38y2Ms1tSTSwpr9vKp7RBZBYGNH34Mp4t4O2JtvtvaMrm9 95sgZkYYDAsIRb3Zcd8DClm4AsjYl8u+BEHhQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689796439; x=1692388439; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IIfxZNhT1kUU78LUKayftL7qiUiz2k0nduhglhcpMjQ=; b=f9dccEUwsLGTn6ibEQxum+3BDTGQKs5Yd270OphmaFbEkPaYVgsoROLmIS4Zow17bU l53S9NRT52TKUNrUErUpKlos3VJATEgSM5EhidicVXpOqbzo9OCpXoAzwNq4SVNEZBs3 JLWaDrlppVXTbVrXBvqVON7SNkn9FYp7Z+ymPGIMfmH9+A5I0RWRw/U7kAxjpoY02fGu WX9uQCKiWYtklt3/XcunSf7n4Zydl4V8GOCxdOz+36ahAkZ4sV+qg0fBkECuMafztc88 dSXaSTo392Bhz0i+r1orNBeb0I+IOm5J6E3uq7Lp4W7hBlEejUaz0f8kE1n8eYmBwnmO yiCA== X-Gm-Message-State: ABy/qLZUnXWxyMmVd6do1pYWRJ5gb8T5piWRxaqjIoJ15UUlRDCMzwaD 0hOklUqs5IzueiH11jaUzw0X2A== X-Google-Smtp-Source: APBJJlF31NpCHhNkDpqtYQCt0+DDNwudUq918mbZ2II5V4ikjJ/IGhLIPw4zKjvJk1G/aOQHDNp6hg== X-Received: by 2002:a81:6d0d:0:b0:577:f47:3d8d with SMTP id i13-20020a816d0d000000b005770f473d8dmr19200381ywc.25.1689796439470; Wed, 19 Jul 2023 12:53:59 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-db2e-065f-d044-b9a4.res6.spectrum.com. [2603:6081:7b00:6400:db2e:65f:d044:b9a4]) by smtp.gmail.com with ESMTPSA id a84-20020a0dd857000000b0057a560a9832sm1206744ywe.1.2023.07.19.12.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 12:53:58 -0700 (PDT) Date: Wed, 19 Jul 2023 15:53:57 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Kevin Hilman , Lukasz Majewski , Simon Glass Subject: Re: [PATCH v2 1/4] cmd: bind: Add unbind command with driver filter Message-ID: <20230719195357.GA2729632@bill-the-cat> References: <20230717112137.9139-1-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CKaD4p9zcJQp/toe" Content-Disposition: inline In-Reply-To: <20230717112137.9139-1-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --CKaD4p9zcJQp/toe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 17, 2023 at 01:21:34PM +0200, Marek Vasut wrote: > Extend the driver core to perform lookup by both OF node and driver > bound to the node. Use this to look up specific device instances to > unbind from nodes in the unbind command. One example where this is > needed is USB peripheral controller, which may have multiple gadget > drivers bound to it. The unbind command has to select that specific > gadget driver instance to unbind from the controller, not unbind the > controller driver itself from the controller. >=20 > USB ethernet gadget usage looks as follows with this change. Notice > the extra 'usb_ether' addition in the 'unbind' command at the end. > " > bind /soc/usb-otg@49000000 usb_ether > setenv ethact usb_ether > setenv loadaddr 0xc2000000 > setenv ipaddr 10.0.0.2 > setenv serverip 10.0.0.1 > setenv netmask 255.255.255.0 > tftpboot 0xc2000000 10.0.0.1:test.file > unbind /soc/usb-otg@49000000 usb_ether > " >=20 > Signed-off-by: Marek Vasut > --- > Cc: Kevin Hilman > Cc: Lukasz Majewski > Cc: Marek Vasut > Cc: Simon Glass > --- > V2: No change > --- > cmd/bind.c | 10 +++++----- > drivers/core/device.c | 20 +++++++++++++++----- > include/dm/device.h | 17 +++++++++++++++++ > 3 files changed, 37 insertions(+), 10 deletions(-) Conceptually this seems fine to me. Simon? --=20 Tom --CKaD4p9zcJQp/toe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmS4P04ACgkQFHw5/5Y0 tywypAwApZ9yDwKPT8ol1OgGkY3WGvKMYGphPWQuhcvDEEutvbvGbyfj8I92cR3g u5+RxZw8uWUt0XY1+PApvc51lMO1SuxRqwZfOlxFXwr3YeONaQC7tAiVtxvZ4xZA 3tHoFCV6TGAxzCM3A14VVw9NHxr2PE0vrUlY/TXoQfv/rBT7uKO+c9Z48/eKElsn Ucxzl8eb7a1FaOjj5Z1sBMafbjIhjZFcSTqF8/FNoJ8QzhrpPpFCLhPdKQZdLSV2 sw5oDR0kyZuuzZPRoEXtQ8JkAMNu+ofhzwlOEKrj0O/1WkPYZmKcAP12WdSftv7X xSeWcwWAI1APgOZaej4+zMsNu8vVneBk4OitF4Dp4orcSEwDBc+2qOB56gz1iMn9 XT3tOaczm7o8Ujvd0XLV5AnRAzznSox9AF1dySfyiRkmmezUwNobC9aegX9ikkSq rhSwooGi+DxosuY7n+JN+gGqbI4zUSvS/mPfxYN0fLCMwiAaDRz/SmAF5P3x9A8B d5YuUKNC =1q7U -----END PGP SIGNATURE----- --CKaD4p9zcJQp/toe--