From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
Jakub Kicinski <kuba@kernel.org>,
gerhard@engleder-embedded.com
Subject: [PATCH net-next 1/4] eth: tsnep: let page recycling happen with skbs
Date: Wed, 19 Jul 2023 18:04:06 -0700 [thread overview]
Message-ID: <20230720010409.1967072-2-kuba@kernel.org> (raw)
In-Reply-To: <20230720010409.1967072-1-kuba@kernel.org>
tsnep builds an skb with napi_build_skb() and then calls
page_pool_release_page() for the page in which that skb's
head sits. Use recycling instead, recycling of heads works
just fine.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: gerhard@engleder-embedded.com
---
drivers/net/ethernet/engleder/tsnep_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c
index 84751bb303a6..079f9f6ae21a 100644
--- a/drivers/net/ethernet/engleder/tsnep_main.c
+++ b/drivers/net/ethernet/engleder/tsnep_main.c
@@ -1333,7 +1333,7 @@ static void tsnep_rx_page(struct tsnep_rx *rx, struct napi_struct *napi,
skb = tsnep_build_skb(rx, page, length);
if (skb) {
- page_pool_release_page(rx->page_pool, page);
+ skb_mark_for_recycle(skb);
rx->packets++;
rx->bytes += length;
--
2.41.0
next prev parent reply other threads:[~2023-07-20 1:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 1:04 [PATCH net-next 0/4] net: page_pool: remove page_pool_release_page() Jakub Kicinski
2023-07-20 1:04 ` Jakub Kicinski [this message]
2023-07-20 11:55 ` [PATCH net-next 1/4] eth: tsnep: let page recycling happen with skbs Yunsheng Lin
2023-07-20 1:04 ` [PATCH net-next 2/4] eth: stmmac: " Jakub Kicinski
2023-07-20 12:02 ` Yunsheng Lin
2023-07-20 1:04 ` [PATCH net-next 3/4] net: page_pool: hide page_pool_release_page() Jakub Kicinski
2023-07-20 12:08 ` Yunsheng Lin
2023-07-24 10:36 ` Ilias Apalodimas
2023-07-20 1:04 ` [PATCH net-next 4/4] net: page_pool: merge page_pool_release_page() with page_pool_return_page() Jakub Kicinski
2023-07-20 12:20 ` Yunsheng Lin
2023-07-24 10:38 ` Ilias Apalodimas
2023-07-20 14:28 ` [PATCH net-next 0/4] net: page_pool: remove page_pool_release_page() Alexander Lobakin
2023-07-22 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720010409.1967072-2-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gerhard@engleder-embedded.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.