From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH v2 2/3] scsi: Remove a blk_mq_run_hw_queues() call
Date: Thu, 20 Jul 2023 07:40:56 +0200 [thread overview]
Message-ID: <20230720054056.GB2450@lst.de> (raw)
In-Reply-To: <20230719182243.2810134-3-bvanassche@acm.org>
On Wed, Jul 19, 2023 at 11:22:41AM -0700, Bart Van Assche wrote:
> blk_mq_kick_requeue_list() calls blk_mq_run_hw_queues() asynchronously.
> Leave out the direct blk_mq_run_hw_queues() call. This patch causes
> scsi_run_queue() to call blk_mq_run_hw_queues() asynchronously instead
> of synchronously. Since scsi_run_queue() is not called from the hot I/O
> submission path, this patch does not affect the hot path.
I think this looks good, but a comment in the code that we now rely
on blk_mq_kick_requeue_list to run the queue for us might be useful
as that is a little counter-intuitive.
next prev parent reply other threads:[~2023-07-20 5:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 18:22 [PATCH v2 0/3] Improve performance for BLK_MQ_F_BLOCKING drivers Bart Van Assche
2023-07-19 18:22 ` [PATCH v2 1/3] scsi: Inline scsi_kick_queue() Bart Van Assche
2023-07-20 5:39 ` Christoph Hellwig
2023-07-19 18:22 ` [PATCH v2 2/3] scsi: Remove a blk_mq_run_hw_queues() call Bart Van Assche
2023-07-20 5:40 ` Christoph Hellwig [this message]
2023-07-19 18:22 ` [PATCH v2 3/3] block: Improve performance for BLK_MQ_F_BLOCKING drivers Bart Van Assche
2023-07-20 5:54 ` Christoph Hellwig
2023-07-20 15:44 ` Bart Van Assche
2023-07-21 6:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720054056.GB2450@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.