From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 351A4182C0 for ; Thu, 20 Jul 2023 14:20:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4977CC433C7; Thu, 20 Jul 2023 14:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689862851; bh=8czobt6b2nGsykSx6kshr/iFGD0uIXglebqw3BxMl0U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=haWaSmUPYpKqdiouAbxDguEGIvEqUHnC7vPIYIcwQKsBSwxUFcGAF9sMZEiY/ojZb ibHhJv/G2EP7b5dMf4Xc8dpD0Zd6sewpWtA3/2FlqHFbZN0FucgSIRtbBqqhPHha3R BEj33Xqr0v+q1bkMoJhKaHtXWnGONgMWpydDPGGMs5cyQ2T0dAFMScwWKEK/PjDCeJ m2kgl8BBopE0SZQF0BCMAW6ho9gCmcfPK5LwrB6U34xZDvrudvzk8uPrPLQiiILxfp 8Npe/NoYCP8yC4By7mKrIZqN5LTADOn7+vfPsT1o5OvcrA62bpbNbSZIZLEDlH6Qpr Ft+7xwlWglzzw== Date: Thu, 20 Jul 2023 19:50:34 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Manivannan Sadhasivam , helgaas@kernel.org, imx@lists.linux.dev, bhelgaas@google.com, devicetree@vger.kernel.org, gustavo.pimentel@synopsys.com, kw@linux.com, leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, minghuan.lian@nxp.com, mingkai.hu@nxp.com, robh+dt@kernel.org, roy.zang@nxp.com, shawnguo@kernel.org, zhiqiang.hou@nxp.com Subject: Re: [PATCH v3 1/2] PCI: dwc: Implement general suspend/resume functionality for L2/L3 transitions Message-ID: <20230720142034.GA48270@thinkpad> References: <20230419164118.596300-1-Frank.Li@nxp.com> <20230717164526.GC35455@thinkpad> <20230718100400.GB4771@thinkpad> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jul 19, 2023 at 03:16:48PM -0400, Frank Li wrote: > On Tue, Jul 18, 2023 at 03:34:00PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Jul 17, 2023 at 02:36:19PM -0400, Frank Li wrote: > > > > Fine then. But can we check for PM_LINKST_IN_L2 SII System Information Interface > > (SII) instead of LTSSM state? > > > where define PM_LINKST_IN_L2? I just find one at > > drivers/pci/controller/dwc/pcie-qcom.c:#define PARF_DEBUG_CNT_PM_LINKST_IN_L2 0xc04 > Yes, this register is not exposed by the DWC core itself but the vendors may expose such as Qcom as you pointed out. If it is not available on all platforms, then feel free to ignore my advice. - Mani > Frank > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEFB7EB64DA for ; Thu, 20 Jul 2023 14:21:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8PU2tqB5aUXIYNQRf/N3BlkTMko3citbCRm8L6jDi8o=; b=nNPuyEWpLgD2N4 Oxm2SINHI2Wo3LEObbULCsXyjhdo9ilwzcj5+GkF4JcAqGlLcUU4HUxEu9roIDiyZy5YbllDsxHvn tSOlPIWunOApqhKbiqzWyua2vEIWo2n03ep8po+nUCia3CdCiBLFMRthoU2wlAgy68vjxzGbrx97d Zg+lPD3EE50lVteDFlwrff8oZjYAcCoY1nmMfg3jA4+YqPBvHATPee8d1WpfhbwDKtoU6zsg+nfcu /tj/F6mSJfJ7nQseM7uqgQXJdRwe2BaqCAda79Q/GANtYJCeJVr3meot5UncEOgWg0umRirwPUu8O EkTwjfa9bG59lELe5ynw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMUWY-00BND9-09; Thu, 20 Jul 2023 14:20:58 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMUWV-00BNBg-2C for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2023 14:20:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 39EDB61AFB; Thu, 20 Jul 2023 14:20:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4977CC433C7; Thu, 20 Jul 2023 14:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689862851; bh=8czobt6b2nGsykSx6kshr/iFGD0uIXglebqw3BxMl0U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=haWaSmUPYpKqdiouAbxDguEGIvEqUHnC7vPIYIcwQKsBSwxUFcGAF9sMZEiY/ojZb ibHhJv/G2EP7b5dMf4Xc8dpD0Zd6sewpWtA3/2FlqHFbZN0FucgSIRtbBqqhPHha3R BEj33Xqr0v+q1bkMoJhKaHtXWnGONgMWpydDPGGMs5cyQ2T0dAFMScwWKEK/PjDCeJ m2kgl8BBopE0SZQF0BCMAW6ho9gCmcfPK5LwrB6U34xZDvrudvzk8uPrPLQiiILxfp 8Npe/NoYCP8yC4By7mKrIZqN5LTADOn7+vfPsT1o5OvcrA62bpbNbSZIZLEDlH6Qpr Ft+7xwlWglzzw== Date: Thu, 20 Jul 2023 19:50:34 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Manivannan Sadhasivam , helgaas@kernel.org, imx@lists.linux.dev, bhelgaas@google.com, devicetree@vger.kernel.org, gustavo.pimentel@synopsys.com, kw@linux.com, leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, minghuan.lian@nxp.com, mingkai.hu@nxp.com, robh+dt@kernel.org, roy.zang@nxp.com, shawnguo@kernel.org, zhiqiang.hou@nxp.com Subject: Re: [PATCH v3 1/2] PCI: dwc: Implement general suspend/resume functionality for L2/L3 transitions Message-ID: <20230720142034.GA48270@thinkpad> References: <20230419164118.596300-1-Frank.Li@nxp.com> <20230717164526.GC35455@thinkpad> <20230718100400.GB4771@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_072055_788575_6A69F672 X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMTksIDIwMjMgYXQgMDM6MTY6NDhQTSAtMDQwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gT24gVHVlLCBKdWwgMTgsIDIwMjMgYXQgMDM6MzQ6MDBQTSArMDUzMCwgTWFuaXZhbm5hbiBT YWRoYXNpdmFtIHdyb3RlOgo+ID4gT24gTW9uLCBKdWwgMTcsIDIwMjMgYXQgMDI6MzY6MTlQTSAt MDQwMCwgRnJhbmsgTGkgd3JvdGU6Cj4gPiAKPiA+IEZpbmUgdGhlbi4gQnV0IGNhbiB3ZSBjaGVj ayBmb3IgUE1fTElOS1NUX0lOX0wyIFNJSSBTeXN0ZW0gSW5mb3JtYXRpb24gSW50ZXJmYWNlCj4g PiAoU0lJKSBpbnN0ZWFkIG9mIExUU1NNIHN0YXRlPwo+ID4KPiB3aGVyZSBkZWZpbmUgUE1fTElO S1NUX0lOX0wyPyBJIGp1c3QgZmluZCBvbmUgYXQKPiAKPiBkcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2llLXFjb20uYzojZGVmaW5lIFBBUkZfREVCVUdfQ05UX1BNX0xJTktTVF9JTl9MMiAg ICAgICAgICAgMHhjMDQKPiAKClllcywgdGhpcyByZWdpc3RlciBpcyBub3QgZXhwb3NlZCBieSB0 aGUgRFdDIGNvcmUgaXRzZWxmIGJ1dCB0aGUgdmVuZG9ycyBtYXkKZXhwb3NlIHN1Y2ggYXMgUWNv bSBhcyB5b3UgcG9pbnRlZCBvdXQuIElmIGl0IGlzIG5vdCBhdmFpbGFibGUgb24gYWxsIHBsYXRm b3JtcywKdGhlbiBmZWVsIGZyZWUgdG8gaWdub3JlIG15IGFkdmljZS4KCi0gTWFuaQoKPiBGcmFu awo+ICAKCi0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K61 4K6u4K+NCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==