All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Milan P. Stanić" <mps@arvanta.net>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de,
	"Christoph Niedermaier" <cniedermaier@dh-electronics.com>,
	"Marek Behún" <marek.behun@nic.cz>,
	"Simon Glass" <sjg@chromium.org>,
	"Stefano Babic" <sbabic@denx.de>,
	u-boot@dh-electronics.com
Subject: Re: [PATCH] Makefile: Use sort shortopts
Date: Thu, 20 Jul 2023 18:28:51 +0200	[thread overview]
Message-ID: <20230720162851.GA9595@m1> (raw)
In-Reply-To: <20230720125042.70593-1-marex@denx.de>

On Thu, 2023-07-20 at 14:50, Marek Vasut wrote:
> POSIX does not defined longopts for sort, use shortops
> for even more compatibility.
> 
> Fixes: cc5a490cf465 ("Makefile: Sort u-boot-initial-env output")
> Reported-by: Milan P. Stanić <mps@arvanta.net>
> Signed-off-by: Marek Vasut <marex@denx.de>

Tested-by: Milan P. Stanić <mps@arvanta.net>

small note: single quotes are not needed aroud = (equal sign)

> ---
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Marek Behún <marek.behun@nic.cz>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: u-boot@dh-electronics.com
> Cc: u-boot@lists.denx.de
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 87f9fc786e8..5fc16b3b1f1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2444,7 +2444,7 @@ quiet_cmd_genenv = GENENV  $@
>  cmd_genenv = \
>  	$(objtree)/tools/printinitialenv | \
>  	sed -e '/^\s*$$/d' | \
> -	sort --field-separator='=' -k1,1 --stable -o $@
> +	sort -t '=' -k 1,1 -s -o $@
>  
>  u-boot-initial-env: $(env_h) FORCE
>  	$(Q)$(MAKE) $(build)=tools $(objtree)/tools/printinitialenv
> -- 
> 2.40.1
> 

  parent reply	other threads:[~2023-07-20 16:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 12:50 [PATCH] Makefile: Use sort shortopts Marek Vasut
2023-07-20 13:45 ` Mark Kettenis
2023-07-20 16:28 ` Milan P. Stanić [this message]
2023-07-25 21:14 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230720162851.GA9595@m1 \
    --to=mps@arvanta.net \
    --cc=cniedermaier@dh-electronics.com \
    --cc=marek.behun@nic.cz \
    --cc=marex@denx.de \
    --cc=sbabic@denx.de \
    --cc=sjg@chromium.org \
    --cc=u-boot@dh-electronics.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.