From: Jakub Kicinski <kuba@kernel.org>
To: Asmaa Mnebhi <asmaa@nvidia.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"sridhar.samudrala@intel.com" <sridhar.samudrala@intel.com>,
"maciej.fijalkowski@intel.com" <maciej.fijalkowski@intel.com>,
"olteanv@gmail.com" <olteanv@gmail.com>,
David Thompson <davthompson@nvidia.com>
Subject: Re: [PATCH net v3 1/1] mlxbf_gige: Fix kernel panic at shutdown
Date: Thu, 20 Jul 2023 20:21:32 -0700 [thread overview]
Message-ID: <20230720202132.268dd1fd@kernel.org> (raw)
In-Reply-To: <CH2PR12MB389598B6D2C1EFA43F7B8936D73EA@CH2PR12MB3895.namprd12.prod.outlook.com>
On Thu, 20 Jul 2023 21:11:53 +0000 Asmaa Mnebhi wrote:
> > .probe = mlxbf_gige_probe,
> > .remove = mlxbf_gige_remove,
> > - .shutdown = mlxbf_gige_shutdown,
> > + .shutdown = mlxbf_gige_remove,
>
> Actually, apologies for this commit in response to Sridhar's comment
> on v2. This will not work. Mlxbf_gige_remove() returns void while
> ".shutdown" expects to return an int. Please advise on how to
> proceed. Should I send a v4 with the same patch as v2?
You can make it work, there is a new version of remove upstream:
https://elixir.bootlin.com/linux/v6.5-rc2/source/include/linux/platform_device.h#L220
You can make them both void.
--
pw-bot: cr
prev parent reply other threads:[~2023-07-21 3:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 20:56 [PATCH net v3 1/1] mlxbf_gige: Fix kernel panic at shutdown Asmaa Mnebhi
2023-07-20 21:11 ` Asmaa Mnebhi
2023-07-21 3:21 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720202132.268dd1fd@kernel.org \
--to=kuba@kernel.org \
--cc=asmaa@nvidia.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.