Re: [PATCH 3/3] btrfs: cycle through the RAID profiles as a last resort

[Josef Bacik <josef@toxicpanda.com>]

On Thu, Jul 20, 2023 at 03:28:17PM -0700, Boris Burkov wrote:
> On Thu, Jul 20, 2023 at 04:12:16PM -0400, Josef Bacik wrote:
> > Instead of looping through the RAID indices before advancing the FFE
> > loop lets move this until after we've exhausted the entire FFE loop in
> > order to give us the highest chance of success in satisfying the
> > allocation based on its flags.
> 
> Doesn't this get screwed by the find_free_extent_update_loop setting
> index to 0?
> 
> i.e., let's say we fail on the first pass with the correct raid flag.
> then we go into find_free_extent_update_loop and intelligently don't do
> the pointless raid loops. But then we set index to 0 and start doing an
> even worse meta loop of doing every step (including allocating chunks)
> with every raid index, most of which are doomed to fail by definition.
> 
> Not setting it to 0, OTOH, breaks the logic for setting "full_search",
> but I do think that could be fixed one way or another.
> 

Yeah lets drop this, a bunch of tests failed, I need to drop this and re-run and
see what happens.  I hate this code.  Thanks,

Josef