From: Tony Lindgren <tony@atomide.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Jiri Slaby" <jirislaby@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] serial: core: Controller id cannot be negative
Date: Fri, 21 Jul 2023 09:15:23 +0300 [thread overview]
Message-ID: <20230721061523.GP5194@atomide.com> (raw)
In-Reply-To: <2023072144-splurge-debate-e681@gregkh>
* Greg Kroah-Hartman <gregkh@linuxfoundation.org> [230721 06:00]:
> On Fri, Jul 21, 2023 at 08:43:26AM +0300, Tony Lindgren wrote:
> > * Greg Kroah-Hartman <gregkh@linuxfoundation.org> [230720 19:33]:
> > > On Thu, Jul 20, 2023 at 08:10:14AM +0300, Tony Lindgren wrote:
> > > > The controller id cannot be negative.
> > > >
> > >
> > > What does this mean for a changelog?
> >
> > Just let's fix it while at it and adding port_id in the following patch.
> > If you prefer I can squash the change into the fix adding port_id.
>
> A separate patch like this is fine, just properly document it please :)
OK will do.
Looks like linux-serial not getting added is caused by MAINTAINERS
not listing serial_base_bus.c, serial_ctrl.c and serial_port.c. This
causes get_maintainer.pl to not show linux-serial for a patch touching
serial_base_bus.c.. And this will causes git send-email to not pick up
linux-serial.. I'll send a patch for MAINTAINERS file too.
Regards,
Tony
next prev parent reply other threads:[~2023-07-21 6:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 5:10 [PATCH v2 0/3] Serial core controller port device name fixes Tony Lindgren
2023-07-20 5:10 ` [PATCH v2 1/3] serial: core: Controller id cannot be negative Tony Lindgren
2023-07-20 19:33 ` Greg Kroah-Hartman
2023-07-21 5:43 ` Tony Lindgren
2023-07-21 6:00 ` Greg Kroah-Hartman
2023-07-21 6:15 ` Tony Lindgren [this message]
2023-07-21 6:57 ` Tony Lindgren
2023-07-21 7:06 ` Greg Kroah-Hartman
2023-07-21 7:17 ` Tony Lindgren
2023-07-21 10:09 ` Andy Shevchenko
2023-07-25 6:56 ` Tony Lindgren
2023-07-20 5:10 ` [PATCH v2 2/3] serial: core: Fix serial core port id to not use port->line Tony Lindgren
2023-07-20 5:10 ` [PATCH v2 3/3] serial: core: Fix serial core controller port name to show controller id Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721061523.GP5194@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.