From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 592CCEB64DC for ; Fri, 21 Jul 2023 07:39:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Tin77eBz1rcpMuzB67h9DWTG/qNc5AXDKVd3Ou37+c=; b=wBXxZ7gSCXj8bX DBAbwVfUB/h/VUOB5psfVRCVPfk/Fo0Tdgbyu3bdYzImHepIjNOTDqCo04MqyArcHFX30vbzwKO+3 M3YzO2TvUaaqBay+Qu1BCYzmlIIQhEFYYCwTyeN08eoobuuL3kY1NQ9Iv/F7qZx8wL0R4GqXYCsAB lCteTsANXB0rHurot8jKC++e4ePG/eCsu2XNpjzyArVXtcKlSrWnnVObyNz5aD8NLG628hJSVnf4z vP7zcUKtzOg/hXOCrv3ODr07majhrpojoShVi3pgLpUYDpqvhCKaZ/IFS5hVDp+uSp421sCD18RO7 0a+XDL3nrUBzy98panPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMkir-00DD0v-0V; Fri, 21 Jul 2023 07:38:45 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMkio-00DCzZ-0Z for linux-arm-kernel@lists.infradead.org; Fri, 21 Jul 2023 07:38:43 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E3DAB807E; Fri, 21 Jul 2023 07:38:37 +0000 (UTC) Date: Fri, 21 Jul 2023 10:38:36 +0300 From: Tony Lindgren To: Julien Panis Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, vigneshr@ti.com, afd@ti.com Subject: Re: [PATCH v2] ARM: multi_v7_defconfig: Enable OMAP watchdog support Message-ID: <20230721073836.GS5194@atomide.com> References: <20230718-enable-omap-wd-v2-1-921f829bc0a5@baylibre.com> <4db1d958-7b11-40d9-3f68-3e9390539cbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4db1d958-7b11-40d9-3f68-3e9390539cbe@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_003842_274277_1567262B X-CRM114-Status: GOOD ( 20.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBKdWxpZW4gUGFuaXMgPGpwYW5pc0BiYXlsaWJyZS5jb20+IFsyMzA3MTkgMTA6MDldOgo+IE9u IDcvMTgvMjMgMTY6NTgsIEp1bGllbiBQYW5pcyB3cm90ZToKPiA+IEluY3JlYXNlIGJ1aWxkIGFu ZCB0ZXN0IGNvdmVyYWdlIGJ5IGVuYWJsaW5nIHN1cHBvcnQgZm9yIE9NQVAgd2F0Y2hkb2csCj4g PiBhcyB1c2VkIG9uIFRJIE9NQVAgYmFzZWQgYm9hcmRzLgo+ID4gCj4gPiBUaGUgd2F0Y2hkb2cg dGltZXIgaXMgYW4gdXB3YXJkIGNvdW50ZXIgY2FwYWJsZSBvZiBnZW5lcmF0aW5nIGEgcHVsc2Ug b24KPiA+IHRoZSByZXNldCBwaW4gYW5kIGFuIGludGVycnVwdCB0byB0aGUgZGV2aWNlIHN5c3Rl bSBtb2R1bGVzIGZvbGxvd2luZyBhbgo+ID4gb3ZlcmZsb3cgY29uZGl0aW9uLgo+ID4gCj4gPiBT aWduZWQtb2ZmLWJ5OiBKdWxpZW4gUGFuaXMgPGpwYW5pc0BiYXlsaWJyZS5jb20+CgpMb29rcyBn b29kIHRvIG1lOgoKUmV2aWV3ZWQtYnk6IFRvbnkgTGluZGdyZW4gPHRvbnlAYXRvbWlkZS5jb20+ Cgo+IE1heWJlIHRoaXMgcGF0Y2ggc2hvdWxkIG5vdCBiZSBhcHBsaWVkIGFjdHVhbGx5LiBJIGhh dmUgMiBxdWVzdGlvbnM6Cj4gCj4gW1ExXSBVc2luZyB0aGUgZm9sbG93aW5nIGNtZCBzZXF1ZW5j ZSBsZWFkcyB0byBhIG1vZGlmaWVkICdtdWx0aV92N19kZWZjb25maWcnIGZpbGU6Cj4gwqDCoMKg wqDCoCAnbWFrZSBtdWx0aV92N19kZWZjb25maWcnCj4gwqDCoMKgwqDCoCAnbWFrZSBzYXZlZGVm Y29uZmlnJwo+IMKgwqDCoMKgwqAgJ212IGRlZmNvbmZpZyBhcmNoL2FybS9jb25maWdzL211bHRp X3Y3X2RlZmNvbmZpZycKPiAuLi5ldmVuIHdpdGhvdXQgbW9kaWZ5aW5nIENPTkZJR19PTUFQX1dB VENIRE9HIGZsYWcuCj4gSSBndWVzcyBpdCdzIGR1ZSB0byBtb2RpZmljYXRpb25zIGluIHZhcmlv dXMgS2NvbmZpZyBmaWxlcyAoZGVwZW5kZW5jaWVzIGZvciBpbnN0YW5jZSkuCj4gQW5kIHBlcmhh cHMgaXQncyBhbHNvIGR1ZSB0byBwcmV2aW91cyBtb2RpZmljYXRpb25zIG9mICdtdWx0aV92N19k ZWZjb25maWcnIGZpbGUgdGhhdAo+IHdlcmUgbm90IGRvbmUgYnkgdXNpbmcgJ21ha2Ugc2F2ZWRl ZmNvbmZpZycgKD8pCj4gSG93IHNob3VsZCBJIGhhbmRsZSB0aGF0IGZvciB0aGlzIHBhdGNoID8g VGhpcyB2MiBoYXMgYmVlbiBjcmVhdGVkIGJ5IG1vZGlmeWluZwo+ICdtdWx0aV92N19kZWZjb25m aWcnIGZpbGUgbWFudWFsbHkuIFVzaW5nICdtYWtlIHNhdmVkZWZjb25maWcnIHdvdWxkIGJlIGNs ZWFuZXIsCj4gYnV0IGFzIGEgcmVzdWx0IG1hbnkgZmxhZ3Mgd291bGQgYmUgcmUtb3JnYW5pemVk IHdoZXJlYXMgdGhlIGNvbW1pdCBpbnRlbmRzIHRvCj4gZW5hYmxlIDEgZmxhZyBvbmx5LgoKQWZ0 ZXIgbWFrZSBzYXZlZGVmY29uZmlnIHlvdSBjYW4gdGFrZSBhIGxvb2sgd2hlcmUgdGhlIG5ldyBv cHRpb24gZ290IHBsYWNlZAphbmQgdGhlbiB0aHJvdyBhd2F5IHRoZSBjaGFuZ2VzIGFuZCBhZGQg dGhlIGVudHJ5IG1hbnVhbGx5IDopCgo+IFtRMl0gSSB3b3VsZCBsaWtlIHRvIGFkZCBhbm90aGVy IGZsYWcgaW4gb3JkZXIgdG8gZW5hYmxlIENPTkZJR19SVENfRFJWX09NQVAuCj4gSXMgaXQgYmV0 dGVyIGdyb3VwaW5nIENPTkZJR19PTUFQX1dBVENIRE9HIGFuZCBDT05GSUdfUlRDX0RSVl9PTUFQ IGluCj4gYSBzaW5nbGUgY29tbWl0ID8gV2hhdCdzIHJlY29tbWVuZGVkID8KCkFkZGluZyBib3Ro IGlzIGZpbmUgZm9yIHRoZSBkZWZjb25maWcgY2hhbmdlLCBqdXN0IHRyeSB0byBwbGFjZSB0aGVt IHdoZXJlCnRoZXkgd291bGQgZW5kIHVwIGFmdGVyIHNhdmVkZWZjb25maWcgdG8gYXZvaWQgaXQg Z2V0dGluZyBtb3JlIG91dCBvZiBzeW5jLgoKUmVnYXJkcywKClRvbnkKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A84DCEB64DC for ; Fri, 21 Jul 2023 07:39:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230344AbjGUHi7 (ORCPT ); Fri, 21 Jul 2023 03:38:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230268AbjGUHip (ORCPT ); Fri, 21 Jul 2023 03:38:45 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9B5052733 for ; Fri, 21 Jul 2023 00:38:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E3DAB807E; Fri, 21 Jul 2023 07:38:37 +0000 (UTC) Date: Fri, 21 Jul 2023 10:38:36 +0300 From: Tony Lindgren To: Julien Panis Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, vigneshr@ti.com, afd@ti.com Subject: Re: [PATCH v2] ARM: multi_v7_defconfig: Enable OMAP watchdog support Message-ID: <20230721073836.GS5194@atomide.com> References: <20230718-enable-omap-wd-v2-1-921f829bc0a5@baylibre.com> <4db1d958-7b11-40d9-3f68-3e9390539cbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4db1d958-7b11-40d9-3f68-3e9390539cbe@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Julien Panis [230719 10:09]: > On 7/18/23 16:58, Julien Panis wrote: > > Increase build and test coverage by enabling support for OMAP watchdog, > > as used on TI OMAP based boards. > > > > The watchdog timer is an upward counter capable of generating a pulse on > > the reset pin and an interrupt to the device system modules following an > > overflow condition. > > > > Signed-off-by: Julien Panis Looks good to me: Reviewed-by: Tony Lindgren > Maybe this patch should not be applied actually. I have 2 questions: > > [Q1] Using the following cmd sequence leads to a modified 'multi_v7_defconfig' file: >       'make multi_v7_defconfig' >       'make savedefconfig' >       'mv defconfig arch/arm/configs/multi_v7_defconfig' > ...even without modifying CONFIG_OMAP_WATCHDOG flag. > I guess it's due to modifications in various Kconfig files (dependencies for instance). > And perhaps it's also due to previous modifications of 'multi_v7_defconfig' file that > were not done by using 'make savedefconfig' (?) > How should I handle that for this patch ? This v2 has been created by modifying > 'multi_v7_defconfig' file manually. Using 'make savedefconfig' would be cleaner, > but as a result many flags would be re-organized whereas the commit intends to > enable 1 flag only. After make savedefconfig you can take a look where the new option got placed and then throw away the changes and add the entry manually :) > [Q2] I would like to add another flag in order to enable CONFIG_RTC_DRV_OMAP. > Is it better grouping CONFIG_OMAP_WATCHDOG and CONFIG_RTC_DRV_OMAP in > a single commit ? What's recommended ? Adding both is fine for the defconfig change, just try to place them where they would end up after savedefconfig to avoid it getting more out of sync. Regards, Tony