Re: [Buildroot] [PATCH] boot/barebox: Fix building of internal scripts

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] boot/barebox: Fix building of internal scripts
Date: Fri, 21 Jul 2023 22:55:16 +0200	[thread overview]
Message-ID: <20230721225516.06eb14e0@windsurf> (raw)
In-Reply-To: <20230721063755.315887-1-eagle.alexander923@gmail.com>

Hello Alexander,

On Fri, 21 Jul 2023 09:37:55 +0300
Alexander Shiyan <eagle.alexander923@gmail.com> wrote:

> diff --git a/boot/barebox/Config.in b/boot/barebox/Config.in
> index 3961c69c56..9a8291c944 100644
> --- a/boot/barebox/Config.in
> +++ b/boot/barebox/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_TARGET_BAREBOX
>  	bool "Barebox"
> +	select BR2_PACKAGE_HOST_PKGCONF

Strictly speaking, this is not needed.

However, one issue with your patch is that you don't add host-pkgconf
in BAREBOX_DEPENDENCIES, so there is nothing that ensures host-pkgconf
will be built before barebox.

Another issue is that Barebox is looking for host OpenSSL, and you have
no guarantee that OpenSSL is installed system-wide on the build
machine. Therefore, a dependency on host-openssl is also needed. I
think this calls for an option like BR2_TARGET_UBOOT_NEEDS_OPENSSL, but
for Barebox.

> +# In order to compile some barebox target tools we need to use pkg-config,
> +# so lets always use CONFIGURATOR_MAKE_ENV wrapper.
> +	$$($(1)_CONFIGURATOR_MAKE_ENV) $$(MAKE) $$($(1)_MAKE_FLAGS) -C $$(@D)
>  	$$($(1)_BUILD_CUSTOM_ENV)
>  endef

I don't think <pkg>_CONFIGURATOR_MAKE_ENV is intended to be used here.
It is indeed to be used for the steps related to the configuration of
kconfig-package, to run make menuconfig, make xconfig, etc.

In U-Boot, we're doing this:

        $(TARGET_CONFIGURE_OPTS) \
                PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
                PKG_CONFIG_SYSROOT_DIR="/" \
                PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 \
                PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 \
                PKG_CONFIG_LIBDIR="$(HOST_DIR)/lib/pkgconfig:$(HOST_DIR)/share/pkgconfig" \
                $(UBOOT_MAKE) -C $(@D) $(UBOOT_MAKE_OPTS) \
                $(UBOOT_MAKE_TARGET)

So probably we need something similar here.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot