From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [RFC v6.5-rc2 2/3] fs: lockd: fix race in async lock request handling
Date: Sat, 22 Jul 2023 03:08:28 +0800 [thread overview]
Message-ID: <202307220225.DeAIaATn-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230720125806.1385279-2-aahringo@redhat.com>
References: <20230720125806.1385279-2-aahringo@redhat.com>
TO: Alexander Aring <aahringo@redhat.com>
Hi Alexander,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:
[auto build test WARNING on v6.5-rc2]
url: https://github.com/intel-lab-lkp/linux/commits/Alexander-Aring/fs-lockd-fix-race-in-async-lock-request-handling/20230720-210010
base: v6.5-rc2
patch link: https://lore.kernel.org/r/20230720125806.1385279-2-aahringo%40redhat.com
patch subject: [RFC v6.5-rc2 2/3] fs: lockd: fix race in async lock request handling
:::::: branch date: 30 hours ago
:::::: commit date: 30 hours ago
config: x86_64-randconfig-m001-20230720 (https://download.01.org/0day-ci/archive/20230722/202307220225.DeAIaATn-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230722/202307220225.DeAIaATn-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202307220225.DeAIaATn-lkp@intel.com/
smatch warnings:
fs/lockd/svclock.c:798 nlmsvc_grant_deferred() warn: iterator used outside loop: 'block'
vim +/block +798 fs/lockd/svclock.c
385d3265c23730 Alexander Aring 2023-07-20 777
385d3265c23730 Alexander Aring 2023-07-20 778 static int nlmsvc_grant_deferred(struct file_lock *fl, int result)
385d3265c23730 Alexander Aring 2023-07-20 779 {
385d3265c23730 Alexander Aring 2023-07-20 780 struct nlm_block *block = NULL;
385d3265c23730 Alexander Aring 2023-07-20 781 int rc;
385d3265c23730 Alexander Aring 2023-07-20 782
385d3265c23730 Alexander Aring 2023-07-20 783 spin_lock(&nlm_blocked_lock);
385d3265c23730 Alexander Aring 2023-07-20 784 list_for_each_entry(block, &nlm_blocked, b_list) {
385d3265c23730 Alexander Aring 2023-07-20 785 if (nlm_compare_locks(&block->b_call->a_args.lock.fl, fl)) {
385d3265c23730 Alexander Aring 2023-07-20 786 kref_get(&block->b_count);
0e4ac9d93515b2 Marc Eshel 2006-11-28 787 break;
0e4ac9d93515b2 Marc Eshel 2006-11-28 788 }
0e4ac9d93515b2 Marc Eshel 2006-11-28 789 }
f904be9cc77f36 Bryan Schumaker 2010-09-21 790 spin_unlock(&nlm_blocked_lock);
385d3265c23730 Alexander Aring 2023-07-20 791
385d3265c23730 Alexander Aring 2023-07-20 792 if (!block) {
385d3265c23730 Alexander Aring 2023-07-20 793 pr_warn("lockd: grant for unknown pending block\n");
385d3265c23730 Alexander Aring 2023-07-20 794 return -ENOENT;
385d3265c23730 Alexander Aring 2023-07-20 795 }
385d3265c23730 Alexander Aring 2023-07-20 796
385d3265c23730 Alexander Aring 2023-07-20 797 /* don't interfere with nlmsvc_lock() */
385d3265c23730 Alexander Aring 2023-07-20 @798 mutex_lock(&block->b_file->f_mutex);
385d3265c23730 Alexander Aring 2023-07-20 799 block->b_flags &= ~B_PENDING_CALLBACK;
385d3265c23730 Alexander Aring 2023-07-20 800
385d3265c23730 Alexander Aring 2023-07-20 801 spin_lock(&nlm_blocked_lock);
385d3265c23730 Alexander Aring 2023-07-20 802 WARN_ON_ONCE(list_empty(&block->b_list));
385d3265c23730 Alexander Aring 2023-07-20 803 rc = __nlmsvc_grant_deferred(block, fl, result);
385d3265c23730 Alexander Aring 2023-07-20 804 spin_unlock(&nlm_blocked_lock);
385d3265c23730 Alexander Aring 2023-07-20 805 mutex_unlock(&block->b_file->f_mutex);
385d3265c23730 Alexander Aring 2023-07-20 806
385d3265c23730 Alexander Aring 2023-07-20 807 nlmsvc_release_block(block);
0e4ac9d93515b2 Marc Eshel 2006-11-28 808 return rc;
0e4ac9d93515b2 Marc Eshel 2006-11-28 809 }
0e4ac9d93515b2 Marc Eshel 2006-11-28 810
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-07-21 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 19:08 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-07-20 12:58 [Cluster-devel] [RFC v6.5-rc2 1/3] fs: lockd: nlm_blocked list race fixes Alexander Aring
2023-07-20 12:58 ` [RFC v6.5-rc2 2/3] fs: lockd: fix race in async lock request handling Alexander Aring
2023-07-21 13:09 ` Alexander Aring
2023-07-21 16:43 ` Jeff Layton
2023-08-10 21:00 ` Alexander Aring
2023-07-21 15:45 ` Jeff Layton
2023-08-10 20:37 ` Alexander Aring
2023-07-24 8:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307220225.DeAIaATn-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.