From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB10727F17; Fri, 21 Jul 2023 20:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689970880; x=1721506880; h=date:from:to:cc:subject:message-id:mime-version; bh=iZAtPI2fn2qwOwcJinEcAwbubKEih3DcdnMuVgN2HoA=; b=hdnBUa2OOam+Xwpryj1e1M8fjjyQrUNT0kEZP+njIwADz2xQuoGxphkm 7t3OkOrDhMxUv5NfUsqKNECHCp52rjKleup2JZ/Jf/o7h3kISwCWxwf22 wXPBu+zV8qsAOCdOCRdfgutgzjMe3VuD/tR2DobmUfBmaYQV3tWzQEkb4 P6ckWJAe1dUsuEYG6Jx8uSVoqXA3ZvcHHus1pRWVwj/D4tmkDPR5RlHkK VLHa5DDXG9dP024t0k3LZvstofhtX9R/nXvqkQiupF7oVPN30XFc7UnEK 5yHvy702MJyZ3x/vl33PCaM3TMKGDc3AwSJs+g+XN3wVIZeqGYBfyF70v A==; X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="351996888" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="351996888" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 13:21:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="724986525" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="724986525" Received: from lkp-server02.sh.intel.com (HELO 36946fcf73d7) ([10.239.97.151]) by orsmga002.jf.intel.com with ESMTP; 21 Jul 2023 13:21:18 -0700 Received: from kbuild by 36946fcf73d7 with local (Exim 4.96) (envelope-from ) id 1qMwcn-0007dB-1u; Fri, 21 Jul 2023 20:21:17 +0000 Date: Sat, 22 Jul 2023 04:20:40 +0800 From: kernel test robot To: Chao Yu , Chao Yu Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Greg Kroah-Hartman , Theodore Ts'o Subject: [linux-stable-rc:linux-4.14.y 5002/5021] fs/ext4/ioctl.c:523:7: error: incompatible pointer to integer conversion assigning to 'int' from 'struct super_block *' Message-ID: <202307220458.koLmwkSE-lkp@intel.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y head: 5cffa7b2aa8b04d9314eff634a714e0c6fc2b754 commit: c5db0ab1cf73c0d6b3a55de6a6077f6e314dbf6b [5002/5021] ext4: fix to check return value of freeze_bdev() in ext4_shutdown() config: mips-cavium_octeon_defconfig (https://download.01.org/0day-ci/archive/20230722/202307220458.koLmwkSE-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce: (https://download.01.org/0day-ci/archive/20230722/202307220458.koLmwkSE-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202307220458.koLmwkSE-lkp@intel.com/ All errors (new ones prefixed by >>): >> fs/ext4/ioctl.c:523:7: error: incompatible pointer to integer conversion assigning to 'int' from 'struct super_block *' [-Wint-conversion] 523 | ret = freeze_bdev(sb->s_bdev); | ^ ~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. vim +523 fs/ext4/ioctl.c 500 501 static int ext4_shutdown(struct super_block *sb, unsigned long arg) 502 { 503 struct ext4_sb_info *sbi = EXT4_SB(sb); 504 __u32 flags; 505 int ret; 506 507 if (!capable(CAP_SYS_ADMIN)) 508 return -EPERM; 509 510 if (get_user(flags, (__u32 __user *)arg)) 511 return -EFAULT; 512 513 if (flags > EXT4_GOING_FLAGS_NOLOGFLUSH) 514 return -EINVAL; 515 516 if (ext4_forced_shutdown(sbi)) 517 return 0; 518 519 ext4_msg(sb, KERN_ALERT, "shut down requested (%d)", flags); 520 521 switch (flags) { 522 case EXT4_GOING_FLAGS_DEFAULT: > 523 ret = freeze_bdev(sb->s_bdev); 524 if (ret) 525 return ret; 526 set_bit(EXT4_FLAGS_SHUTDOWN, &sbi->s_ext4_flags); 527 thaw_bdev(sb->s_bdev, sb); 528 break; 529 case EXT4_GOING_FLAGS_LOGFLUSH: 530 set_bit(EXT4_FLAGS_SHUTDOWN, &sbi->s_ext4_flags); 531 if (sbi->s_journal && !is_journal_aborted(sbi->s_journal)) { 532 (void) ext4_force_commit(sb); 533 jbd2_journal_abort(sbi->s_journal, -ESHUTDOWN); 534 } 535 break; 536 case EXT4_GOING_FLAGS_NOLOGFLUSH: 537 set_bit(EXT4_FLAGS_SHUTDOWN, &sbi->s_ext4_flags); 538 if (sbi->s_journal && !is_journal_aborted(sbi->s_journal)) 539 jbd2_journal_abort(sbi->s_journal, -ESHUTDOWN); 540 break; 541 default: 542 return -EINVAL; 543 } 544 clear_opt(sb, DISCARD); 545 return 0; 546 } 547 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki