From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Nuno Sa <nuno.sa@analog.com>
Subject: Re: [PATCH v2 8/8] iio: core: Improve indentation in a few places
Date: Sun, 23 Jul 2023 10:24:43 +0100 [thread overview]
Message-ID: <20230723102443.7bcb1abb@jic23-huawei> (raw)
In-Reply-To: <20230721170022.3461-9-andriy.shevchenko@linux.intel.com>
On Fri, 21 Jul 2023 20:00:22 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Improve an indentation in a few places to increase readability.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Applied to the togreg branch of iio.git and pushed out as testing
for 0-day to not notice any change (hopefully ;)
Jonathan
> ---
> drivers/iio/industrialio-core.c | 23 ++++++++++-------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 5c9c68d69fc6..e1293fdbc0ef 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -206,9 +206,9 @@ bool iio_buffer_enabled(struct iio_dev *indio_dev)
> {
> struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
>
> - return iio_dev_opaque->currentmode
> - & (INDIO_BUFFER_TRIGGERED | INDIO_BUFFER_HARDWARE |
> - INDIO_BUFFER_SOFTWARE);
> + return iio_dev_opaque->currentmode &
> + (INDIO_BUFFER_HARDWARE | INDIO_BUFFER_SOFTWARE |
> + INDIO_BUFFER_TRIGGERED);
> }
> EXPORT_SYMBOL_GPL(iio_buffer_enabled);
>
> @@ -388,8 +388,8 @@ static ssize_t iio_debugfs_read_reg(struct file *file, char __user *userbuf,
> }
>
> iio_dev_opaque->read_buf_len = snprintf(iio_dev_opaque->read_buf,
> - sizeof(iio_dev_opaque->read_buf),
> - "0x%X\n", val);
> + sizeof(iio_dev_opaque->read_buf),
> + "0x%X\n", val);
>
> return simple_read_from_buffer(userbuf, count, ppos,
> iio_dev_opaque->read_buf,
> @@ -492,8 +492,7 @@ static ssize_t iio_read_channel_ext_info(struct device *dev,
>
> static ssize_t iio_write_channel_ext_info(struct device *dev,
> struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> + const char *buf, size_t len)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
> @@ -585,9 +584,9 @@ static int iio_setup_mount_idmatrix(const struct device *dev,
> ssize_t iio_show_mount_matrix(struct iio_dev *indio_dev, uintptr_t priv,
> const struct iio_chan_spec *chan, char *buf)
> {
> - const struct iio_mount_matrix *mtx = ((iio_get_mount_matrix_t *)
> - priv)(indio_dev, chan);
> + const struct iio_mount_matrix *mtx;
>
> + mtx = ((iio_get_mount_matrix_t *)priv)(indio_dev, chan);
> if (IS_ERR(mtx))
> return PTR_ERR(mtx);
>
> @@ -1025,14 +1024,12 @@ int __iio_device_attr_init(struct device_attribute *dev_attr,
> if (chan->modified && (shared_by == IIO_SEPARATE)) {
> if (chan->extend_name)
> full_postfix = kasprintf(GFP_KERNEL, "%s_%s_%s",
> - iio_modifier_names[chan
> - ->channel2],
> + iio_modifier_names[chan->channel2],
> chan->extend_name,
> postfix);
> else
> full_postfix = kasprintf(GFP_KERNEL, "%s_%s",
> - iio_modifier_names[chan
> - ->channel2],
> + iio_modifier_names[chan->channel2],
> postfix);
> } else {
> if (chan->extend_name == NULL || shared_by != IIO_SEPARATE)
prev parent reply other threads:[~2023-07-23 9:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 17:00 [PATCH v2 0/8] iio: core: A few code cleanups and documentation fixes Andy Shevchenko
2023-07-21 17:00 ` [PATCH v2 1/8] iio: core: Add opaque_struct_size() helper and use it Andy Shevchenko
2023-07-21 17:22 ` Andy Shevchenko
2023-07-21 17:25 ` Andy Shevchenko
2023-07-21 17:27 ` Andy Shevchenko
2023-07-21 18:12 ` Uwe Kleine-König
2023-07-21 17:00 ` [PATCH v2 2/8] iio: core: Use sysfs_match_string() helper Andy Shevchenko
2023-07-22 17:11 ` Jonathan Cameron
2023-07-21 17:00 ` [PATCH v2 3/8] iio: core: Switch to krealloc_array() Andy Shevchenko
2023-07-22 17:28 ` Jonathan Cameron
2023-07-24 10:37 ` Andy Shevchenko
2023-07-21 17:00 ` [PATCH v2 4/8] iio: core: Use min() instead of min_t() to make code more robust Andy Shevchenko
2023-07-23 9:14 ` Jonathan Cameron
2023-07-21 17:00 ` [PATCH v2 5/8] iio: core: Get rid of redundant 'else' Andy Shevchenko
2023-07-23 9:16 ` Jonathan Cameron
2023-07-21 17:00 ` [PATCH v2 6/8] iio: core: Fix issues and style of the comments Andy Shevchenko
2023-07-21 20:48 ` Randy Dunlap
2023-07-21 21:37 ` andy.shevchenko
2023-07-23 9:21 ` Jonathan Cameron
2023-07-21 17:00 ` [PATCH v2 7/8] iio: core: Move initcalls closer to the respective calls Andy Shevchenko
2023-07-23 9:23 ` Jonathan Cameron
2023-07-24 10:53 ` Andy Shevchenko
2023-07-21 17:00 ` [PATCH v2 8/8] iio: core: Improve indentation in a few places Andy Shevchenko
2023-07-23 9:24 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230723102443.7bcb1abb@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.