Re: [PATCH RFC 2/2] i2c: Add i2c_device_get_match_data() callback

[kernel test robot <lkp@intel.com>]

Hi Biju,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on driver-core/driver-core-next driver-core/driver-core-linus wsa/i2c/for-next linus/master v6.5-rc2 next-20230721]
[cannot apply to sailus-media-tree/streams]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Biju-Das/drivers-fwnode-Extend-device_get_match_data-to-struct-bus_type/20230723-163825
base:   driver-core/driver-core-testing
patch link:    https://lore.kernel.org/r/20230723083721.35384-3-biju.das.jz%40bp.renesas.com
patch subject: [PATCH RFC 2/2] i2c: Add i2c_device_get_match_data() callback
config: sh-randconfig-r023-20230723 (https://download.01.org/0day-ci/archive/20230723/202307231900.3fDdJkXn-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230723/202307231900.3fDdJkXn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307231900.3fDdJkXn-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/i2c/i2c-core-base.c: In function 'i2c_get_match_data_helper':
>> drivers/i2c/i2c-core-base.c:126:16: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     126 |         return (const void *)match->driver_data;
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/i2c/i2c-core-base.c: In function 'i2c_device_get_match_data':
>> drivers/i2c/i2c-core-base.c:141:42: warning: passing argument 1 of 'i2c_get_match_data_helper' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     141 |         return i2c_get_match_data_helper(driver, client);
         |                                          ^~~~~~
   drivers/i2c/i2c-core-base.c:117:59: note: expected 'struct i2c_driver *' but argument is of type 'const struct i2c_driver *'
     117 | static void *i2c_get_match_data_helper(struct i2c_driver *driver,
         |                                        ~~~~~~~~~~~~~~~~~~~^~~~~~


vim +/const +126 drivers/i2c/i2c-core-base.c

   116	
   117	static void *i2c_get_match_data_helper(struct i2c_driver *driver,
   118					       const struct i2c_client *client)
   119	{
   120		const struct i2c_device_id *match;
   121	
   122		match = i2c_match_id(driver->id_table, client);
   123		if (!match)
   124			return NULL;
   125	
 > 126		return (const void *)match->driver_data;
   127	}
   128	
   129	static const void *i2c_device_get_match_data(const struct device *dev)
   130	{
   131		const struct i2c_client *client = to_i2c_client(dev);
   132		const struct i2c_driver *driver;
   133	
   134		if (!dev->driver)
   135			return NULL;
   136	
   137		driver = to_i2c_driver(dev->driver);
   138		if (!driver)
   139			return NULL;
   140	
 > 141		return i2c_get_match_data_helper(driver, client);
   142	}
   143	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki