From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A552C04A6A for ; Mon, 24 Jul 2023 15:14:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9E7A98674E; Mon, 24 Jul 2023 17:14:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="j83ovuQa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A228686709; Mon, 24 Jul 2023 17:14:18 +0200 (CEST) Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 142158674E for ; Mon, 24 Jul 2023 17:14:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-ua1-x933.google.com with SMTP id a1e0cc1a2514c-794c5f5ae8aso1173222241.3 for ; Mon, 24 Jul 2023 08:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1690211653; x=1690816453; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q/vMtTeJUc5D7Z0f1GVrkXZZuqpHjHxy/xiqF0gYx2Y=; b=j83ovuQaMrPbHXEqzXojnNi7DkiyzEaSCladcF5SuGw3BAwAqNIt0kJgc8gkQ491hh QLx/PIxPx0EvqnQMJ+BJRhClyk8KTXPpU4EZlk25ko/fXd8U8NIlFospQ3Zwq5ovkAG/ ftAgwAMCe2569kVCePILCIyCJsvtZ5sOuhR8M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690211653; x=1690816453; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q/vMtTeJUc5D7Z0f1GVrkXZZuqpHjHxy/xiqF0gYx2Y=; b=FpnCVtX5DcHOtrT6a2OITLyMo+vnE57m276wqpp1xNqJsVpXC8+SXLos12wopEGgKy dLQMqEL/TkNOk02VxFA9F4bjoAWkR91l5qtthfXa9mUEE65407JJIfYq8jH2lf8R8Qtq emkVWRtPec29eXaos/6vUqXB9/nTliNkhNtSg79oaM5bnG2O1iQnWN15jKRRlF7Ew/hh Tdb5sUD/vtC/oZr7ryx7pLjNAJ1ePLE5CEN4uqx/xhF+8iEKDKqslEYJ4yRiWbjkrB8m EjY8c1HMagO22ymzGiSPCZ3IA4A81Kw6bfUEdOucVrOk2s6IQTW8hmxbfA2VnsBcxHLB q9bg== X-Gm-Message-State: ABy/qLawhc741/7wpNdCe/JmH0RCgQU2osCUH+f6AGZU30gZhByOYPuT dbpUJzspuVyyuyFLkoCatHuZjg== X-Google-Smtp-Source: APBJJlE1Xo+LAzQlg4+BuHlR8qgwJIOIKv0CjXim45QOPAwTh6nGHxeJVmINUvJfj1QRvXwruQYumQ== X-Received: by 2002:a67:fdcc:0:b0:443:8b27:6dac with SMTP id l12-20020a67fdcc000000b004438b276dacmr2831057vsq.9.1690211652880; Mon, 24 Jul 2023 08:14:12 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-4f8e-955d-9d50-cbb0.res6.spectrum.com. [2603:6081:7b00:6400:4f8e:955d:9d50:cbb0]) by smtp.gmail.com with ESMTPSA id k1-20020a67c281000000b00446f58eb14dsm1376642vsj.26.2023.07.24.08.14.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jul 2023 08:14:12 -0700 (PDT) Date: Mon, 24 Jul 2023 11:14:10 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: Simon Glass , Leo Yu-Chi Liang , Marek Vasut , Mayuresh Chitale , Pali =?iso-8859-1?Q?Roh=E1r?= , Peng Fan , Nikita Shubin , Roger Quadros , Stefan Roese , Michal Simek , Mark Kettenis , u-boot@lists.denx.de Subject: Re: [PATCH] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI Message-ID: <20230724151410.GU3630934@bill-the-cat> References: <20230724070310.23790-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r0JsmKw9FMqOFZC6" Content-Disposition: inline In-Reply-To: <20230724070310.23790-1-heinrich.schuchardt@canonical.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --r0JsmKw9FMqOFZC6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 24, 2023 at 09:03:10AM +0200, Heinrich Schuchardt wrote: > CONFIG_SPL_PCI_PNP=3Dy without CONFIG_SPL_PCI=3Dy makes no sense. >=20 > Move CONFIG_SPL_PCI_PNP to the SPL menu and add the missing dependency. >=20 > Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable for SPL") > Signed-off-by: Heinrich Schuchardt > --- > common/spl/Kconfig | 12 ++++++++++++ > drivers/pci/Kconfig | 11 ----------- > 2 files changed, 12 insertions(+), 11 deletions(-) Lets not move this out of drivers/pci/Kconfig, just add the dependency. --=20 Tom --r0JsmKw9FMqOFZC6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmS+lUIACgkQFHw5/5Y0 tyxlPAv7BlXJxGgVnlzoUlUb3nYPDgCsd8i8yQwCy6B082y1/96HatNrN5SIojah n7gxFpnmErvkdEBsRGWoOKbrLq0+VN5gqQifr7Rc9Vr+lwMVaFghytNtEMZ5voP/ fmf7LGjoDHbwNlk9jBLUFg/RMKm9Ke3mYFXppoLhtfsog0m5UTi7ukjbnPZ/1NpL SrKnowvyzaRTSVKrsKEwALm+7p3pPwEd9VlO8Dqck22j+cfF4AGSCoFsEYjaKHgl BSe9T6eXaPYVXdTn1J4E0CCjkCJ9k7BqLu8c+fH8JEGvsOp1KvQVRIye0gCxkz2c aChdRSxKkYVhIFcau17MOitiJlLn5odqmN+4j7CbhkWYto+3kgo3TjYjy0pxHVxR Ei4oI8ZHO39rSUkurk5JJCV+w8WeEIvi3TExLJbIk6IsZ5o7mM7TQ162xmP8H6t8 sVznZ2mwpydmhc8G7d5ecnm7chy2M/ZK5OJdng13yAb4LUMDwe+yAPMO3Ytvv/Q3 UYU6XMH3 =gibw -----END PGP SIGNATURE----- --r0JsmKw9FMqOFZC6--