From: Christoph Hellwig <hch@lst.de>
To: Nitesh Shetty <nj.shetty@samsung.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
hch@lst.de, gost.dev@samsung.com,
Anuj Gupta <anuj20.g@samsung.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/read_write: Enable copy_file_range for block device.
Date: Mon, 24 Jul 2023 18:40:17 +0200 [thread overview]
Message-ID: <20230724164017.GC26430@lst.de> (raw)
In-Reply-To: <20230724060336.8939-1-nj.shetty@samsung.com>
> {
> - struct inode *inode_in = file_inode(file_in);
> - struct inode *inode_out = file_inode(file_out);
> + struct inode *inode_in = file_in->f_mapping->host;
> + struct inode *inode_out = file_out->f_mapping->host;
This doesn't directly have anything to do with block devices, as regular
files can also have a f_mapping that's different. None of the file
systems actually supporting copy offload right now do, but changing
the dereference here is a correctness thing totally independent of
block device support.
prev parent reply other threads:[~2023-07-24 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230724060655epcas5p24f21ce77480885c746b9b86d27585492@epcas5p2.samsung.com>
2023-07-24 6:03 ` [PATCH] fs/read_write: Enable copy_file_range for block device Nitesh Shetty
2023-07-24 6:39 ` Dave Chinner
2023-07-24 16:38 ` Christoph Hellwig
2023-07-24 22:08 ` Dave Chinner
2023-07-25 11:48 ` Nitesh Shetty
2023-07-24 16:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724164017.GC26430@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=brauner@kernel.org \
--cc=gost.dev@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nj.shetty@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.