From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBD7AC0015E for ; Mon, 24 Jul 2023 17:52:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0424A86765; Mon, 24 Jul 2023 19:52:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="JI81p8RW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 06953867D9; Mon, 24 Jul 2023 19:52:17 +0200 (CEST) Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 94C8A8062D for ; Mon, 24 Jul 2023 19:52:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-vk1-xa33.google.com with SMTP id 71dfb90a1353d-485e9849e7cso716142e0c.1 for ; Mon, 24 Jul 2023 10:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1690221133; x=1690825933; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nZkUxPp5/QzO0ibJqXW+Ann4WrYi56HtHngxmFdFak0=; b=JI81p8RWcF3h34CqmG9otvY3VauS/2FPsvDjdRRvrpXIjWz7qFXD+MiL2UZlmgBF4P q//hE2g3DW/oCj5uE4n8OYFhj5jXKCajHl9dmRciZQKCdpwpvkPSFG2wpJK2gk4gsbr3 hfTT1Rz3L32rvnXwLB1DMlnq6qtxZbMcE2PBQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690221133; x=1690825933; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nZkUxPp5/QzO0ibJqXW+Ann4WrYi56HtHngxmFdFak0=; b=ee/6eJAB7NqKF81AuCgWqAPoB+TpOxaB8p5/vN6M3W0kgVRWv5QoAEyrtV0fkWWZ7g JAOJ4JvxycvYet4wl41B56IWnQTpCqtZme1noHAGkmz63TteKPBxYRotV5Zreq1Aoi6F XKfHXaYfP8+GBANz53JIP+mjAKcKWcXykTyHmfLAAPKR7tFwyh3EjBnK9/AhePVc59Dr 17rWe14jgHWWnpP026GG/kEUTcycSzk8s3C+qgXFfass59yWw29GgMmXIdxYeEVl/EiV BWslqmBXnoJ19+SN5pVyz9N8rCbm2xQu195DX81iGxPh23m1cgotBT8t/LTS/B0I5u2C eDgQ== X-Gm-Message-State: ABy/qLaXMy7p7v6B7ehFkRNcRiaSIP0xxI/3vJZXSjdXEIo8/7pPFGI7 GTtS8aeL+alSfM9jEeMBa2k/OQ== X-Google-Smtp-Source: APBJJlHXHud6oWxzSpM580CCOQt7BnDSgqVIvYm/LR5XLpaoO+Qob8U1s/Y5RBBq7y5XrJYw4WH+IA== X-Received: by 2002:a1f:ea82:0:b0:47e:8a9:478c with SMTP id i124-20020a1fea82000000b0047e08a9478cmr4850973vkh.16.1690221133266; Mon, 24 Jul 2023 10:52:13 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-4f8e-955d-9d50-cbb0.res6.spectrum.com. [2603:6081:7b00:6400:4f8e:955d:9d50:cbb0]) by smtp.gmail.com with ESMTPSA id j26-20020ac5c31a000000b00483fb60717dsm1341427vkk.48.2023.07.24.10.52.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jul 2023 10:52:12 -0700 (PDT) Date: Mon, 24 Jul 2023 13:52:10 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: Simon Glass , Leo Yu-Chi Liang , Marek Vasut , Mayuresh Chitale , Pali =?iso-8859-1?Q?Roh=E1r?= , Peng Fan , Nikita Shubin , Roger Quadros , Stefan Roese , Michal Simek , Mark Kettenis , u-boot@lists.denx.de Subject: Re: [PATCH] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI Message-ID: <20230724175210.GF3630934@bill-the-cat> References: <20230724070310.23790-1-heinrich.schuchardt@canonical.com> <20230724151410.GU3630934@bill-the-cat> <777accb2-f184-4527-d897-4fe93d04b0a7@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="i5B5TPoQ9jT2pWtG" Content-Disposition: inline In-Reply-To: <777accb2-f184-4527-d897-4fe93d04b0a7@canonical.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --i5B5TPoQ9jT2pWtG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 24, 2023 at 07:46:09PM +0200, Heinrich Schuchardt wrote: > On 24.07.23 17:14, Tom Rini wrote: > > On Mon, Jul 24, 2023 at 09:03:10AM +0200, Heinrich Schuchardt wrote: > > > CONFIG_SPL_PCI_PNP=3Dy without CONFIG_SPL_PCI=3Dy makes no sense. > > >=20 > > > Move CONFIG_SPL_PCI_PNP to the SPL menu and add the missing dependenc= y. > > >=20 > > > Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable for SPL") > > > Signed-off-by: Heinrich Schuchardt > > > --- > > > common/spl/Kconfig | 12 ++++++++++++ > > > drivers/pci/Kconfig | 11 ----------- > > > 2 files changed, 12 insertions(+), 11 deletions(-) > >=20 > > Lets not move this out of drivers/pci/Kconfig, just add the dependency. > >=20 >=20 > Hello Tom, >=20 > when you configure boot methods you will enable SPL_PCI and with the patch > SPL_PCI_PNP will pop up beneath. If you leave SPL_PCI_PNP in the old pla= ce, > you will have a hard time figuring out why yout PCI is not working. >=20 > Why would you prefer to keep SPL_PCI_PNP outside of the SPL menu? We should move SPL_PCI out of common/spl/Kconfig as well then. It's 1500 lines, and yes there's likely more options still that should be moved out. --=20 Tom --i5B5TPoQ9jT2pWtG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmS+ukcACgkQFHw5/5Y0 tyxxXQv7BZvPh+up6oDv0ks3reyZnyIusQnAOOBSXBmo/1eFl0+V5/BHATR0rEuC gdKQvCAFsBpzrg+Ru0Pn/PtlXutPvVFbsG3lM+GA621vaXW61alT66W4399Lr2nb M8DirwqcAJKkBEtusq5sOkidck53zmjGIEgCGSCZmlofaNJkkMz86rF4gY9c5uRp V+PKK6cOA3PNM5q79j946oVc5npGoKW8Poxc7EN/a0MX3r526w0hq4A8Ilewkh6v HvtspHcIvzq3lxNHWuVVqEm/lPYHYfaecGas43xnD0ujr3yTBGzAYN1dQzHPBiZj 0TZXLgHAvynylDcGzdsrMeb3sFGloVZzaTz8p77/e/buVKM3AJpKoPYaVUWutMYv G2RYTcQU4PR1wZihBEwZcxriXbWfH1s6h2yncnfxWqRuTK+lYOLx6cRXCl+BXIQV f4qdV6D92ZeVnu6MWeDSgGjR3A7qQvtNq14ehRRkWXnNVum3hmoVt7cB7ApNKGo9 LRclnTPH =vX2h -----END PGP SIGNATURE----- --i5B5TPoQ9jT2pWtG--