From: Christoph Hellwig <hch@lst.de>
To: Boris Burkov <boris@bur.io>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: btrfs NOCOW fix and cleanups
Date: Mon, 24 Jul 2023 21:49:23 +0200 [thread overview]
Message-ID: <20230724194923.GC30159@lst.de> (raw)
In-Reply-To: <20230724183033.GB587411@zen>
On Mon, Jul 24, 2023 at 11:30:33AM -0700, Boris Burkov wrote:
> On Mon, Jul 24, 2023 at 07:22:37AM -0700, Christoph Hellwig wrote:
> > Hi all,
> >
> > this series fixes a (found by code inspection) bug in the error handling
> > in btrfs_run_delalloc_nocow, and then cleans up a bunch of things in
> > btrfs_run_delalloc_nocow to allow me to actually undestand the logic
> > there, and in case of the last patch signigicantly simplifies it.
> >
> > The series is on top of the for-next branch as that includes previous
> > work not in misc-next yet that the series relies on.
>
> This doesn't apply on the latest for-next, but I reviewed it from your
> git tree. It all LGTM there, thanks.
Yeah, looks like for-next got rebased again today. I'll rebase and
push it out to the git tree later today and can resend as needed.
next prev parent reply other threads:[~2023-07-24 19:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 14:22 btrfs NOCOW fix and cleanups Christoph Hellwig
2023-07-24 14:22 ` [PATCH 1/6] btrfs: fix error handling when in a COW window in run_delalloc_nocow Christoph Hellwig
2023-07-24 14:22 ` [PATCH 2/6] btrfs: cleanup the COW fallback logic " Christoph Hellwig
2023-07-24 14:22 ` [PATCH 3/6] btrfs: consolidate the error handling " Christoph Hellwig
2023-07-24 18:27 ` Boris Burkov
2023-07-24 19:48 ` Christoph Hellwig
2023-07-25 21:36 ` David Sterba
2023-07-24 14:22 ` [PATCH 4/6] btrfs: move the !zoned assert into run_delalloc_cow Christoph Hellwig
2023-07-24 14:22 ` [PATCH 5/6] btrfs: use nocow_end for the loop iteration in run_delalloc_cow Christoph Hellwig
2023-08-10 17:00 ` David Sterba
2023-07-24 14:22 ` [PATCH 6/6] btrfs: clone relocation checksums in btrfs_alloc_ordered_extent Christoph Hellwig
2023-08-10 17:07 ` David Sterba
2023-07-24 18:30 ` btrfs NOCOW fix and cleanups Boris Burkov
2023-07-24 19:49 ` Christoph Hellwig [this message]
2023-07-24 19:58 ` Christoph Hellwig
2023-07-25 21:42 ` David Sterba
2023-07-26 12:56 ` Christoph Hellwig
2023-07-27 11:50 ` David Sterba
2023-08-10 16:56 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724194923.GC30159@lst.de \
--to=hch@lst.de \
--cc=boris@bur.io \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.