From: Rob Herring <robh@kernel.org>
To: Rik van Riel <riel@surriel.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
Mike Rapoport <rppt@kernel.org>,
devicetree@vger.kernel.org, x86@kernel.org,
Juergen Gross <jgross@suse.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH] mm,ima,kexec: use memblock_free_late from ima_free_kexec_buffer
Date: Mon, 24 Jul 2023 17:32:56 -0600 [thread overview]
Message-ID: <20230724233256.GA1124187-robh@kernel.org> (raw)
In-Reply-To: <74c0d1b900d8f518bc152478682a353c29e0faa3.camel@surriel.com>
On Fri, Jul 21, 2023 at 08:40:41PM -0400, Rik van Riel wrote:
> On Fri, 2023-07-21 at 13:38 -0600, Rob Herring wrote:
> > On Thu, Jul 20, 2023 at 10:14:31AM -0400, Rik van Riel wrote:
> > > The code calling ima_free_kexec_buffer runs long after the memblock
> > > allocator has already been torn down, potentially resulting in a
> > > use
> > > after free in memblock_isolate_range.
> > >
> > > With KASAN or KFENCE, this use after free will result in a BUG
> > > from the idle task, and a subsequent kernel panic.
> > >
> > > Switch ima_free_kexec_buffer over to memblock_free_late to avoid
> > > that issue.
> > >
> > > Fixes: fee3ff99bc67 ("powerpc: Move arch independent ima kexec
> > > functions to drivers/of/kexec.c")
> >
> > Fixes: b69a2afd5afc ("x86/kexec: Carry forward IMA measurement log on
> > kexec")
> >
> Thank you for digging further back in the history of that code.
>
> > Acked-by: Rob Herring <robh@kernel.org>
> >
> > (I'm assuming someone else is taking this)
>
> I hope so, but I don't know who...
You could split this into 2 patches, then there's no doubt. And each
Fixes is clear.
Rob
prev parent reply other threads:[~2023-07-24 23:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 14:14 [PATCH] mm,ima,kexec: use memblock_free_late from ima_free_kexec_buffer Rik van Riel
2023-07-21 19:38 ` Rob Herring
2023-07-22 0:40 ` Rik van Riel
2023-07-24 23:32 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724233256.GA1124187-robh@kernel.org \
--to=robh@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jgross@suse.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@surriel.com \
--cc=rppt@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.