From: Leon Romanovsky <leon@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Avri Altman <avri.altman@wdc.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Jason Gunthorpe <jgg@nvidia.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Damien Le Moal <dlemoal@kernel.org>,
Sagi Grimberg <sagig@mellanox.com>,
David Dillow <dave@thedillows.org>,
Roland Dreier <roland@purestorage.com>
Subject: Re: [PATCH v2 2/2] RDMA/srp: Fix residual handling
Date: Tue, 25 Jul 2023 09:51:24 +0300 [thread overview]
Message-ID: <20230725065124.GN11388@unreal> (raw)
In-Reply-To: <20230724200843.3376570-3-bvanassche@acm.org>
On Mon, Jul 24, 2023 at 01:08:30PM -0700, Bart Van Assche wrote:
> Although the code for residual handling in the SRP initiator follows the
> SCSI documentation, that documentation has never been correct. Because
> scsi_finish_command() starts from the data buffer length and subtracts
> the residual, scsi_set_resid() must not be called if a residual overflow
> occurs. Hence remove the scsi_set_resid() calls from the SRP initiator
> if a residual overflow occurrs.
>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Fixes: 9237f04e12cc ("scsi: core: Fix scsi_get/set_resid() interface")
> Fixes: e714531a349f ("IB/srp: Fix residual handling")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/infiniband/ulp/srp/ib_srp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
Thanks,
Acked-by: Leon Romanovsky <leon@kernel.org>
next prev parent reply other threads:[~2023-07-25 6:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 20:08 [PATCH v2 0/2] Fix residual handling in two SCSI LLDs Bart Van Assche
2023-07-24 20:08 ` [PATCH v2 1/2] scsi: ufs: Fix residual handling Bart Van Assche
2023-07-24 20:51 ` Avri Altman
2023-07-25 12:02 ` Adrian Hunter
2023-07-24 20:08 ` [PATCH v2 2/2] RDMA/srp: " Bart Van Assche
2023-07-25 6:51 ` Leon Romanovsky [this message]
2023-07-26 1:34 ` [PATCH v2 0/2] Fix residual handling in two SCSI LLDs Martin K. Petersen
2023-07-31 19:45 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725065124.GN11388@unreal \
--to=leon@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=dave@thedillows.org \
--cc=dlemoal@kernel.org \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=roland@purestorage.com \
--cc=sagig@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.