All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raghu Halharvi <raghuhack78@gmail.com>
To: linux-cxl@vger.kernel.org,
	Alison Schofield <alison.schofield@intel.com>,
	raghuhack78@gmail.com, ira.weiny@intel.com, bwidawsk@kernel.org,
	dan.j.williams@intel.com, vishal.l.verma@intel.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH RESEND v6 0/2] Fixing check patch styling issues
Date: Tue, 25 Jul 2023 19:43:39 +0000	[thread overview]
Message-ID: <20230725194339.1694-1-raghuhack78@gmail.com> (raw)

v6 changes:
- The v5 was approved was not committed, submitting both patches(v6)
  addressing styling issues in cxl/mbox.c and cxl/region.c after
  rebasing with latest source. The changes remain same except the
  function in which redundant dev_err() was present has been renamed to
  cxl_memdev_state_create. (Alison/Ira)

v5 changes:
- Updated the missing reviewed tag in "cxl/mbox: Remove redundant
  dev_err() after failed mem alloc" patch (Dave Jiang)

v4 changes:
- Updated the respective patches with reviewers tags for respective
  patches(Dave Jiang)

v3 changes:
- Update the cover letter and commit message with full author
  name(Fabio/Alison)
- Correct the "typo error" in commit message(Fabio)

v2 changes:
Thanks Alison, Ira for your comments, modified the v1 patches as
suggested.
Dropped the patch containing tab changes in port.c

v1 cover letter:
The following patches are cleanup or fixing the styling issues found
using checkpatch

In cxl/core/mbox.c, in case of null check failure, returning errno or
-ENOMEM in this case is good enough, removing the redundant dev_err
message.

In cxl/core/region.c, the else is not required after the return
statement, cleaned it up.

Verified the build and sanity by booting the guest VM using the freshly
built components.

Raghu Halharvi (2):
  cxl/mbox: Remove redundant dev_err() after failed mem alloc
  cxl/region: Remove else after return statement

 drivers/cxl/core/mbox.c   | 4 +---
 drivers/cxl/core/region.c | 8 ++++----
 2 files changed, 5 insertions(+), 7 deletions(-)

-- 
2.39.2


             reply	other threads:[~2023-07-25 19:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 19:43 Raghu Halharvi [this message]
2023-07-26  3:45 ` [PATCH RESEND v6 0/2] Fixing check patch styling issues Alison Schofield
  -- strict thread matches above, loose matches on Subject: below --
2023-07-25 12:19 Raghu Halharvi
2023-07-25 17:55 ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230725194339.1694-1-raghuhack78@gmail.com \
    --to=raghuhack78@gmail.com \
    --cc=alison.schofield@intel.com \
    --cc=bwidawsk@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.