From: Jakub Kicinski <kuba@kernel.org>
To: Zheng Wang <zyytlz.wz@163.com>
Cc: s.shtylyov@omp.ru, lee@kernel.org, linyunsheng@huawei.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
richardcochran@gmail.com, p.zabel@pengutronix.de,
geert+renesas@glider.be, magnus.damm@gmail.com,
yoshihiro.shimoda.uh@renesas.com, biju.das.jz@bp.renesas.com,
wsa+renesas@sang-engineering.com, netdev@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
hackerzheng666@gmail.com, 1395428693sheep@gmail.com,
alex000young@gmail.com
Subject: Re: [PATCH v4] net: ravb: Fix possible UAF bug in ravb_remove
Date: Tue, 25 Jul 2023 20:19:52 -0700 [thread overview]
Message-ID: <20230725201952.2f23bb3b@kernel.org> (raw)
In-Reply-To: <20230725030026.1664873-1-zyytlz.wz@163.com>
On Tue, 25 Jul 2023 11:00:26 +0800 Zheng Wang wrote:
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 4d6b3b7d6abb..ce2da5101e51 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -2885,6 +2885,9 @@ static int ravb_remove(struct platform_device *pdev)
> struct ravb_private *priv = netdev_priv(ndev);
> const struct ravb_hw_info *info = priv->info;
>
> + netif_carrier_off(ndev);
> + netif_tx_disable(ndev);
> + cancel_work_sync(&priv->work);
Still racy, the carrier can come back up after canceling the work.
But whatever, this is a non-issue in the first place.
The fact that ravb_tx_timeout_work doesn't take any locks seems much
more suspicious.
next prev parent reply other threads:[~2023-07-26 3:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 3:00 [PATCH v4] net: ravb: Fix possible UAF bug in ravb_remove Zheng Wang
2023-07-26 3:19 ` Jakub Kicinski [this message]
2023-07-27 8:21 ` Paolo Abeni
2023-07-27 18:48 ` Sergey Shtylyov
2023-07-27 23:48 ` Jakub Kicinski
2023-07-28 10:32 ` Simon Horman
2023-09-20 2:37 ` Yoshihiro Shimoda
2023-09-29 20:23 ` Sergey Shtylyov
2023-10-02 0:11 ` Yoshihiro Shimoda
2023-10-03 19:39 ` Sergey Shtylyov
2023-10-04 5:05 ` Yoshihiro Shimoda
2023-10-10 12:59 ` Behme Dirk (CM/ESO2)
2023-10-12 8:39 ` Yoshihiro Shimoda
2023-10-13 6:04 ` Behme Dirk (CM/ESO2)
2023-10-13 8:32 ` Yoshihiro Shimoda
2023-08-15 10:08 ` Lee Jones
2023-08-29 13:46 ` Lee Jones
2023-08-30 4:30 ` Zheng Hacker
2023-08-31 6:46 ` Zheng Hacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725201952.2f23bb3b@kernel.org \
--to=kuba@kernel.org \
--cc=1395428693sheep@gmail.com \
--cc=alex000young@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=hackerzheng666@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=s.shtylyov@omp.ru \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.