From: Greg KH <gregkh@linuxfoundation.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: krzk@kernel.org, joe@perches.com, geert@linux-m68k.org,
netdev@vger.kernel.org, workflows@vger.kernel.org,
mario.limonciello@amd.com
Subject: Re: [PATCH] scripts: checkpatch: steer people away from using file paths
Date: Tue, 25 Jul 2023 18:53:48 +0200 [thread overview]
Message-ID: <2023072555-stamina-hurray-b95c@gregkh> (raw)
In-Reply-To: <20230725155926.2775416-1-kuba@kernel.org>
On Tue, Jul 25, 2023 at 08:59:26AM -0700, Jakub Kicinski wrote:
> We repeatedly see noobs misuse get_maintainer by running it on
> the file paths rather than the patchfile. This leads to authors
> of changes (quoted commits and commits under Fixes) not getting
> CCed. These are usually the best reviewers!
>
> The file option should really not be used by noobs, unless
> they are just trying to find a maintainer to manually contact.
>
> Print a warning when someone tries to use -f and remove
> the "auto-guessing" of file paths.
>
> This script may break people's "scripts on top of get_maintainer"
> if they are using -f... but that's the point.
Ok, I'll go fix up my local scripts, but you should change your subject
line to say "get_maintainer", not "checkpatch" :)
thanks,
greg k-h
next prev parent reply other threads:[~2023-07-25 16:54 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 6:26 [Enable Designware XGMAC VLAN Stripping Feature 0/2] Boon, Khai, Ng <boon.khai.ng
2023-07-21 6:26 ` Boon, Khai, Ng <boon.khai.ng
2023-07-21 6:26 ` [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload Boon, Khai, Ng <boon.khai.ng
2023-07-21 6:26 ` Boon, Khai, Ng <boon.khai.ng
2023-07-21 10:10 ` Krzysztof Kozlowski
2023-07-21 10:10 ` Krzysztof Kozlowski
2023-07-21 15:28 ` Ng, Boon Khai
2023-07-21 15:28 ` Ng, Boon Khai
2023-07-21 16:21 ` Krzysztof Kozlowski
2023-07-21 16:21 ` Krzysztof Kozlowski
2023-07-21 16:33 ` Ng, Boon Khai
2023-07-21 16:33 ` Ng, Boon Khai
2023-07-22 1:55 ` Jakub Kicinski
2023-07-22 1:55 ` Jakub Kicinski
2023-07-22 3:32 ` Joe Perches
2023-07-22 3:32 ` Joe Perches
2023-07-25 1:04 ` Jakub Kicinski
2023-07-25 3:53 ` Joe Perches
2023-07-25 7:33 ` Geert Uytterhoeven
2023-07-25 13:19 ` Mario Limonciello
2023-07-25 13:43 ` Joe Perches
2023-07-25 14:37 ` Krzysztof Kozlowski
2023-07-25 15:59 ` [PATCH] scripts: checkpatch: steer people away from using file paths Jakub Kicinski
2023-07-25 16:53 ` Greg KH [this message]
2023-07-25 17:10 ` Jakub Kicinski
2023-07-25 17:25 ` Greg KH
2023-07-25 19:52 ` Jakub Kicinski
2023-07-25 21:01 ` Joe Perches
2023-07-25 16:57 ` Krzysztof Kozlowski
2023-07-25 21:18 ` Joe Perches
2023-07-25 22:15 ` Jakub Kicinski
2023-07-26 6:28 ` Joe Perches
2023-07-21 16:26 ` [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload Krzysztof Kozlowski
2023-07-21 16:26 ` Krzysztof Kozlowski
2023-07-21 16:39 ` Ng, Boon Khai
2023-07-21 16:39 ` Ng, Boon Khai
2023-07-21 10:17 ` Shevchenko Andriy
2023-07-21 10:17 ` Shevchenko Andriy
2023-07-21 10:17 ` Shevchenko Andriy
2023-07-21 15:35 ` Ng, Boon Khai
2023-07-21 15:35 ` Ng, Boon Khai
2023-07-21 15:48 ` Shevchenko, Andriy
2023-07-21 15:48 ` Shevchenko, Andriy
2023-07-21 15:51 ` Ng, Boon Khai
2023-07-21 15:51 ` Ng, Boon Khai
2023-07-21 6:26 ` [Enable Designware XGMAC VLAN Stripping Feature 2/2] net: stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping Boon, Khai, Ng <boon.khai.ng
2023-07-21 6:26 ` Boon, Khai, Ng <boon.khai.ng
2023-07-21 10:11 ` Krzysztof Kozlowski
2023-07-21 10:11 ` Krzysztof Kozlowski
2023-07-21 15:30 ` Ng, Boon Khai
2023-07-21 15:30 ` Ng, Boon Khai
2023-07-21 15:59 ` Florian Fainelli
2023-07-21 15:59 ` Florian Fainelli
2023-07-21 16:12 ` Ng, Boon Khai
2023-07-21 16:12 ` Ng, Boon Khai
2023-07-21 16:29 ` Florian Fainelli
2023-07-21 16:29 ` Florian Fainelli
2023-07-21 16:45 ` Ng, Boon Khai
2023-07-21 16:45 ` Ng, Boon Khai
2023-07-21 16:22 ` Krzysztof Kozlowski
2023-07-21 16:22 ` Krzysztof Kozlowski
2023-07-21 16:22 ` Krzysztof Kozlowski
2023-07-21 16:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023072555-stamina-hurray-b95c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=mario.limonciello@amd.com \
--cc=netdev@vger.kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.