Re: [PATCH next resend 2/5] minmax: Allow min()/max()/clamp() if the arguments have the same signedness.

[kernel test robot <lkp@intel.com>]

:::::: 
:::::: Manual check reason: "low confidence static check first_new_problem: drivers/input/mouse/focaltech.c:135:37: sparse: sparse: bad integer constant expression"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <a09512c8526b46759669d0b879144563@AcuMS.aculab.com>
References: <a09512c8526b46759669d0b879144563@AcuMS.aculab.com>
TO: David Laight <David.Laight@ACULAB.COM>
TO: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
TO: "'Andy Shevchenko'" <andriy.shevchenko@linux.intel.com>
TO: "'Andrew Morton'" <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: "'Matthew Wilcox (Oracle)'" <willy@infradead.org>
TO: "'Christoph Hellwig'" <hch@infradead.org>
TO: "'Jason A. Donenfeld'" <Jason@zx2c4.com>

Hi David,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on linus/master crng-random/master v6.5-rc3 next-20230726]
[cannot apply to next-20230725]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Laight/minmax-Allow-min-max-clamp-if-the-arguments-have-the-same-signedness/20230725-204940
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/a09512c8526b46759669d0b879144563%40AcuMS.aculab.com
patch subject: [PATCH next resend 2/5] minmax: Allow min()/max()/clamp() if the arguments have the same signedness.
:::::: branch date: 19 hours ago
:::::: commit date: 19 hours ago
config: x86_64-randconfig-x063-20230726 (https://download.01.org/0day-ci/archive/20230726/202307261503.baQhuiJ2-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230726/202307261503.baQhuiJ2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202307261503.baQhuiJ2-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/input/mouse/focaltech.c:135:37: sparse: sparse: bad integer constant expression
>> drivers/input/mouse/focaltech.c:135:37: sparse: sparse: static assertion failed: "clamp() low limit 0U greater than high limit priv->x_max"
   drivers/input/mouse/focaltech.c:136:37: sparse: sparse: bad integer constant expression
>> drivers/input/mouse/focaltech.c:136:37: sparse: sparse: static assertion failed: "clamp() low limit 0U greater than high limit priv->y_max"
--
>> drivers/thermal/intel/intel_powerclamp.c:704:28: sparse: sparse: bad integer constant expression
>> drivers/thermal/intel/intel_powerclamp.c:704:28: sparse: sparse: static assertion failed: "clamp() low limit 0UL greater than high limit (unsigned long) (max_idle - 1)"
--
>> drivers/net/can/dev/calc_bittiming.c:39:25: sparse: sparse: bad integer constant expression
>> drivers/net/can/dev/calc_bittiming.c:39:25: sparse: sparse: static assertion failed: "clamp() low limit btc->tseg2_min greater than high limit btc->tseg2_max"

vim +135 drivers/input/mouse/focaltech.c

05be1d079ec0b3 Mathias Gottschlag 2014-12-29  114  
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  115  static void focaltech_report_state(struct psmouse *psmouse)
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  116  {
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  117  	struct focaltech_data *priv = psmouse->private;
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  118  	struct focaltech_hw_state *state = &priv->state;
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  119  	struct input_dev *dev = psmouse->dev;
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  120  	int i;
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  121  
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  122  	for (i = 0; i < FOC_MAX_FINGERS; i++) {
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  123  		struct focaltech_finger_state *finger = &state->fingers[i];
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  124  		bool active = finger->active && finger->valid;
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  125  
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  126  		input_mt_slot(dev, i);
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  127  		input_mt_report_slot_state(dev, MT_TOOL_FINGER, active);
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  128  		if (active) {
679d83ea939063 Mathias Gottschlag 2015-03-07  129  			unsigned int clamped_x, clamped_y;
679d83ea939063 Mathias Gottschlag 2015-03-07  130  			/*
679d83ea939063 Mathias Gottschlag 2015-03-07  131  			 * The touchpad might report invalid data, so we clamp
679d83ea939063 Mathias Gottschlag 2015-03-07  132  			 * the resulting values so that we do not confuse
679d83ea939063 Mathias Gottschlag 2015-03-07  133  			 * userspace.
679d83ea939063 Mathias Gottschlag 2015-03-07  134  			 */
679d83ea939063 Mathias Gottschlag 2015-03-07 @135  			clamped_x = clamp(finger->x, 0U, priv->x_max);
679d83ea939063 Mathias Gottschlag 2015-03-07 @136  			clamped_y = clamp(finger->y, 0U, priv->y_max);
679d83ea939063 Mathias Gottschlag 2015-03-07  137  			input_report_abs(dev, ABS_MT_POSITION_X, clamped_x);
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  138  			input_report_abs(dev, ABS_MT_POSITION_Y,
679d83ea939063 Mathias Gottschlag 2015-03-07  139  					 priv->y_max - clamped_y);
85919a00e55f90 Dmitry Tunin       2015-05-31  140  			input_report_abs(dev, ABS_TOOL_WIDTH, state->width);
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  141  		}
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  142  	}
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  143  	input_mt_report_pointer_emulation(dev, true);
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  144  
324ae0958cab5c Dmitry Tunin       2016-10-24  145  	input_report_key(dev, BTN_LEFT, state->pressed);
324ae0958cab5c Dmitry Tunin       2016-10-24  146  	input_sync(dev);
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  147  }
05be1d079ec0b3 Mathias Gottschlag 2014-12-29  148  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki