From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1qOlem-0000v6-5Y for mharc-grub-devel@gnu.org; Wed, 26 Jul 2023 17:02:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOlel-0000ur-C1 for grub-devel@gnu.org; Wed, 26 Jul 2023 17:02:51 -0400 Received: from mail-ua1-x933.google.com ([2607:f8b0:4864:20::933]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOlej-0004R4-Oj for grub-devel@gnu.org; Wed, 26 Jul 2023 17:02:51 -0400 Received: by mail-ua1-x933.google.com with SMTP id a1e0cc1a2514c-794c5f60479so119891241.3 for ; Wed, 26 Jul 2023 14:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20221208.gappssmtp.com; s=20221208; t=1690405368; x=1691010168; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HmbE05hi+b34qrhtaPpGE1OxIzw4EZ1WiX7PgW29xiU=; b=bqiv8Cw1Re2VOTwSGXREEeuJBObNneetORfqjdI0iQHoO0cyrmjd4d9VZVByPySFqr oaASuoEC748iM+aP5KLK1mT0zfI7SX4EVEYYiA3GLMnlF4dDTeXszfpVTBd9sRd9YA0J Dckpvd1ZVAOpLoZn9y98ti2Q45MBLXsl8CP9swGpEutM2k+G7p9uauYoHjO4C8aYDZRJ WMDYrk9wolfp7Yka5juMpAN/MqcygP8VNWnpjooPMBvC4OV+S+cEgtZxDN+WlhYYXove 2lhPfQgKJdeQ6FLSRhX0613KsNaBQEWn8zz7/5gaILCe3FyLn7GVH1AkaNWECZ6CSsoy WVZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690405368; x=1691010168; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HmbE05hi+b34qrhtaPpGE1OxIzw4EZ1WiX7PgW29xiU=; b=avUK/L6MFmYD/oXbc/rBc8jLyyMbiOnc5nQp9VNfBKiigetBZQR69l/W6x3PkgxIpu HzGEEQRgjTHFt6+6yVkKkZSEuHFW8HTQZS0gQjS+2P+9aisJJAmi1ldr4x2pU7ARCNev bph6hjOVpuIc6KUYckIoSoa2ih2uFKBmjAlg3Zohkp9SiCr52euYhQhb4ympL7bJR3rl 8jawnZI4MzDVbJwfwy+D/X9Vi76U+5GVGqbae8X51+vp0JiYeSUWekaWRI/HJz9usQQX CNLEAcyN6u0qth6zUPyh0V5zt1jHd7lz4pcGHCxZowp80nhvc+owOlUwSI48pFGra5x+ l+vg== X-Gm-Message-State: ABy/qLa9wnjOK7o/YJHQY6HxscyfGY101KdRmZ1pAOOKt5xEPz3gku/H PkQn64sWEDmWOqM/9QJ3QKy8GRaAUvS22Qp0fMY= X-Google-Smtp-Source: APBJJlECh7MbS85YN5NLgeBO3pIMlvuGrZ7j7wouHbJrYqRcg0baYcb0eUn2vUUw1/Xq7GiZssqKPg== X-Received: by 2002:a67:fb17:0:b0:447:55e6:15e7 with SMTP id d23-20020a67fb17000000b0044755e615e7mr201458vsr.11.1690405367855; Wed, 26 Jul 2023 14:02:47 -0700 (PDT) Received: from localhost.localdomain ([37.218.244.249]) by smtp.gmail.com with ESMTPSA id b13-20020a67b20d000000b00426768819d4sm2575734vsf.3.2023.07.26.14.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 14:02:46 -0700 (PDT) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Benjamin Herrenschmidt , Glenn Washburn Subject: [PATCH] term/serial: Continue processing SPCR table even if revision is < 2 Date: Wed, 26 Jul 2023 16:02:36 -0500 Message-Id: <20230726210236.1393757-1-development@efficientek.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::933; envelope-from=development@efficientek.com; helo=mail-ua1-x933.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jul 2023 21:02:51 -0000 According to commit 0231d00082 ("ACPI: SPCR: Make SPCR available to x86") to the Linux kernel, "On x86, many systems have a valid SPCR table but the table version is not 2 so the table version check must be a warning." Signed-off-by: Glenn Washburn --- grub-core/term/ns8250-spcr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/grub-core/term/ns8250-spcr.c b/grub-core/term/ns8250-spcr.c index d101bffb512d..d52b52c26561 100644 --- a/grub-core/term/ns8250-spcr.c +++ b/grub-core/term/ns8250-spcr.c @@ -18,6 +18,7 @@ #if !defined(GRUB_MACHINE_IEEE1275) && !defined(GRUB_MACHINE_QEMU) +#include #include #include #include @@ -34,7 +35,8 @@ grub_ns8250_spcr_init (void) if (spcr == NULL) return NULL; if (spcr->hdr.revision < 2) - return NULL; + grub_dprintf ("serial", "SPCR table revision %d < 2, continuing anyway\n", + (int) spcr->hdr.revision); if (spcr->intf_type != GRUB_ACPI_SPCR_INTF_TYPE_16550 && spcr->intf_type != GRUB_ACPI_SPCR_INTF_TYPE_16550X) return NULL; -- 2.34.1