From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7C96EB64DD for ; Thu, 27 Jul 2023 06:10:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 51A3041F28; Thu, 27 Jul 2023 06:10:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 51A3041F28 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cULvxet3 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G2VIDupj5mEI; Thu, 27 Jul 2023 06:10:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 103C441F32; Thu, 27 Jul 2023 06:10:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 103C441F32 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D97CDC0072; Thu, 27 Jul 2023 06:10:40 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9AE9AC0032 for ; Thu, 27 Jul 2023 06:10:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 67987417BD for ; Thu, 27 Jul 2023 06:10:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 67987417BD Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cULvxet3 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o-AGFfClrS93 for ; Thu, 27 Jul 2023 06:10:38 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 00EF4401A1 for ; Thu, 27 Jul 2023 06:10:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 00EF4401A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690438236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Md4SRid1hDg9nGCkfKo1X89jQCVvHHyaEAACgzafNkc=; b=cULvxet3r1ESEMfE7B7XX56gmtmHKmF+AYa0LojDENOTBPdoU2a68+UCJNfXlvn+otTaI5 xOghi9BT+TY5G9hBqYBharCSfkcK7KCdepDx5iaJMwKox2cluZwMUul+ogQZBRJhcy/gaA 0XOXrPt0XY50GWGWztrsETOYO3RryZ4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-GoIH5700Pg-sU4LK-GjffA-1; Thu, 27 Jul 2023 02:10:33 -0400 X-MC-Unique: GoIH5700Pg-sU4LK-GjffA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fd2e59bc53so3030115e9.1 for ; Wed, 26 Jul 2023 23:10:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690438232; x=1691043032; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Md4SRid1hDg9nGCkfKo1X89jQCVvHHyaEAACgzafNkc=; b=UnhCVW55t8uVofA4p+j4xidlbSSHaHo/LVkvA/b5wPWEJ1KtsBdI1xFQRjEic1YXSn PlQBw4z8TVhp2cXo6FYnDmhgbSlOOx0AwPjsdaPp+uqk6FQj1T8yMuCwVH4EYXiOlaVW PJu521F6sfME98N+CHvulULMQsjTiZAc39iXCTJOxVW6GmJvJGEqcTugxoPrm+GFQH24 wJuiltDdSV7ysVS052sto177XkwjTZAyQW/4du24aGFT9E39ICtiokbmmkhDLBK8XE6i bRXsq++JJPpZVTuSuqPf1oGPeywEG+0qL4QAJtwWrJ6cjcP7ULvN8YxFRNYFWW3gCFjd lZYg== X-Gm-Message-State: ABy/qLZDIteEU1LQ+WocTWJKzgQWK47ZFrzgEXpL8wYGPBI0pFNgK1ZX AgVf/mX9qCoS0Do5L3AKVfCukkJMEcHiBVpLyHyxCJee9YzH5crrMENnbh9DkWC3dF1kAxDeajB BRWtsHMQDUItYfp9e6LikKY55eZWEH2ZJnmH5dBUpWA== X-Received: by 2002:a1c:4c0f:0:b0:3fd:2f8e:2c69 with SMTP id z15-20020a1c4c0f000000b003fd2f8e2c69mr833441wmf.32.1690438232198; Wed, 26 Jul 2023 23:10:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlEWUV7J6CiJBzfD+xPifRyv8cgXYmKJozN4Bl5HrvqQlHyOWlIxZSJGr1lK4NMKNUKNcejm0Q== X-Received: by 2002:a1c:4c0f:0:b0:3fd:2f8e:2c69 with SMTP id z15-20020a1c4c0f000000b003fd2f8e2c69mr833433wmf.32.1690438231845; Wed, 26 Jul 2023 23:10:31 -0700 (PDT) Received: from redhat.com ([31.187.78.131]) by smtp.gmail.com with ESMTPSA id l23-20020a7bc457000000b003fc02219081sm880016wmi.33.2023.07.26.23.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 23:10:31 -0700 (PDT) Date: Thu, 27 Jul 2023 02:10:26 -0400 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop Message-ID: <20230727020930-mutt-send-email-mst@kernel.org> References: <6278a4aa-8901-b0e3-342f-5753a4bf32af@redhat.com> <20230721110925-mutt-send-email-mst@kernel.org> <20230724025720-mutt-send-email-mst@kernel.org> <20230725033506-mutt-send-email-mst@kernel.org> <20230726073453-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: xuanzhuo@linux.alibaba.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Maxime Coquelin , kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gVGh1LCBKdWwgMjcsIDIwMjMgYXQgMDI6MDM6NTlQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiBPbiBXZWQsIEp1bCAyNiwgMjAyMyBhdCA3OjM44oCvUE0gTWljaGFlbCBTLiBUc2lya2lu IDxtc3RAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gV2VkLCBKdWwgMjYsIDIwMjMgYXQg MDk6NTU6MzdBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90ZToKPiA+ID4gT24gVHVlLCBKdWwgMjUs IDIwMjMgYXQgMzozNuKAr1BNIE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+IHdy b3RlOgo+ID4gPiA+Cj4gPiA+ID4gT24gVHVlLCBKdWwgMjUsIDIwMjMgYXQgMTE6MDc6NDBBTSAr MDgwMCwgSmFzb24gV2FuZyB3cm90ZToKPiA+ID4gPiA+IE9uIE1vbiwgSnVsIDI0LCAyMDIzIGF0 IDM6MTfigK9QTSBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEByZWRoYXQuY29tPiB3cm90ZToKPiA+ ID4gPiA+ID4KPiA+ID4gPiA+ID4gT24gTW9uLCBKdWwgMjQsIDIwMjMgYXQgMDI6NTI6MDVQTSAr MDgwMCwgSmFzb24gV2FuZyB3cm90ZToKPiA+ID4gPiA+ID4gPiBPbiBTYXQsIEp1bCAyMiwgMjAy MyBhdCA0OjE44oCvQU0gTWF4aW1lIENvcXVlbGluCj4gPiA+ID4gPiA+ID4gPG1heGltZS5jb3F1 ZWxpbkByZWRoYXQuY29tPiB3cm90ZToKPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPgo+ ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+IE9uIDcvMjEvMjMgMTc6MTAsIE1pY2hhZWwg Uy4gVHNpcmtpbiB3cm90ZToKPiA+ID4gPiA+ID4gPiA+ID4gT24gRnJpLCBKdWwgMjEsIDIwMjMg YXQgMDQ6NTg6MDRQTSArMDIwMCwgTWF4aW1lIENvcXVlbGluIHdyb3RlOgo+ID4gPiA+ID4gPiA+ ID4gPj4KPiA+ID4gPiA+ID4gPiA+ID4+Cj4gPiA+ID4gPiA+ID4gPiA+PiBPbiA3LzIxLzIzIDE2 OjQ1LCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4gPiA+ID4gPiA+ID4gPiA+Pj4gT24gRnJp LCBKdWwgMjEsIDIwMjMgYXQgMDQ6Mzc6MDBQTSArMDIwMCwgTWF4aW1lIENvcXVlbGluIHdyb3Rl Ogo+ID4gPiA+ID4gPiA+ID4gPj4+Pgo+ID4gPiA+ID4gPiA+ID4gPj4+Pgo+ID4gPiA+ID4gPiA+ ID4gPj4+PiBPbiA3LzIwLzIzIDIzOjAyLCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4gPiA+ ID4gPiA+ID4gPiA+Pj4+PiBPbiBUaHUsIEp1bCAyMCwgMjAyMyBhdCAwMToyNjoyMFBNIC0wNzAw LCBTaGFubm9uIE5lbHNvbiB3cm90ZToKPiA+ID4gPiA+ID4gPiA+ID4+Pj4+PiBPbiA3LzIwLzIz IDE6MzggQU0sIEphc29uIFdhbmcgd3JvdGU6Cj4gPiA+ID4gPiA+ID4gPiA+Pj4+Pj4+Cj4gPiA+ ID4gPiA+ID4gPiA+Pj4+Pj4+IEFkZGluZyBjb25kX3Jlc2NoZWQoKSB0byB0aGUgY29tbWFuZCB3 YWl0aW5nIGxvb3AgZm9yIGEgYmV0dGVyCj4gPiA+ID4gPiA+ID4gPiA+Pj4+Pj4+IGNvLW9wZXJh dGlvbiB3aXRoIHRoZSBzY2hlZHVsZXIuIFRoaXMgYWxsb3dzIHRvIGdpdmUgQ1BVIGEgYnJlYXRo IHRvCj4gPiA+ID4gPiA+ID4gPiA+Pj4+Pj4+IHJ1biBvdGhlciB0YXNrKHdvcmtxdWV1ZSkgaW5z dGVhZCBvZiBidXN5IGxvb3Bpbmcgd2hlbiBwcmVlbXB0aW9uIGlzCj4gPiA+ID4gPiA+ID4gPiA+ Pj4+Pj4+IG5vdCBhbGxvd2VkIG9uIGEgZGV2aWNlIHdob3NlIENWUSBtaWdodCBiZSBzbG93Lgo+ ID4gPiA+ID4gPiA+ID4gPj4+Pj4+Pgo+ID4gPiA+ID4gPiA+ID4gPj4+Pj4+PiBTaWduZWQtb2Zm LWJ5OiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPgo+ID4gPiA+ID4gPiA+ID4gPj4+ Pj4+Cj4gPiA+ID4gPiA+ID4gPiA+Pj4+Pj4gVGhpcyBzdGlsbCBsZWF2ZXMgaHVuZyBwcm9jZXNz ZXMsIGJ1dCBhdCBsZWFzdCBpdCBkb2Vzbid0IHBpbiB0aGUgQ1BVIGFueQo+ID4gPiA+ID4gPiA+ ID4gPj4+Pj4+IG1vcmUuICBUaGFua3MuCj4gPiA+ID4gPiA+ID4gPiA+Pj4+Pj4gUmV2aWV3ZWQt Ynk6IFNoYW5ub24gTmVsc29uIDxzaGFubm9uLm5lbHNvbkBhbWQuY29tPgo+ID4gPiA+ID4gPiA+ ID4gPj4+Pj4+Cj4gPiA+ID4gPiA+ID4gPiA+Pj4+Pgo+ID4gPiA+ID4gPiA+ID4gPj4+Pj4gSSdk IGxpa2UgdG8gc2VlIGEgZnVsbCBzb2x1dGlvbgo+ID4gPiA+ID4gPiA+ID4gPj4+Pj4gMS0gYmxv Y2sgdW50aWwgaW50ZXJydXB0Cj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBJIHJlbWVtYmVy IGluIHByZXZpb3VzIHZlcnNpb25zLCB5b3Ugd29ycmllZCBhYm91dCB0aGUgZXh0cmEgTVNJCj4g PiA+ID4gPiA+ID4gdmVjdG9yLiAoTWF5YmUgSSB3YXMgd3JvbmcpLgo+ID4gPiA+ID4gPiA+Cj4g PiA+ID4gPiA+ID4gPiA+Pj4+Cj4gPiA+ID4gPiA+ID4gPiA+Pj4+IFdvdWxkIGl0IG1ha2Ugc2Vu c2UgdG8gYWxzbyBoYXZlIGEgdGltZW91dD8KPiA+ID4gPiA+ID4gPiA+ID4+Pj4gQW5kIHdoZW4g dGltZW91dCBleHBpcmVzLCBzZXQgRkFJTEVEIGJpdCBpbiBkZXZpY2Ugc3RhdHVzPwo+ID4gPiA+ ID4gPiA+ID4gPj4+Cj4gPiA+ID4gPiA+ID4gPiA+Pj4gdmlydGlvIHNwZWMgZG9lcyBub3Qgc2V0 IGFueSBsaW1pdHMgb24gdGhlIHRpbWluZyBvZiB2cQo+ID4gPiA+ID4gPiA+ID4gPj4+IHByb2Nl c3NpbmcuCj4gPiA+ID4gPiA+ID4gPiA+Pgo+ID4gPiA+ID4gPiA+ID4gPj4gSW5kZWVkLCBidXQg SSB0aG91Z2h0IHRoZSBkcml2ZXIgY291bGQgZGVjaWRlIGl0IGlzIHRvbyBsb25nIGZvciBpdC4K PiA+ID4gPiA+ID4gPiA+ID4+Cj4gPiA+ID4gPiA+ID4gPiA+PiBUaGUgaXNzdWUgaXMgd2Uga2Vl cCB3YWl0aW5nIHdpdGggcnRubCBsb2NrZWQsIGl0IGNhbiBxdWlja2x5IG1ha2UgdGhlCj4gPiA+ ID4gPiA+ID4gPiA+PiBzeXN0ZW0gdW51c2FibGUuCj4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4g PiA+ID4gPiA+IGlmIHRoaXMgaXMgYSBwcm9ibGVtIHdlIHNob3VsZCBmaW5kIGEgd2F5IG5vdCB0 byBrZWVwIHJ0bmwKPiA+ID4gPiA+ID4gPiA+ID4gbG9ja2VkIGluZGVmaW5pdGVseS4KPiA+ID4g PiA+ID4gPgo+ID4gPiA+ID4gPiA+IEFueSBpZGVhcyBvbiB0aGlzIGRpcmVjdGlvbj8gU2ltcGx5 IGRyb3BwaW5nIHJ0bmwgZHVyaW5nIHRoZSBidXN5IGxvb3AKPiA+ID4gPiA+ID4gPiB3aWxsIHJl c3VsdCBpbiBhIGxvdCBvZiByYWNlcy4gVGhpcyBzZWVtcyB0byByZXF1aXJlIG5vbi10cml2aWFs Cj4gPiA+ID4gPiA+ID4gY2hhbmdlcyBpbiB0aGUgbmV0d29ya2luZyBjb3JlLgo+ID4gPiA+ID4g PiA+Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gIEZyb20gdGhlIHRlc3RzIEkgaGF2 ZSBkb25lLCBJIHRoaW5rIGl0IGlzLiBXaXRoIE9WUywgYSByZWNvbmZpZ3VyYXRpb24KPiA+ID4g PiA+ID4gPiA+IGlzIHBlcmZvcm1lZCB3aGVuIHRoZSBWRFVTRSBkZXZpY2UgaXMgYWRkZWQsIGFu ZCB3aGVuIGEgTUxYNSBkZXZpY2UgaXMKPiA+ID4gPiA+ID4gPiA+IGluIHRoZSBzYW1lIGJyaWRn ZSwgaXQgZW5kcyB1cCBkb2luZyBhbiBpb2N0bCgpIHRoYXQgdHJpZXMgdG8gdGFrZSB0aGUKPiA+ ID4gPiA+ID4gPiA+IHJ0bmwgbG9jay4gSW4gdGhpcyBjb25maWd1cmF0aW9uLCBpdCBpcyBub3Qg cG9zc2libGUgdG8ga2lsbCBPVlMgYmVjYXVzZQo+ID4gPiA+ID4gPiA+ID4gaXQgaXMgc3R1Y2sg dHJ5aW5nIHRvIGFjcXVpcmUgcnRubCBsb2NrIGZvciBtbHg1IHRoYXQgaXMgaGVsZCBieSB2aXJ0 aW8tCj4gPiA+ID4gPiA+ID4gPiBuZXQuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBZZWFo LCBiYXNpY2FsbHksIGFueSBSVE5MIHVzZXJzIHdvdWxkIGJlIGJsb2NrZWQgZm9yZXZlci4KPiA+ ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IEFuZCB0aGUgaW5maW5pdGUgbG9vcCBoYXMgb3RoZXIg c2lkZSBlZmZlY3RzIGxpa2UgaXQgYmxvY2tzIHRoZSBmcmVlemVyIHRvIHdvcmsuCj4gPiA+ID4g PiA+ID4KPiA+ID4gPiA+ID4gPiBUbyBzdW1tYXJpemUsIHRoZXJlIGFyZSB0aHJlZSBpc3N1ZXMK PiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IDEpIGJ1c3kgcG9sbGluZwo+ID4gPiA+ID4gPiA+ IDIpIGJyZWFrcyBmcmVlemVyCj4gPiA+ID4gPiA+ID4gMykgaG9sZCBSVE5MIGR1cmluZyB0aGUg bG9vcAo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gU29sdmluZyAzIG1heSBoZWxwIHNvbWVo b3cgZm9yIDIgZS5nIHNvbWUgcG0gcm91dGluZSBlLmcgd2lyZWd1YXJkIG9yCj4gPiA+ID4gPiA+ ID4gZXZlbiB2aXJ0bmV0X3Jlc3RvcmUoKSBpdHNlbGYgbWF5IHRyeSB0byBob2xkIHRoZSBsb2Nr Lgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBZZXAuIFNvIG15IGZlZWxpbmcgY3VycmVudGx5IGlz LCB0aGUgb25seSByZWFsIGZpeCBpcyB0byBhY3R1YWxseQo+ID4gPiA+ID4gPiBxdWV1ZSB1cCB0 aGUgd29yayBpbiBzb2Z0d2FyZS4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBEbyB5b3UgbWVhbiBzb21l dGhpbmcgbGlrZToKPiA+ID4gPiA+Cj4gPiA+ID4gPiBydG5sX2xvY2soKTsKPiA+ID4gPiA+IHF1 ZXVlIHVwIHRoZSB3b3JrCj4gPiA+ID4gPiBydG5sX3VubG9jaygpOwo+ID4gPiA+ID4gcmV0dXJu IHN1Y2Nlc3M7Cj4gPiA+ID4gPgo+ID4gPiA+ID4gPwo+ID4gPiA+Cj4gPiA+ID4geWVzCj4gPiA+ Cj4gPiA+IFdlIHdpbGwgbG9zZSB0aGUgZXJyb3IgcmVwb3J0aW5nLCBpcyBpdCBhIHJlYWwgcHJv YmxlbSBvciBub3Q/Cj4gPgo+ID4gRnVuZGFtZW50YWwgaXNuJ3QgaXQ/IE1heWJlIHdlIHdhbnQg YSBwZXItZGV2aWNlIGZsYWcgZm9yIGEgYXN5bmNoIGNvbW1hbmRzLAo+ID4gYW5kIHZkdXNlIHdp bGwgc2V0IGl0IHdoaWxlIGhhcmR3YXJlIHZpcnRpbyB3b24ndC4KPiA+IHRoaXMgd2F5IHdlIG9u bHkgbG9zZSBlcnJvciByZXBvcnRpbmcgZm9yIHZkdXNlLgo+IAo+IFRoaXMgcHJvYmxlbSBpcyBu b3QgVkRVU0Ugc3BlY2lmaWMsIERQVXMvdkRQQSBtYXkgc3VmZmVyIGZyb20gdGhpcyBhcwo+IHdl bGwuIFRoaXMgbWlnaHQgcmVxdWlyZSBtb3JlIHRob3VnaHRzLgo+IAo+IFRoYW5rcwoKVGhleSBy ZWFsbHkgc2hvdWxkbid0IC0gYW55IE5JQyB0aGF0IHRha2VzIGZvcmV2ZXIgdG8KcHJvZ3JhbSB3 aWxsIGNyZWF0ZSBpc3N1ZXMgaW4gdGhlIG5ldHdvcmtpbmcgc3RhY2suCkJ1dCBpZiB0aGV5IGRv IHRoZXkgY2FuIGFsd2F5cyBzZXQgdGhpcyBmbGFnIHRvby4KCj4gPgo+ID4gPiA+Cj4gPiA+ID4K PiA+ID4gPiA+ID4gSXQncyBtb3N0bHkgdHJpdmlhbCB0byBsaW1pdAo+ID4gPiA+ID4gPiBtZW1v cnkgY29uc3VtcHRpb24sIHZpZCdzIGlzIHRoZQo+ID4gPiA+ID4gPiBvbmx5IG9uZSB3aGVyZSBp dCB3b3VsZCBtYWtlIHNlbnNlIHRvIGhhdmUgbW9yZSB0aGFuCj4gPiA+ID4gPiA+IDEgY29tbWFu ZCBvZiBhIGdpdmVuIHR5cGUgb3V0c3RhbmRpbmcuCj4gPiA+ID4gPgo+ID4gPiA+ID4gQW5kIHJ4 IG1vZGUgc28gdGhpcyBpbXBsaWVzIHdlIHdpbGwgZmFpbCBhbnkgY29tbWFuZCBpZiB0aGUgcHJl dmlvdXMKPiA+ID4gPiA+IHdvcmsgaXMgbm90IGZpbmlzaGVkLgo+ID4gPiA+Cj4gPiA+ID4gZG9u J3QgZmFpbCBpdCwgc3RvcmUgaXQuCj4gPiA+Cj4gPiA+IE9rLgo+ID4gPgo+ID4gPiBUaGFua3MK PiA+ID4KPiA+ID4gPgo+ID4gPiA+ID4gPiBoYXZlIGEgdHJlZQo+ID4gPiA+ID4gPiBvciBhIGJp dG1hcCB3aXRoIHZpZHMgdG8gYWRkL3JlbW92ZT8KPiA+ID4gPiA+Cj4gPiA+ID4gPiBQcm9iYWJs eS4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBUaGFua3MKPiA+ID4gPiA+Cj4gPiA+ID4gPiA+Cj4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPgo+ID4g PiA+ID4gPiA+ID4gPj4+Pj4gMi0gc3RpbGwgaGFuZGxlIHN1cnByaXNlIHJlbW92YWwgY29ycmVj dGx5IGJ5IHdha2luZyBpbiB0aGF0IGNhc2UKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IFRo aXMgaXMgYmFzaWNhbGx5IHdoYXQgdmVyc2lvbiAxIGRpZD8KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ ID4gPiA+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwvNjAyNmU4MDEtNmZkYS1mZWU5LWE2 OWItZDA2YTgwMzY4NjIxQHJlZGhhdC5jb20vdC8KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ IFRoYW5rcwo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBZZXMgLSBleGNlcHQgdGhlIHRpbWVvdXQg cGFydC4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4+Pj4+Cj4gPiA+ ID4gPiA+ID4gPiA+Pj4+Pgo+ID4gPiA+ID4gPiA+ID4gPj4+Pj4KPiA+ID4gPiA+ID4gPiA+ID4+ Pj4+Pj4gLS0tCj4gPiA+ID4gPiA+ID4gPiA+Pj4+Pj4+ICAgICAgZHJpdmVycy9uZXQvdmlydGlv X25ldC5jIHwgNCArKystCj4gPiA+ID4gPiA+ID4gPiA+Pj4+Pj4+ICAgICAgMSBmaWxlIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gPiA+ID4gPiA+ID4gPj4+Pj4+ Pgo+ID4gPiA+ID4gPiA+ID4gPj4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvdmlydGlv X25ldC5jIGIvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jCj4gPiA+ID4gPiA+ID4gPiA+Pj4+Pj4+ IGluZGV4IDlmM2IxZDZhYzMzZC4uZTc1MzNmMjliMjE5IDEwMDY0NAo+ID4gPiA+ID4gPiA+ID4g Pj4+Pj4+PiAtLS0gYS9kcml2ZXJzL25ldC92aXJ0aW9fbmV0LmMKPiA+ID4gPiA+ID4gPiA+ID4+ Pj4+Pj4gKysrIGIvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jCj4gPiA+ID4gPiA+ID4gPiA+Pj4+ Pj4+IEBAIC0yMzE0LDggKzIzMTQsMTAgQEAgc3RhdGljIGJvb2wgdmlydG5ldF9zZW5kX2NvbW1h bmQoc3RydWN0IHZpcnRuZXRfaW5mbyAqdmksIHU4IGNsYXNzLCB1OCBjbWQsCj4gPiA+ID4gPiA+ ID4gPiA+Pj4+Pj4+ICAgICAgICAgICAgICAqIGludG8gdGhlIGh5cGVydmlzb3IsIHNvIHRoZSBy ZXF1ZXN0IHNob3VsZCBiZSBoYW5kbGVkIGltbWVkaWF0ZWx5Lgo+ID4gPiA+ID4gPiA+ID4gPj4+ Pj4+PiAgICAgICAgICAgICAgKi8KPiA+ID4gPiA+ID4gPiA+ID4+Pj4+Pj4gICAgICAgICAgICAg d2hpbGUgKCF2aXJ0cXVldWVfZ2V0X2J1Zih2aS0+Y3ZxLCAmdG1wKSAmJgo+ID4gPiA+ID4gPiA+ ID4gPj4+Pj4+PiAtICAgICAgICAgICAgICAhdmlydHF1ZXVlX2lzX2Jyb2tlbih2aS0+Y3ZxKSkK PiA+ID4gPiA+ID4gPiA+ID4+Pj4+Pj4gKyAgICAgICAgICAgICAgIXZpcnRxdWV1ZV9pc19icm9r ZW4odmktPmN2cSkpIHsKPiA+ID4gPiA+ID4gPiA+ID4+Pj4+Pj4gKyAgICAgICAgICAgICAgIGNv bmRfcmVzY2hlZCgpOwo+ID4gPiA+ID4gPiA+ID4gPj4+Pj4+PiAgICAgICAgICAgICAgICAgICAg IGNwdV9yZWxheCgpOwo+ID4gPiA+ID4gPiA+ID4gPj4+Pj4+PiArICAgICAgIH0KPiA+ID4gPiA+ ID4gPiA+ID4+Pj4+Pj4KPiA+ID4gPiA+ID4gPiA+ID4+Pj4+Pj4gICAgICAgICAgICAgcmV0dXJu IHZpLT5jdHJsLT5zdGF0dXMgPT0gVklSVElPX05FVF9PSzsKPiA+ID4gPiA+ID4gPiA+ID4+Pj4+ Pj4gICAgICB9Cj4gPiA+ID4gPiA+ID4gPiA+Pj4+Pj4+IC0tCj4gPiA+ID4gPiA+ID4gPiA+Pj4+ Pj4+IDIuMzkuMwo+ID4gPiA+ID4gPiA+ID4gPj4+Pj4+Pgo+ID4gPiA+ID4gPiA+ID4gPj4+Pj4+ PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gPiA+ ID4gPiA+ID4gPj4+Pj4+PiBWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKPiA+ID4gPiA+ID4g PiA+ID4+Pj4+Pj4gVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKPiA+ ID4gPiA+ID4gPiA+ID4+Pj4+Pj4gaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21h aWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24KPiA+ID4gPiA+ID4gPiA+ID4+Pj4+Cj4gPiA+ ID4gPiA+ID4gPiA+Pj4KPiA+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4g PiA+Cj4gPiA+ID4KPiA+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMu bGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21h aWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B4C9C0015E for ; Thu, 27 Jul 2023 06:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232438AbjG0GLe (ORCPT ); Thu, 27 Jul 2023 02:11:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231295AbjG0GLc (ORCPT ); Thu, 27 Jul 2023 02:11:32 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B55051710 for ; Wed, 26 Jul 2023 23:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690438236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Md4SRid1hDg9nGCkfKo1X89jQCVvHHyaEAACgzafNkc=; b=cULvxet3r1ESEMfE7B7XX56gmtmHKmF+AYa0LojDENOTBPdoU2a68+UCJNfXlvn+otTaI5 xOghi9BT+TY5G9hBqYBharCSfkcK7KCdepDx5iaJMwKox2cluZwMUul+ogQZBRJhcy/gaA 0XOXrPt0XY50GWGWztrsETOYO3RryZ4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-e7TzbC5iPiKJuFNfbvr-4w-1; Thu, 27 Jul 2023 02:10:33 -0400 X-MC-Unique: e7TzbC5iPiKJuFNfbvr-4w-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fd2e59bc53so3030145e9.1 for ; Wed, 26 Jul 2023 23:10:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690438232; x=1691043032; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Md4SRid1hDg9nGCkfKo1X89jQCVvHHyaEAACgzafNkc=; b=V4QzRJmUimLY1iq9siXdEYg7NfIHUy0joM4Yv6avoRgwLFe9RJdDjSmOGLppjBcr5t reZmZr1SYjeQv19pGimWfXAnCsU8+MkqCEGPld3thDGuWY7/HTySHKV5I1OnBJ6K3kYc 3/hvoveSE0iohtZ6eHNxtOmCHkrHbamWuuvqmaJKSsC8n23fRyudi395FkXYmNTm6dbS Wnpc4Rxup+WGGvuHiE1hNOyA/IRModo+ngTjO4Tw1+gEE2WlloyF7kXQsUt8nX+U0Vbp 3+2vaX/qaz4PcVY4mhQah6aEfGFORlWctYT/OK8MibwtI+B/e2BOLN8lc2To0qooy7hB 1rgQ== X-Gm-Message-State: ABy/qLYyNh/McG0gL08ir5zPtxSuHyjtzGVktcIXiQNNqVi6TwlTibOf Koazb7dOhvAlzkPODlOMIB+YAzlmc3+i9OL2qzB9KjpcNiY19/qcPvcrb5uOl30g4Rx04BKnuVY Q02SjZWv8zOLuK3fkYM47dE83SEt9LgLa X-Received: by 2002:a1c:4c0f:0:b0:3fd:2f8e:2c69 with SMTP id z15-20020a1c4c0f000000b003fd2f8e2c69mr833444wmf.32.1690438232198; Wed, 26 Jul 2023 23:10:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlEWUV7J6CiJBzfD+xPifRyv8cgXYmKJozN4Bl5HrvqQlHyOWlIxZSJGr1lK4NMKNUKNcejm0Q== X-Received: by 2002:a1c:4c0f:0:b0:3fd:2f8e:2c69 with SMTP id z15-20020a1c4c0f000000b003fd2f8e2c69mr833433wmf.32.1690438231845; Wed, 26 Jul 2023 23:10:31 -0700 (PDT) Received: from redhat.com ([31.187.78.131]) by smtp.gmail.com with ESMTPSA id l23-20020a7bc457000000b003fc02219081sm880016wmi.33.2023.07.26.23.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 23:10:31 -0700 (PDT) Date: Thu, 27 Jul 2023 02:10:26 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: Maxime Coquelin , Shannon Nelson , xuanzhuo@linux.alibaba.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net Subject: Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop Message-ID: <20230727020930-mutt-send-email-mst@kernel.org> References: <6278a4aa-8901-b0e3-342f-5753a4bf32af@redhat.com> <20230721110925-mutt-send-email-mst@kernel.org> <20230724025720-mutt-send-email-mst@kernel.org> <20230725033506-mutt-send-email-mst@kernel.org> <20230726073453-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 27, 2023 at 02:03:59PM +0800, Jason Wang wrote: > On Wed, Jul 26, 2023 at 7:38 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 26, 2023 at 09:55:37AM +0800, Jason Wang wrote: > > > On Tue, Jul 25, 2023 at 3:36 PM Michael S. Tsirkin wrote: > > > > > > > > On Tue, Jul 25, 2023 at 11:07:40AM +0800, Jason Wang wrote: > > > > > On Mon, Jul 24, 2023 at 3:17 PM Michael S. Tsirkin wrote: > > > > > > > > > > > > On Mon, Jul 24, 2023 at 02:52:05PM +0800, Jason Wang wrote: > > > > > > > On Sat, Jul 22, 2023 at 4:18 AM Maxime Coquelin > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 7/21/23 17:10, Michael S. Tsirkin wrote: > > > > > > > > > On Fri, Jul 21, 2023 at 04:58:04PM +0200, Maxime Coquelin wrote: > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> On 7/21/23 16:45, Michael S. Tsirkin wrote: > > > > > > > > >>> On Fri, Jul 21, 2023 at 04:37:00PM +0200, Maxime Coquelin wrote: > > > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> On 7/20/23 23:02, Michael S. Tsirkin wrote: > > > > > > > > >>>>> On Thu, Jul 20, 2023 at 01:26:20PM -0700, Shannon Nelson wrote: > > > > > > > > >>>>>> On 7/20/23 1:38 AM, Jason Wang wrote: > > > > > > > > >>>>>>> > > > > > > > > >>>>>>> Adding cond_resched() to the command waiting loop for a better > > > > > > > > >>>>>>> co-operation with the scheduler. This allows to give CPU a breath to > > > > > > > > >>>>>>> run other task(workqueue) instead of busy looping when preemption is > > > > > > > > >>>>>>> not allowed on a device whose CVQ might be slow. > > > > > > > > >>>>>>> > > > > > > > > >>>>>>> Signed-off-by: Jason Wang > > > > > > > > >>>>>> > > > > > > > > >>>>>> This still leaves hung processes, but at least it doesn't pin the CPU any > > > > > > > > >>>>>> more. Thanks. > > > > > > > > >>>>>> Reviewed-by: Shannon Nelson > > > > > > > > >>>>>> > > > > > > > > >>>>> > > > > > > > > >>>>> I'd like to see a full solution > > > > > > > > >>>>> 1- block until interrupt > > > > > > > > > > > > > > I remember in previous versions, you worried about the extra MSI > > > > > > > vector. (Maybe I was wrong). > > > > > > > > > > > > > > > >>>> > > > > > > > > >>>> Would it make sense to also have a timeout? > > > > > > > > >>>> And when timeout expires, set FAILED bit in device status? > > > > > > > > >>> > > > > > > > > >>> virtio spec does not set any limits on the timing of vq > > > > > > > > >>> processing. > > > > > > > > >> > > > > > > > > >> Indeed, but I thought the driver could decide it is too long for it. > > > > > > > > >> > > > > > > > > >> The issue is we keep waiting with rtnl locked, it can quickly make the > > > > > > > > >> system unusable. > > > > > > > > > > > > > > > > > > if this is a problem we should find a way not to keep rtnl > > > > > > > > > locked indefinitely. > > > > > > > > > > > > > > Any ideas on this direction? Simply dropping rtnl during the busy loop > > > > > > > will result in a lot of races. This seems to require non-trivial > > > > > > > changes in the networking core. > > > > > > > > > > > > > > > > > > > > > > > From the tests I have done, I think it is. With OVS, a reconfiguration > > > > > > > > is performed when the VDUSE device is added, and when a MLX5 device is > > > > > > > > in the same bridge, it ends up doing an ioctl() that tries to take the > > > > > > > > rtnl lock. In this configuration, it is not possible to kill OVS because > > > > > > > > it is stuck trying to acquire rtnl lock for mlx5 that is held by virtio- > > > > > > > > net. > > > > > > > > > > > > > > Yeah, basically, any RTNL users would be blocked forever. > > > > > > > > > > > > > > And the infinite loop has other side effects like it blocks the freezer to work. > > > > > > > > > > > > > > To summarize, there are three issues > > > > > > > > > > > > > > 1) busy polling > > > > > > > 2) breaks freezer > > > > > > > 3) hold RTNL during the loop > > > > > > > > > > > > > > Solving 3 may help somehow for 2 e.g some pm routine e.g wireguard or > > > > > > > even virtnet_restore() itself may try to hold the lock. > > > > > > > > > > > > Yep. So my feeling currently is, the only real fix is to actually > > > > > > queue up the work in software. > > > > > > > > > > Do you mean something like: > > > > > > > > > > rtnl_lock(); > > > > > queue up the work > > > > > rtnl_unlock(); > > > > > return success; > > > > > > > > > > ? > > > > > > > > yes > > > > > > We will lose the error reporting, is it a real problem or not? > > > > Fundamental isn't it? Maybe we want a per-device flag for a asynch commands, > > and vduse will set it while hardware virtio won't. > > this way we only lose error reporting for vduse. > > This problem is not VDUSE specific, DPUs/vDPA may suffer from this as > well. This might require more thoughts. > > Thanks They really shouldn't - any NIC that takes forever to program will create issues in the networking stack. But if they do they can always set this flag too. > > > > > > > > > > > > > > > > It's mostly trivial to limit > > > > > > memory consumption, vid's is the > > > > > > only one where it would make sense to have more than > > > > > > 1 command of a given type outstanding. > > > > > > > > > > And rx mode so this implies we will fail any command if the previous > > > > > work is not finished. > > > > > > > > don't fail it, store it. > > > > > > Ok. > > > > > > Thanks > > > > > > > > > > > > > have a tree > > > > > > or a bitmap with vids to add/remove? > > > > > > > > > > Probably. > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >>>>> 2- still handle surprise removal correctly by waking in that case > > > > > > > > > > > > > > This is basically what version 1 did? > > > > > > > > > > > > > > https://lore.kernel.org/lkml/6026e801-6fda-fee9-a69b-d06a80368621@redhat.com/t/ > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > Yes - except the timeout part. > > > > > > > > > > > > > > > > > > > > >>>>> > > > > > > > > >>>>> > > > > > > > > >>>>> > > > > > > > > >>>>>>> --- > > > > > > > > >>>>>>> drivers/net/virtio_net.c | 4 +++- > > > > > > > > >>>>>>> 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > >>>>>>> > > > > > > > > >>>>>>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > > > > > > > >>>>>>> index 9f3b1d6ac33d..e7533f29b219 100644 > > > > > > > > >>>>>>> --- a/drivers/net/virtio_net.c > > > > > > > > >>>>>>> +++ b/drivers/net/virtio_net.c > > > > > > > > >>>>>>> @@ -2314,8 +2314,10 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd, > > > > > > > > >>>>>>> * into the hypervisor, so the request should be handled immediately. > > > > > > > > >>>>>>> */ > > > > > > > > >>>>>>> while (!virtqueue_get_buf(vi->cvq, &tmp) && > > > > > > > > >>>>>>> - !virtqueue_is_broken(vi->cvq)) > > > > > > > > >>>>>>> + !virtqueue_is_broken(vi->cvq)) { > > > > > > > > >>>>>>> + cond_resched(); > > > > > > > > >>>>>>> cpu_relax(); > > > > > > > > >>>>>>> + } > > > > > > > > >>>>>>> > > > > > > > > >>>>>>> return vi->ctrl->status == VIRTIO_NET_OK; > > > > > > > > >>>>>>> } > > > > > > > > >>>>>>> -- > > > > > > > > >>>>>>> 2.39.3 > > > > > > > > >>>>>>> > > > > > > > > >>>>>>> _______________________________________________ > > > > > > > > >>>>>>> Virtualization mailing list > > > > > > > > >>>>>>> Virtualization@lists.linux-foundation.org > > > > > > > > >>>>>>> https://lists.linuxfoundation.org/mailman/listinfo/virtualization > > > > > > > > >>>>> > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > >