From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 402FEC00528 for ; Thu, 27 Jul 2023 09:23:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BF9DE83E; Thu, 27 Jul 2023 11:22:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BF9DE83E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690449825; bh=brE446l0NnbsBdNTMz1eRg2anjy9QOxiUBOilEyPeeg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=r25H4scg3z5YZhS8AfrKCptgRH5ETTGHVFV+GAgxonlbmAL79QOvz88sG65UbN1Rw P4dBP5DHI6ZlY8qOBnLbr4ecEMgy5Tv2MYyFjnzaJ6UPoAvkoQfkvjCOcoxq8geNKb IWeS0hZYKqPeQAny4/Vk9LS7zB/66JxAO6KmlqnA= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4B7A2F802E8; Thu, 27 Jul 2023 11:22:29 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id CD15BF802E8; Thu, 27 Jul 2023 11:22:28 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 642CCF8019B; Thu, 27 Jul 2023 11:22:25 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1CB20F80149 for ; Thu, 27 Jul 2023 11:22:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1CB20F80149 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YRHlRDEe Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD68E61DE1; Thu, 27 Jul 2023 09:22:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5763DC433C7; Thu, 27 Jul 2023 09:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690449738; bh=brE446l0NnbsBdNTMz1eRg2anjy9QOxiUBOilEyPeeg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YRHlRDEeh2LbCOuSCaecwWzcjh/d/VRacQTDWyJZtGVeSclDSuaWppMwW2Jwuabcz j5H7GBDTiQkLArSUNoX7MVpsKX2Jx4U81JMF9wSXoAGyrU/kkr9qOadAHd7qFHtqXe lEuJpA10KIyKZn+bcTrj2P56hBcPXOsombqB+jeAX8sEO+SUUW1IBVCbkYO/j8vZmJ MKJ3XXz6A0l3S/S3CuGJyywmVXvgaHYFDFetAI+ylH2b/wCW/iE/B/E4CklyuK25pG U3/MVc260hsoEO5Fn78tyPIrcubBH49N5rNivS/jrIZsL6vBuu7n2qVTMKCFErFDvn 8kVC0m+MhinKQ== Date: Thu, 27 Jul 2023 10:22:09 +0100 From: Lee Jones To: Herve Codina Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 22/28] mfd: core: Ensure disabled devices are skiped without aborting Message-ID: <20230727092209.GA8175@google.com> References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-23-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230726150225.483464-23-herve.codina@bootlin.com> Message-ID-Hash: XKNVHFDBDZZAN2BNP47REW6JJYIONDPJ X-Message-ID-Hash: XKNVHFDBDZZAN2BNP47REW6JJYIONDPJ X-MailFrom: lee@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 26 Jul 2023, Herve Codina wrote: > The loop searching for a matching device based on its compatible > string is aborted when a matching disabled device is found. > This abort avoid to add devices as soon as one disabled device > is found. > > Continue searching for an other device instead of aborting on the > first disabled one fixes the issue. > > Fixes: 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are ignored without error") > Signed-off-by: Herve Codina > --- > drivers/mfd/mfd-core.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > index 0ed7c0d7784e..bcc26e64639a 100644 > --- a/drivers/mfd/mfd-core.c > +++ b/drivers/mfd/mfd-core.c > @@ -146,6 +146,7 @@ static int mfd_add_device(struct device *parent, int id, > struct platform_device *pdev; > struct device_node *np = NULL; > struct mfd_of_node_entry *of_entry, *tmp; > + bool disabled; > int ret = -ENOMEM; > int platform_id; > int r; > @@ -181,13 +182,13 @@ static int mfd_add_device(struct device *parent, int id, > goto fail_res; > > if (IS_ENABLED(CONFIG_OF) && parent->of_node && cell->of_compatible) { > + disabled = false; This does not appear to reside in a loop. Why not set it to false on declaration? > for_each_child_of_node(parent->of_node, np) { > if (of_device_is_compatible(np, cell->of_compatible)) { > - /* Ignore 'disabled' devices error free */ > + /* Skip 'disabled' devices */ > if (!of_device_is_available(np)) { > - of_node_put(np); Doesn't this result in a resource leak? > - ret = 0; > - goto fail_alias; > + disabled = true; > + continue; > } > > ret = mfd_match_of_node_to_dev(pdev, np, cell); > @@ -197,10 +198,17 @@ static int mfd_add_device(struct device *parent, int id, > if (ret) > goto fail_alias; > > - break; > + goto match; > } > } > > + if (disabled) { > + /* Ignore 'disabled' devices error free */ > + ret = 0; > + goto fail_alias; > + } > + > +match: > if (!pdev->dev.of_node) > pr_warn("%s: Failed to locate of_node [id: %d]\n", > cell->name, platform_id); > -- > 2.41.0 > -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACECEC001DC for ; Thu, 27 Jul 2023 09:23:12 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YRHlRDEe; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RBQKq1gmMz3cPN for ; Thu, 27 Jul 2023 19:23:11 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YRHlRDEe; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=lee@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RBQJs0JnVz3c6H for ; Thu, 27 Jul 2023 19:22:20 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD68E61DE1; Thu, 27 Jul 2023 09:22:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5763DC433C7; Thu, 27 Jul 2023 09:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690449738; bh=brE446l0NnbsBdNTMz1eRg2anjy9QOxiUBOilEyPeeg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YRHlRDEeh2LbCOuSCaecwWzcjh/d/VRacQTDWyJZtGVeSclDSuaWppMwW2Jwuabcz j5H7GBDTiQkLArSUNoX7MVpsKX2Jx4U81JMF9wSXoAGyrU/kkr9qOadAHd7qFHtqXe lEuJpA10KIyKZn+bcTrj2P56hBcPXOsombqB+jeAX8sEO+SUUW1IBVCbkYO/j8vZmJ MKJ3XXz6A0l3S/S3CuGJyywmVXvgaHYFDFetAI+ylH2b/wCW/iE/B/E4CklyuK25pG U3/MVc260hsoEO5Fn78tyPIrcubBH49N5rNivS/jrIZsL6vBuu7n2qVTMKCFErFDvn 8kVC0m+MhinKQ== Date: Thu, 27 Jul 2023 10:22:09 +0100 From: Lee Jones To: Herve Codina Subject: Re: [PATCH v2 22/28] mfd: core: Ensure disabled devices are skiped without aborting Message-ID: <20230727092209.GA8175@google.com> References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-23-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230726150225.483464-23-herve.codina@bootlin.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , alsa-devel@alsa-project.org, Thomas Petazzoni , Xiubo Li , Linus Walleij , Liam Girdwood , Eric Dumazet , Krzysztof Kozlowski , Fabio Estevam , Qiang Zhao , Shengjiu Wang , Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, Nicolin Chen , linux-gpio@vger.kernel.org, Rob Herring , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Randy Dunlap , Takashi Iwai , Li Yang , Mark Brown , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 26 Jul 2023, Herve Codina wrote: > The loop searching for a matching device based on its compatible > string is aborted when a matching disabled device is found. > This abort avoid to add devices as soon as one disabled device > is found. > > Continue searching for an other device instead of aborting on the > first disabled one fixes the issue. > > Fixes: 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are ignored without error") > Signed-off-by: Herve Codina > --- > drivers/mfd/mfd-core.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > index 0ed7c0d7784e..bcc26e64639a 100644 > --- a/drivers/mfd/mfd-core.c > +++ b/drivers/mfd/mfd-core.c > @@ -146,6 +146,7 @@ static int mfd_add_device(struct device *parent, int id, > struct platform_device *pdev; > struct device_node *np = NULL; > struct mfd_of_node_entry *of_entry, *tmp; > + bool disabled; > int ret = -ENOMEM; > int platform_id; > int r; > @@ -181,13 +182,13 @@ static int mfd_add_device(struct device *parent, int id, > goto fail_res; > > if (IS_ENABLED(CONFIG_OF) && parent->of_node && cell->of_compatible) { > + disabled = false; This does not appear to reside in a loop. Why not set it to false on declaration? > for_each_child_of_node(parent->of_node, np) { > if (of_device_is_compatible(np, cell->of_compatible)) { > - /* Ignore 'disabled' devices error free */ > + /* Skip 'disabled' devices */ > if (!of_device_is_available(np)) { > - of_node_put(np); Doesn't this result in a resource leak? > - ret = 0; > - goto fail_alias; > + disabled = true; > + continue; > } > > ret = mfd_match_of_node_to_dev(pdev, np, cell); > @@ -197,10 +198,17 @@ static int mfd_add_device(struct device *parent, int id, > if (ret) > goto fail_alias; > > - break; > + goto match; > } > } > > + if (disabled) { > + /* Ignore 'disabled' devices error free */ > + ret = 0; > + goto fail_alias; > + } > + > +match: > if (!pdev->dev.of_node) > pr_warn("%s: Failed to locate of_node [id: %d]\n", > cell->name, platform_id); > -- > 2.41.0 > -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A57FC0015E for ; Thu, 27 Jul 2023 09:22:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bZmYGjhHXyrzxHZkTIUYItdwB8+4eUR4zfHzEqQt2DA=; b=iFc2T1ejnt9XVK /N7BYFcbDNw2M5119/pFvSyVB10uQe9tg0kRqNqxPrM9p5G/P3M0jfbbSmvaAYKn7RbYzz3Dx/Cif RDT8jd4IGf9sgf0XP9Yh5EJTWNMyFRuWX4b6TmycxYNQgbkP4jDK6Xd34664vkQVLtMH9T3BKWc9N gOYRYZXccX+ASt+IJDkNIP1EIAHLuaN4zwQ1XMoCbA8z3847pI5z8RYiPlRZpBhJjA4DqE6JzEvz4 wbu3caBXgM8KP4ziNZoUGEFMaJ4UA6fc5BPi3aTFhH4mAn5bYD+99LX5UF/1oUMxxVcgcsKR4ClxR HpHj2XXXBjoRM+dQnzyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qOxCQ-00CpZp-38; Thu, 27 Jul 2023 09:22:23 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qOxCN-00CpYk-29 for linux-arm-kernel@lists.infradead.org; Thu, 27 Jul 2023 09:22:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD68E61DE1; Thu, 27 Jul 2023 09:22:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5763DC433C7; Thu, 27 Jul 2023 09:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690449738; bh=brE446l0NnbsBdNTMz1eRg2anjy9QOxiUBOilEyPeeg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YRHlRDEeh2LbCOuSCaecwWzcjh/d/VRacQTDWyJZtGVeSclDSuaWppMwW2Jwuabcz j5H7GBDTiQkLArSUNoX7MVpsKX2Jx4U81JMF9wSXoAGyrU/kkr9qOadAHd7qFHtqXe lEuJpA10KIyKZn+bcTrj2P56hBcPXOsombqB+jeAX8sEO+SUUW1IBVCbkYO/j8vZmJ MKJ3XXz6A0l3S/S3CuGJyywmVXvgaHYFDFetAI+ylH2b/wCW/iE/B/E4CklyuK25pG U3/MVc260hsoEO5Fn78tyPIrcubBH49N5rNivS/jrIZsL6vBuu7n2qVTMKCFErFDvn 8kVC0m+MhinKQ== Date: Thu, 27 Jul 2023 10:22:09 +0100 From: Lee Jones To: Herve Codina Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 22/28] mfd: core: Ensure disabled devices are skiped without aborting Message-ID: <20230727092209.GA8175@google.com> References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-23-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230726150225.483464-23-herve.codina@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230727_022219_808316_181FBA78 X-CRM114-Status: GOOD ( 25.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyNiBKdWwgMjAyMywgSGVydmUgQ29kaW5hIHdyb3RlOgoKPiBUaGUgbG9vcCBzZWFy Y2hpbmcgZm9yIGEgbWF0Y2hpbmcgZGV2aWNlIGJhc2VkIG9uIGl0cyBjb21wYXRpYmxlCj4gc3Ry aW5nIGlzIGFib3J0ZWQgd2hlbiBhIG1hdGNoaW5nIGRpc2FibGVkIGRldmljZSBpcyBmb3VuZC4K PiBUaGlzIGFib3J0IGF2b2lkIHRvIGFkZCBkZXZpY2VzIGFzIHNvb24gYXMgb25lIGRpc2FibGVk IGRldmljZQo+IGlzIGZvdW5kLgo+IAo+IENvbnRpbnVlIHNlYXJjaGluZyBmb3IgYW4gb3RoZXIg ZGV2aWNlIGluc3RlYWQgb2YgYWJvcnRpbmcgb24gdGhlCj4gZmlyc3QgZGlzYWJsZWQgb25lIGZp eGVzIHRoZSBpc3N1ZS4KPiAKPiBGaXhlczogMjIzODBiNjVkYzcwICgibWZkOiBtZmQtY29yZTog RW5zdXJlIGRpc2FibGVkIGRldmljZXMgYXJlIGlnbm9yZWQgd2l0aG91dCBlcnJvciIpCj4gU2ln bmVkLW9mZi1ieTogSGVydmUgQ29kaW5hIDxoZXJ2ZS5jb2RpbmFAYm9vdGxpbi5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvbWZkL21mZC1jb3JlLmMgfCAxOCArKysrKysrKysrKysrLS0tLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvbWZkL21mZC1jb3JlLmMgYi9kcml2ZXJzL21mZC9tZmQtY29yZS5jCj4g aW5kZXggMGVkN2MwZDc3ODRlLi5iY2MyNmU2NDYzOWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9t ZmQvbWZkLWNvcmUuYwo+ICsrKyBiL2RyaXZlcnMvbWZkL21mZC1jb3JlLmMKPiBAQCAtMTQ2LDYg KzE0Niw3IEBAIHN0YXRpYyBpbnQgbWZkX2FkZF9kZXZpY2Uoc3RydWN0IGRldmljZSAqcGFyZW50 LCBpbnQgaWQsCj4gIAlzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2Owo+ICAJc3RydWN0IGRl dmljZV9ub2RlICpucCA9IE5VTEw7Cj4gIAlzdHJ1Y3QgbWZkX29mX25vZGVfZW50cnkgKm9mX2Vu dHJ5LCAqdG1wOwo+ICsJYm9vbCBkaXNhYmxlZDsKPiAgCWludCByZXQgPSAtRU5PTUVNOwo+ICAJ aW50IHBsYXRmb3JtX2lkOwo+ICAJaW50IHI7Cj4gQEAgLTE4MSwxMyArMTgyLDEzIEBAIHN0YXRp YyBpbnQgbWZkX2FkZF9kZXZpY2Uoc3RydWN0IGRldmljZSAqcGFyZW50LCBpbnQgaWQsCj4gIAkJ Z290byBmYWlsX3JlczsKPiAgCj4gIAlpZiAoSVNfRU5BQkxFRChDT05GSUdfT0YpICYmIHBhcmVu dC0+b2Zfbm9kZSAmJiBjZWxsLT5vZl9jb21wYXRpYmxlKSB7Cj4gKwkJZGlzYWJsZWQgPSBmYWxz ZTsKClRoaXMgZG9lcyBub3QgYXBwZWFyIHRvIHJlc2lkZSBpbiBhIGxvb3AuCgpXaHkgbm90IHNl dCBpdCB0byBmYWxzZSBvbiBkZWNsYXJhdGlvbj8KCj4gIAkJZm9yX2VhY2hfY2hpbGRfb2Zfbm9k ZShwYXJlbnQtPm9mX25vZGUsIG5wKSB7Cj4gIAkJCWlmIChvZl9kZXZpY2VfaXNfY29tcGF0aWJs ZShucCwgY2VsbC0+b2ZfY29tcGF0aWJsZSkpIHsKPiAtCQkJCS8qIElnbm9yZSAnZGlzYWJsZWQn IGRldmljZXMgZXJyb3IgZnJlZSAqLwo+ICsJCQkJLyogU2tpcCAnZGlzYWJsZWQnIGRldmljZXMg Ki8KPiAgCQkJCWlmICghb2ZfZGV2aWNlX2lzX2F2YWlsYWJsZShucCkpIHsKPiAtCQkJCQlvZl9u b2RlX3B1dChucCk7CgpEb2Vzbid0IHRoaXMgcmVzdWx0IGluIGEgcmVzb3VyY2UgbGVhaz8KCj4g LQkJCQkJcmV0ID0gMDsKPiAtCQkJCQlnb3RvIGZhaWxfYWxpYXM7Cj4gKwkJCQkJZGlzYWJsZWQg PSB0cnVlOwo+ICsJCQkJCWNvbnRpbnVlOwo+ICAJCQkJfQo+ICAKPiAgCQkJCXJldCA9IG1mZF9t YXRjaF9vZl9ub2RlX3RvX2RldihwZGV2LCBucCwgY2VsbCk7Cj4gQEAgLTE5NywxMCArMTk4LDE3 IEBAIHN0YXRpYyBpbnQgbWZkX2FkZF9kZXZpY2Uoc3RydWN0IGRldmljZSAqcGFyZW50LCBpbnQg aWQsCj4gIAkJCQlpZiAocmV0KQo+ICAJCQkJCWdvdG8gZmFpbF9hbGlhczsKPiAgCj4gLQkJCQli cmVhazsKPiArCQkJCWdvdG8gbWF0Y2g7Cj4gIAkJCX0KPiAgCQl9Cj4gIAo+ICsJCWlmIChkaXNh YmxlZCkgewo+ICsJCQkvKiBJZ25vcmUgJ2Rpc2FibGVkJyBkZXZpY2VzIGVycm9yIGZyZWUgKi8K PiArCQkJcmV0ID0gMDsKPiArCQkJZ290byBmYWlsX2FsaWFzOwo+ICsJCX0KPiArCj4gK21hdGNo Ogo+ICAJCWlmICghcGRldi0+ZGV2Lm9mX25vZGUpCj4gIAkJCXByX3dhcm4oIiVzOiBGYWlsZWQg dG8gbG9jYXRlIG9mX25vZGUgW2lkOiAlZF1cbiIsCj4gIAkJCQljZWxsLT5uYW1lLCBwbGF0Zm9y bV9pZCk7Cj4gLS0gCj4gMi40MS4wCj4gCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==