From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0FA1C001DC for ; Thu, 27 Jul 2023 10:19:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CC116852; Thu, 27 Jul 2023 12:19:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CC116852 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690453190; bh=Uc0Q/odHwvdufVEV8LDpUE4QUvJDILczgRcJhpTSLpo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=eHpcQQvx7+/Scf6OHXSpcarfUXdQeTe+1+fgQeDZ+PlEfzr57Y7FG/EZFftV63EWR lABdRvDYwpUxoyopIxRuBLwbB2BttlP4sBblHRpkHgbWEKqGTntzlGNwhz43xVE5BA ePQ0gqIHJEHYVIvEWm2+X+zrGx0l/5iRsHmadp5A= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4D65FF80520; Thu, 27 Jul 2023 12:18:50 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E7457F80535; Thu, 27 Jul 2023 12:18:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9D005F80548; Thu, 27 Jul 2023 12:18:46 +0200 (CEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 43A22F80535 for ; Thu, 27 Jul 2023 12:18:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 43A22F80535 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=LGBKo4DD Received: by mail.gandi.net (Postfix) with ESMTPSA id CC9DF240009; Thu, 27 Jul 2023 10:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690453120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LVq3Vc2yDzDKpJTcAR2jA40+zkxL5sFVNMLQL+uihyc=; b=LGBKo4DDE6TlLK+r5fTDq47Or6GsDCPWtkuzd8m01djTnntuS1whrhZ2QA3u0laO3aepgx rqvLj+Dz26tpJXrON2TF+vdJS7VEZAS6u+braSD1zItS8ACXGXCV/HJOaMNzrJensddzRn vLkeJfbV+0di+euOuaVZ9CDsqgncSuKL4pqV/LzInvwOK9eMrHE2IPGs6TpoFGMtc3Dz9B NAq27nwXNI7xm0DLU67stWHWnZaGSrDO6Ja3XiR87FCrQfmbtK1KH4XzlWa31FCWcSeyP1 ZOqjOi2BM6kZns8uVQmjpT0xj014mQnM1O+zGWPTUXUApK/CTHrOu0cc7swVyA== Date: Thu, 27 Jul 2023 12:18:34 +0200 From: Herve Codina To: Lee Jones Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 22/28] mfd: core: Ensure disabled devices are skiped without aborting Message-ID: <20230727121834.475541d0@bootlin.com> In-Reply-To: <20230727092209.GA8175@google.com> References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-23-herve.codina@bootlin.com> <20230727092209.GA8175@google.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Message-ID-Hash: EOJAOCRHRRCUUJ4KO5ZX7YQZQK3FU3OF X-Message-ID-Hash: EOJAOCRHRRCUUJ4KO5ZX7YQZQK3FU3OF X-MailFrom: herve.codina@bootlin.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Lee, On Thu, 27 Jul 2023 10:22:09 +0100 Lee Jones wrote: > On Wed, 26 Jul 2023, Herve Codina wrote: > > > The loop searching for a matching device based on its compatible > > string is aborted when a matching disabled device is found. > > This abort avoid to add devices as soon as one disabled device > > is found. > > > > Continue searching for an other device instead of aborting on the > > first disabled one fixes the issue. > > > > Fixes: 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are ignored without error") > > Signed-off-by: Herve Codina > > --- > > drivers/mfd/mfd-core.c | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > > index 0ed7c0d7784e..bcc26e64639a 100644 > > --- a/drivers/mfd/mfd-core.c > > +++ b/drivers/mfd/mfd-core.c > > @@ -146,6 +146,7 @@ static int mfd_add_device(struct device *parent, int id, > > struct platform_device *pdev; > > struct device_node *np = NULL; > > struct mfd_of_node_entry *of_entry, *tmp; > > + bool disabled; > > int ret = -ENOMEM; > > int platform_id; > > int r; > > @@ -181,13 +182,13 @@ static int mfd_add_device(struct device *parent, int id, > > goto fail_res; > > > > if (IS_ENABLED(CONFIG_OF) && parent->of_node && cell->of_compatible) { > > + disabled = false; > > This does not appear to reside in a loop. > > Why not set it to false on declaration? Indeed, I will change in the next iteration and set the value to false at the declaration. > > > for_each_child_of_node(parent->of_node, np) { > > if (of_device_is_compatible(np, cell->of_compatible)) { > > - /* Ignore 'disabled' devices error free */ > > + /* Skip 'disabled' devices */ > > if (!of_device_is_available(np)) { > > - of_node_put(np); > > Doesn't this result in a resource leak? No because we change from 'goto fail_alias' to 'continue' and so we don't exit from the for_each_child_of_node(). The for_each_child_of_node() calls of_get_next_child() and, in turn, calls of_node_put(). Regards, Hervé > > > - ret = 0; > > - goto fail_alias; > > + disabled = true; > > + continue; > > } > > > > ret = mfd_match_of_node_to_dev(pdev, np, cell); > > @@ -197,10 +198,17 @@ static int mfd_add_device(struct device *parent, int id, > > if (ret) > > goto fail_alias; > > > > - break; > > + goto match; > > } > > } > > > > + if (disabled) { > > + /* Ignore 'disabled' devices error free */ > > + ret = 0; > > + goto fail_alias; > > + } > > + > > +match: > > if (!pdev->dev.of_node) > > pr_warn("%s: Failed to locate of_node [id: %d]\n", > > cell->name, platform_id); > > -- > > 2.41.0 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48E73C001DC for ; Thu, 27 Jul 2023 10:19:42 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=LGBKo4DD; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RBRb04RNFz3cRR for ; Thu, 27 Jul 2023 20:19:40 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=LGBKo4DD; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::221; helo=relay1-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RBRZ13L4kz3c6H for ; Thu, 27 Jul 2023 20:18:46 +1000 (AEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id CC9DF240009; Thu, 27 Jul 2023 10:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690453120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LVq3Vc2yDzDKpJTcAR2jA40+zkxL5sFVNMLQL+uihyc=; b=LGBKo4DDE6TlLK+r5fTDq47Or6GsDCPWtkuzd8m01djTnntuS1whrhZ2QA3u0laO3aepgx rqvLj+Dz26tpJXrON2TF+vdJS7VEZAS6u+braSD1zItS8ACXGXCV/HJOaMNzrJensddzRn vLkeJfbV+0di+euOuaVZ9CDsqgncSuKL4pqV/LzInvwOK9eMrHE2IPGs6TpoFGMtc3Dz9B NAq27nwXNI7xm0DLU67stWHWnZaGSrDO6Ja3XiR87FCrQfmbtK1KH4XzlWa31FCWcSeyP1 ZOqjOi2BM6kZns8uVQmjpT0xj014mQnM1O+zGWPTUXUApK/CTHrOu0cc7swVyA== Date: Thu, 27 Jul 2023 12:18:34 +0200 From: Herve Codina To: Lee Jones Subject: Re: [PATCH v2 22/28] mfd: core: Ensure disabled devices are skiped without aborting Message-ID: <20230727121834.475541d0@bootlin.com> In-Reply-To: <20230727092209.GA8175@google.com> References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-23-herve.codina@bootlin.com> <20230727092209.GA8175@google.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , alsa-devel@alsa-project.org, Thomas Petazzoni , Xiubo Li , Linus Walleij , Liam Girdwood , Eric Dumazet , Krzysztof Kozlowski , Fabio Estevam , Qiang Zhao , Shengjiu Wang , Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, Nicolin Chen , linux-gpio@vger.kernel.org, Rob Herring , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Randy Dunlap , Takashi Iwai , Li Yang , Mark Brown , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Lee, On Thu, 27 Jul 2023 10:22:09 +0100 Lee Jones wrote: > On Wed, 26 Jul 2023, Herve Codina wrote: > > > The loop searching for a matching device based on its compatible > > string is aborted when a matching disabled device is found. > > This abort avoid to add devices as soon as one disabled device > > is found. > > > > Continue searching for an other device instead of aborting on the > > first disabled one fixes the issue. > > > > Fixes: 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are ignored without error") > > Signed-off-by: Herve Codina > > --- > > drivers/mfd/mfd-core.c | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > > index 0ed7c0d7784e..bcc26e64639a 100644 > > --- a/drivers/mfd/mfd-core.c > > +++ b/drivers/mfd/mfd-core.c > > @@ -146,6 +146,7 @@ static int mfd_add_device(struct device *parent, int id, > > struct platform_device *pdev; > > struct device_node *np = NULL; > > struct mfd_of_node_entry *of_entry, *tmp; > > + bool disabled; > > int ret = -ENOMEM; > > int platform_id; > > int r; > > @@ -181,13 +182,13 @@ static int mfd_add_device(struct device *parent, int id, > > goto fail_res; > > > > if (IS_ENABLED(CONFIG_OF) && parent->of_node && cell->of_compatible) { > > + disabled = false; > > This does not appear to reside in a loop. > > Why not set it to false on declaration? Indeed, I will change in the next iteration and set the value to false at the declaration. > > > for_each_child_of_node(parent->of_node, np) { > > if (of_device_is_compatible(np, cell->of_compatible)) { > > - /* Ignore 'disabled' devices error free */ > > + /* Skip 'disabled' devices */ > > if (!of_device_is_available(np)) { > > - of_node_put(np); > > Doesn't this result in a resource leak? No because we change from 'goto fail_alias' to 'continue' and so we don't exit from the for_each_child_of_node(). The for_each_child_of_node() calls of_get_next_child() and, in turn, calls of_node_put(). Regards, Hervé > > > - ret = 0; > > - goto fail_alias; > > + disabled = true; > > + continue; > > } > > > > ret = mfd_match_of_node_to_dev(pdev, np, cell); > > @@ -197,10 +198,17 @@ static int mfd_add_device(struct device *parent, int id, > > if (ret) > > goto fail_alias; > > > > - break; > > + goto match; > > } > > } > > > > + if (disabled) { > > + /* Ignore 'disabled' devices error free */ > > + ret = 0; > > + goto fail_alias; > > + } > > + > > +match: > > if (!pdev->dev.of_node) > > pr_warn("%s: Failed to locate of_node [id: %d]\n", > > cell->name, platform_id); > > -- > > 2.41.0 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89042C001DC for ; Thu, 27 Jul 2023 10:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KcsMo2o2N3Gh6YOzwLbyyh496MhNY9t45Iu1TZWneUI=; b=ISZlSliJMDcDGj OtroJn2S4fY9mmOplsNetrK5Izcoxsy7aU18OXc/X/+e/60Y2NFVuFFPDZ7r4luLS7cdG+pBO7eO5 aTr0cI+k+bMi0t4Ykz6M2L9vkiot1XpJ+TR+RdF2RVVV5Q4KxWWy+TqYD/w65VesFFGgidQpvhCaT 1yyAt03t8W9mzsSk2reQE+X0AzlWbcLgjZpB2VdTfebxnmL9s4wteuEi//RcbDYHCEieqHseAYa2L MXoDLvh1GsqkEw2AD3SS0jAGGgtb551I8wMqeVs45/RwdTQOLxSjX2tX4mdnPKRxTbFWdDoRrZdRV 0cT183HE3zPH8lOjgdBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qOy53-00CyGH-1a; Thu, 27 Jul 2023 10:18:49 +0000 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qOy4z-00CyFP-17 for linux-arm-kernel@lists.infradead.org; Thu, 27 Jul 2023 10:18:47 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id CC9DF240009; Thu, 27 Jul 2023 10:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690453120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LVq3Vc2yDzDKpJTcAR2jA40+zkxL5sFVNMLQL+uihyc=; b=LGBKo4DDE6TlLK+r5fTDq47Or6GsDCPWtkuzd8m01djTnntuS1whrhZ2QA3u0laO3aepgx rqvLj+Dz26tpJXrON2TF+vdJS7VEZAS6u+braSD1zItS8ACXGXCV/HJOaMNzrJensddzRn vLkeJfbV+0di+euOuaVZ9CDsqgncSuKL4pqV/LzInvwOK9eMrHE2IPGs6TpoFGMtc3Dz9B NAq27nwXNI7xm0DLU67stWHWnZaGSrDO6Ja3XiR87FCrQfmbtK1KH4XzlWa31FCWcSeyP1 ZOqjOi2BM6kZns8uVQmjpT0xj014mQnM1O+zGWPTUXUApK/CTHrOu0cc7swVyA== Date: Thu, 27 Jul 2023 12:18:34 +0200 From: Herve Codina To: Lee Jones Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 22/28] mfd: core: Ensure disabled devices are skiped without aborting Message-ID: <20230727121834.475541d0@bootlin.com> In-Reply-To: <20230727092209.GA8175@google.com> References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-23-herve.codina@bootlin.com> <20230727092209.GA8175@google.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230727_031845_872356_7C540EFF X-CRM114-Status: GOOD ( 26.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTGVlLAoKT24gVGh1LCAyNyBKdWwgMjAyMyAxMDoyMjowOSArMDEwMApMZWUgSm9uZXMgPGxl ZUBrZXJuZWwub3JnPiB3cm90ZToKCj4gT24gV2VkLCAyNiBKdWwgMjAyMywgSGVydmUgQ29kaW5h IHdyb3RlOgo+IAo+ID4gVGhlIGxvb3Agc2VhcmNoaW5nIGZvciBhIG1hdGNoaW5nIGRldmljZSBi YXNlZCBvbiBpdHMgY29tcGF0aWJsZQo+ID4gc3RyaW5nIGlzIGFib3J0ZWQgd2hlbiBhIG1hdGNo aW5nIGRpc2FibGVkIGRldmljZSBpcyBmb3VuZC4KPiA+IFRoaXMgYWJvcnQgYXZvaWQgdG8gYWRk IGRldmljZXMgYXMgc29vbiBhcyBvbmUgZGlzYWJsZWQgZGV2aWNlCj4gPiBpcyBmb3VuZC4KPiA+ IAo+ID4gQ29udGludWUgc2VhcmNoaW5nIGZvciBhbiBvdGhlciBkZXZpY2UgaW5zdGVhZCBvZiBh Ym9ydGluZyBvbiB0aGUKPiA+IGZpcnN0IGRpc2FibGVkIG9uZSBmaXhlcyB0aGUgaXNzdWUuCj4g PiAKPiA+IEZpeGVzOiAyMjM4MGI2NWRjNzAgKCJtZmQ6IG1mZC1jb3JlOiBFbnN1cmUgZGlzYWJs ZWQgZGV2aWNlcyBhcmUgaWdub3JlZCB3aXRob3V0IGVycm9yIikKPiA+IFNpZ25lZC1vZmYtYnk6 IEhlcnZlIENvZGluYSA8aGVydmUuY29kaW5hQGJvb3RsaW4uY29tPgo+ID4gLS0tCj4gPiAgZHJp dmVycy9tZmQvbWZkLWNvcmUuYyB8IDE4ICsrKysrKysrKysrKystLS0tLQo+ID4gIDEgZmlsZSBj aGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9tZmQvbWZkLWNvcmUuYyBiL2RyaXZlcnMvbWZkL21mZC1jb3JlLmMKPiA+ IGluZGV4IDBlZDdjMGQ3Nzg0ZS4uYmNjMjZlNjQ2MzlhIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVy cy9tZmQvbWZkLWNvcmUuYwo+ID4gKysrIGIvZHJpdmVycy9tZmQvbWZkLWNvcmUuYwo+ID4gQEAg LTE0Niw2ICsxNDYsNyBAQCBzdGF0aWMgaW50IG1mZF9hZGRfZGV2aWNlKHN0cnVjdCBkZXZpY2Ug KnBhcmVudCwgaW50IGlkLAo+ID4gIAlzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2Owo+ID4g IAlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wID0gTlVMTDsKPiA+ICAJc3RydWN0IG1mZF9vZl9ub2Rl X2VudHJ5ICpvZl9lbnRyeSwgKnRtcDsKPiA+ICsJYm9vbCBkaXNhYmxlZDsKPiA+ICAJaW50IHJl dCA9IC1FTk9NRU07Cj4gPiAgCWludCBwbGF0Zm9ybV9pZDsKPiA+ICAJaW50IHI7Cj4gPiBAQCAt MTgxLDEzICsxODIsMTMgQEAgc3RhdGljIGludCBtZmRfYWRkX2RldmljZShzdHJ1Y3QgZGV2aWNl ICpwYXJlbnQsIGludCBpZCwKPiA+ICAJCWdvdG8gZmFpbF9yZXM7Cj4gPiAgCj4gPiAgCWlmIChJ U19FTkFCTEVEKENPTkZJR19PRikgJiYgcGFyZW50LT5vZl9ub2RlICYmIGNlbGwtPm9mX2NvbXBh dGlibGUpIHsKPiA+ICsJCWRpc2FibGVkID0gZmFsc2U7ICAKPiAKPiBUaGlzIGRvZXMgbm90IGFw cGVhciB0byByZXNpZGUgaW4gYSBsb29wLgo+IAo+IFdoeSBub3Qgc2V0IGl0IHRvIGZhbHNlIG9u IGRlY2xhcmF0aW9uPwoKSW5kZWVkLCBJIHdpbGwgY2hhbmdlIGluIHRoZSBuZXh0IGl0ZXJhdGlv biBhbmQgc2V0IHRoZSB2YWx1ZSB0byBmYWxzZSBhdAp0aGUgZGVjbGFyYXRpb24uCgo+IAo+ID4g IAkJZm9yX2VhY2hfY2hpbGRfb2Zfbm9kZShwYXJlbnQtPm9mX25vZGUsIG5wKSB7Cj4gPiAgCQkJ aWYgKG9mX2RldmljZV9pc19jb21wYXRpYmxlKG5wLCBjZWxsLT5vZl9jb21wYXRpYmxlKSkgewo+ ID4gLQkJCQkvKiBJZ25vcmUgJ2Rpc2FibGVkJyBkZXZpY2VzIGVycm9yIGZyZWUgKi8KPiA+ICsJ CQkJLyogU2tpcCAnZGlzYWJsZWQnIGRldmljZXMgKi8KPiA+ICAJCQkJaWYgKCFvZl9kZXZpY2Vf aXNfYXZhaWxhYmxlKG5wKSkgewo+ID4gLQkJCQkJb2Zfbm9kZV9wdXQobnApOyAgCj4gCj4gRG9l c24ndCB0aGlzIHJlc3VsdCBpbiBhIHJlc291cmNlIGxlYWs/CgpObyBiZWNhdXNlIHdlIGNoYW5n ZSBmcm9tICdnb3RvIGZhaWxfYWxpYXMnIHRvICdjb250aW51ZScgYW5kIHNvIHdlIGRvbid0CmV4 aXQgZnJvbSB0aGUgZm9yX2VhY2hfY2hpbGRfb2Zfbm9kZSgpLgpUaGUgZm9yX2VhY2hfY2hpbGRf b2Zfbm9kZSgpIGNhbGxzIG9mX2dldF9uZXh0X2NoaWxkKCkgYW5kLCBpbiB0dXJuLCBjYWxscwpv Zl9ub2RlX3B1dCgpLgoKUmVnYXJkcywKSGVydsOpCgo+IAo+ID4gLQkJCQkJcmV0ID0gMDsKPiA+ IC0JCQkJCWdvdG8gZmFpbF9hbGlhczsKPiA+ICsJCQkJCWRpc2FibGVkID0gdHJ1ZTsKPiA+ICsJ CQkJCWNvbnRpbnVlOwo+ID4gIAkJCQl9Cj4gPiAgCj4gPiAgCQkJCXJldCA9IG1mZF9tYXRjaF9v Zl9ub2RlX3RvX2RldihwZGV2LCBucCwgY2VsbCk7Cj4gPiBAQCAtMTk3LDEwICsxOTgsMTcgQEAg c3RhdGljIGludCBtZmRfYWRkX2RldmljZShzdHJ1Y3QgZGV2aWNlICpwYXJlbnQsIGludCBpZCwK PiA+ICAJCQkJaWYgKHJldCkKPiA+ICAJCQkJCWdvdG8gZmFpbF9hbGlhczsKPiA+ICAKPiA+IC0J CQkJYnJlYWs7Cj4gPiArCQkJCWdvdG8gbWF0Y2g7Cj4gPiAgCQkJfQo+ID4gIAkJfQo+ID4gIAo+ ID4gKwkJaWYgKGRpc2FibGVkKSB7Cj4gPiArCQkJLyogSWdub3JlICdkaXNhYmxlZCcgZGV2aWNl cyBlcnJvciBmcmVlICovCj4gPiArCQkJcmV0ID0gMDsKPiA+ICsJCQlnb3RvIGZhaWxfYWxpYXM7 Cj4gPiArCQl9Cj4gPiArCj4gPiArbWF0Y2g6Cj4gPiAgCQlpZiAoIXBkZXYtPmRldi5vZl9ub2Rl KQo+ID4gIAkJCXByX3dhcm4oIiVzOiBGYWlsZWQgdG8gbG9jYXRlIG9mX25vZGUgW2lkOiAlZF1c biIsCj4gPiAgCQkJCWNlbGwtPm5hbWUsIHBsYXRmb3JtX2lkKTsKPiA+IC0tIAo+ID4gMi40MS4w Cj4gPiAgIAo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK