All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Hanna Reitz <hreitz@redhat.com>,
	qemu-block@nongnu.org
Subject: Re: [PATCH v2 0/4] block/blkio: fix opening virtio-blk drivers
Date: Thu, 27 Jul 2023 15:58:26 -0400	[thread overview]
Message-ID: <20230727195826.GA986673@fedora> (raw)
In-Reply-To: <20230727161020.84213-1-sgarzare@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

On Thu, Jul 27, 2023 at 06:10:16PM +0200, Stefano Garzarella wrote:
> There is a problem with virtio-blk-vhost-vdpa.
> The first patch does some preparation changes. The second and third patches
> fix the issues, the last patch tries to prepare QEMU for a future version of
> libblkio where we can use blkio_set_fd() to check whether the property is
> supported or not.
> 
> While testing, I realized that the main problem was that qemu_open() does not
> support UDS, but still the problem with blkio_connect() which can fail remains.
> 
> v2:
> - added first patch in preparation of the others
> - reworked patch 2 retrying blkio_connect [Stefan]
> - added patch 3 since qemu_open() fails in UDS
> - changed patch 4 commit description [Stefan]
> 
> v1: https://lore.kernel.org/qemu-devel/20230724154611.178858-1-sgarzare@redhat.com/
> 
> Based on stefanha/block branch.
> 
> Stefano Garzarella (4):
>   block/blkio: move blkio_connect() in the drivers functions
>   block/blkio: retry blkio_connect() if it fails using `fd`
>   block/blkio: fall back on using `path` when `fd` setting fails
>   block/blkio: use blkio_set_int("fd") to check fd support
> 
>  block/blkio.c | 108 +++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 75 insertions(+), 33 deletions(-)
> 
> -- 
> 2.41.0
> 

Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2023-07-27 20:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-27 16:10 [PATCH v2 0/4] block/blkio: fix opening virtio-blk drivers Stefano Garzarella
2023-07-27 16:10 ` [PATCH v2 1/4] block/blkio: move blkio_connect() in the drivers functions Stefano Garzarella
2023-07-27 16:10 ` [PATCH v2 2/4] block/blkio: retry blkio_connect() if it fails using `fd` Stefano Garzarella
2023-07-27 16:10 ` [PATCH v2 3/4] block/blkio: fall back on using `path` when `fd` setting fails Stefano Garzarella
2023-07-27 16:10 ` [PATCH v2 4/4] block/blkio: use blkio_set_int("fd") to check fd support Stefano Garzarella
2023-07-27 19:58 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230727195826.GA986673@fedora \
    --to=stefanha@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.